2024-03-01 14:46:05

by Muhammad Usama Anjum

[permalink] [raw]
Subject: [PATCH] scsi: lpfc: correct size for wqe for memset

The wqe is of type lpfc_wqe128. It should be memset with the same type.

Fixes: 6c621a2229b0 ("scsi: lpfc: Separate NVMET RQ buffer posting from IO resources SGL/iocbq/context")
Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
index 8258b771bd009..29bc6cd10fd69 100644
--- a/drivers/scsi/lpfc/lpfc_nvmet.c
+++ b/drivers/scsi/lpfc/lpfc_nvmet.c
@@ -1586,7 +1586,7 @@ lpfc_nvmet_setup_io_context(struct lpfc_hba *phba)
wqe = &nvmewqe->wqe;

/* Initialize WQE */
- memset(wqe, 0, sizeof(union lpfc_wqe));
+ memset(wqe, 0, sizeof(union lpfc_wqe128));

ctx_buf->iocbq->cmd_dmabuf = NULL;
spin_lock(&phba->sli4_hba.sgl_list_lock);
--
2.39.2



2024-03-01 19:33:31

by Justin Tee

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: correct size for wqe for memset

Hi Muhammad,

> - memset(wqe, 0, sizeof(union lpfc_wqe));
> + memset(wqe, 0, sizeof(union lpfc_wqe128));

How about instead memset(wqe, 0, sizeof(*wqe));

Thanks,
Justin

2024-03-04 08:52:30

by Muhammad Usama Anjum

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: correct size for wqe for memset

I'll send v2.

On 3/2/24 12:02 AM, Justin Tee wrote:
> Hi Muhammad,
>
>> - memset(wqe, 0, sizeof(union lpfc_wqe));
>> + memset(wqe, 0, sizeof(union lpfc_wqe128));
>
> How about instead memset(wqe, 0, sizeof(*wqe));
>
> Thanks,
> Justin
>

--
BR,
Muhammad Usama Anjum

Subject: Re: [PATCH] scsi: lpfc: correct size for wqe for memset

Il 01/03/24 15:44, Muhammad Usama Anjum ha scritto:
> The wqe is of type lpfc_wqe128. It should be memset with the same type.
>
> Fixes: 6c621a2229b0 ("scsi: lpfc: Separate NVMET RQ buffer posting from IO resources SGL/iocbq/context")
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index 8258b771bd009..29bc6cd10fd69 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -1586,7 +1586,7 @@ lpfc_nvmet_setup_io_context(struct lpfc_hba *phba)
> wqe = &nvmewqe->wqe;
>
> /* Initialize WQE */
> - memset(wqe, 0, sizeof(union lpfc_wqe));
> + memset(wqe, 0, sizeof(union lpfc_wqe128));

memset(wqe, 0, sizeof(*wqe));

Cheers,
Angelo