2022-11-30 10:45:30

by Benjamin Tissoires

Subject: [PATCH 0/2] HID-BPF: Kconfig fix

Hi,

As discussed in [1], we need to add some more dependencies to HID-BPF in
the Kconfig. This way, when fmod_ret will be available on arm64, HID-BPF
will get enabled automatically.

Jon, would you mind giving a shot at that patch on your test system and
confirm the error disappeard?

Cheers,
Benjamin



[1] https://lore.kernel.org/r/CABRcYmKyRchQhabi1Vd9RcMQFCcb=EtWyEbFDFRTc-L-U8WhgA@mail.gmail.com

Benjamin Tissoires (2):
HID: bpf: enforce HID_BPF dependencies
selftests: hid: ensures we have the proper requirements in config

drivers/hid/bpf/Kconfig | 4 +++-
tools/testing/selftests/hid/config | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)

--
2.38.1

2022-11-30 10:45:43

by Benjamin Tissoires

Subject: [PATCH 2/2] selftests: hid: ensures we have the proper requirements in config

They are implicit right now but might get defaulted to N in the future,
so force them in the config so we don't get any surprises.

Signed-off-by: Benjamin Tissoires <[email protected]>
---
tools/testing/selftests/hid/config | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/hid/config b/tools/testing/selftests/hid/config
index d4130489c1b1..e3595b4a3708 100644
--- a/tools/testing/selftests/hid/config
+++ b/tools/testing/selftests/hid/config
@@ -11,8 +11,10 @@ CONFIG_BPF_SYSCALL=y
CONFIG_BPF=y
CONFIG_CGROUP_BPF=y
CONFIG_DEBUG_INFO_BTF=y
+CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS=y
CONFIG_FPROBE=y
CONFIG_FTRACE_SYSCALLS=y
+CONFIG_FUNCTION_ERROR_INJECTION=y
CONFIG_FUNCTION_TRACER=y
CONFIG_HIDRAW=y
CONFIG_HID=y
--
2.38.1

2022-11-30 11:33:14

by Florent Revest

Subject: Re: [PATCH 0/2] HID-BPF: Kconfig fix

On Wed, Nov 30, 2022 at 11:10 AM Benjamin Tissoires
<[email protected]> wrote:
>
> Hi,
>
> As discussed in [1], we need to add some more dependencies to HID-BPF in
> the Kconfig. This way, when fmod_ret will be available on arm64, HID-BPF
> will get enabled automatically.
>
> Jon, would you mind giving a shot at that patch on your test system and
> confirm the error disappeard?
>
> Cheers,
> Benjamin
>
>
>
> [1] https://lore.kernel.org/r/CABRcYmKyRchQhabi1Vd9RcMQFCcb=EtWyEbFDFRTc-L-U8WhgA@mail.gmail.com
>
> Benjamin Tissoires (2):
> HID: bpf: enforce HID_BPF dependencies
> selftests: hid: ensures we have the proper requirements in config
>
> drivers/hid/bpf/Kconfig | 4 +++-
> tools/testing/selftests/hid/config | 2 ++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> --
> 2.38.1

Reviewed-by: Florent Revest <[email protected]>

2022-12-01 10:32:53

by Jon Hunter

Subject: Re: [PATCH 0/2] HID-BPF: Kconfig fix

Hi Benjamin,

On 30/11/2022 10:10, Benjamin Tissoires wrote:
> Hi,
>
> As discussed in [1], we need to add some more dependencies to HID-BPF in
> the Kconfig. This way, when fmod_ret will be available on arm64, HID-BPF
> will get enabled automatically.
>
> Jon, would you mind giving a shot at that patch on your test system and
> confirm the error disappeard?

Yes will test today. Thanks!

Jon
--
nvpublic