2023-06-10 19:05:23

by SeongJae Park

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: Add source tree entry for kunit

Patches for kunit are managed in linux-kselftest tree before merged into
the mainline, but the MAINTAINERS section for kunit doesn't have the
entry for the tree. Add it.

Signed-off-by: SeongJae Park <[email protected]>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ce5f343c1443..8a217438956b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11327,6 +11327,7 @@ L: [email protected]
L: [email protected]
S: Maintained
W: https://google.github.io/kunit-docs/third_party/kernel/docs/
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
F: Documentation/dev-tools/kunit/
F: include/kunit/
F: lib/kunit/
--
2.25.1



2023-06-13 00:13:45

by SeongJae Park

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Add source tree entry for kunit

On Tue, 13 Jun 2023 07:54:01 +0800 David Gow <[email protected]> wrote:

> [-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
>
> On Sun, 11 Jun 2023 at 02:05, SeongJae Park <[email protected]> wrote:
> >
> > Patches for kunit are managed in linux-kselftest tree before merged into
> > the mainline, but the MAINTAINERS section for kunit doesn't have the
> > entry for the tree. Add it.
> >
> > Signed-off-by: SeongJae Park <[email protected]>
> > ---
>
> Thanks very much.

My pleasure! :)

>
> Given KUnit work happens in the kunit and kunit-fixes branches here,
> should we note those as well?

That makes sense, I will add those in the commit message with the next version
of this.

>
> -- David
>
>
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ce5f343c1443..8a217438956b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11327,6 +11327,7 @@ L: [email protected]
> > L: [email protected]
> > S: Maintained
> > W: https://google.github.io/kunit-docs/third_party/kernel/docs/
> > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
>
> Should we also mention the branch here:
> git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> kunit

I think so. Would you prefer having only one 'T' line with 'kunit' branch?
Or, both branches like below? I have no strong opinion.

T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit
T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes


Thanks,
SJ

>
> > F: Documentation/dev-tools/kunit/
> > F: include/kunit/
> > F: lib/kunit/
> > --
> > 2.25.1
> >
>

2023-06-13 00:13:45

by David Gow

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Add source tree entry for kunit

On Sun, 11 Jun 2023 at 02:05, SeongJae Park <[email protected]> wrote:
>
> Patches for kunit are managed in linux-kselftest tree before merged into
> the mainline, but the MAINTAINERS section for kunit doesn't have the
> entry for the tree. Add it.
>
> Signed-off-by: SeongJae Park <[email protected]>
> ---

Thanks very much.

Given KUnit work happens in the kunit and kunit-fixes branches here,
should we note those as well?

-- David


> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ce5f343c1443..8a217438956b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11327,6 +11327,7 @@ L: [email protected]
> L: [email protected]
> S: Maintained
> W: https://google.github.io/kunit-docs/third_party/kernel/docs/
> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git

Should we also mention the branch here:
git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
kunit

> F: Documentation/dev-tools/kunit/
> F: include/kunit/
> F: lib/kunit/
> --
> 2.25.1
>


Attachments:
smime.p7s (3.91 kB)
S/MIME Cryptographic Signature

2023-06-13 01:16:40

by David Gow

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Add source tree entry for kunit

On Tue, 13 Jun 2023 at 08:01, SeongJae Park <[email protected]> wrote:
>
> On Tue, 13 Jun 2023 07:54:01 +0800 David Gow <[email protected]> wrote:
>
> > [-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
> >
> > On Sun, 11 Jun 2023 at 02:05, SeongJae Park <[email protected]> wrote:
> > >
> > > Patches for kunit are managed in linux-kselftest tree before merged into
> > > the mainline, but the MAINTAINERS section for kunit doesn't have the
> > > entry for the tree. Add it.
> > >
> > > Signed-off-by: SeongJae Park <[email protected]>
> > > ---
> >
> > Thanks very much.
>
> My pleasure! :)
>
> >
> > Given KUnit work happens in the kunit and kunit-fixes branches here,
> > should we note those as well?
>
> That makes sense, I will add those in the commit message with the next version
> of this.
>
> >
> > -- David
> >
> >
> > > MAINTAINERS | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index ce5f343c1443..8a217438956b 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -11327,6 +11327,7 @@ L: [email protected]
> > > L: [email protected]
> > > S: Maintained
> > > W: https://google.github.io/kunit-docs/third_party/kernel/docs/
> > > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> >
> > Should we also mention the branch here:
> > git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> > kunit
>
> I think so. Would you prefer having only one 'T' line with 'kunit' branch?
> Or, both branches like below? I have no strong opinion.
>
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes
>
>

Let's go with both, assuming no-one else objects.

Cheers,
-- David


Attachments:
smime.p7s (3.91 kB)
S/MIME Cryptographic Signature