2024-01-10 18:55:51

by Dan Carpenter

[permalink] [raw]

Subject: [PATCH] kunit: device: Fix a NULL vs IS_ERR() check in init()

---

The root_device_register() function does not return NULL, it returns
error pointers. Fix the check to match.

Fixes: d03c720e03bd ("kunit: Add APIs for managing devices")
Signed-off-by: Dan Carpenter <[email protected]>
---
lib/kunit/device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/kunit/device.c b/lib/kunit/device.c
index f5371287b375..074c6dd2e36a 100644
--- a/lib/kunit/device.c
+++ b/lib/kunit/device.c
@@ -45,8 +45,8 @@ int kunit_bus_init(void)
int error;

kunit_bus_device = root_device_register("kunit");
- if (!kunit_bus_device)
- return -ENOMEM;
+ if (IS_ERR(kunit_bus_device))
+ return PTR_ERR(kunit_bus_device);

error = bus_register(&kunit_bus_type);
if (error)
--
2.43.0

2024-01-11 23:44:10

by David Gow

[permalink] [raw]

Subject: Re: [PATCH] kunit: device: Fix a NULL vs IS_ERR() check in init()

---

On Thu, 11 Jan 2024 at 02:55, Dan Carpenter <[email protected]> wrote:
>
> The root_device_register() function does not return NULL, it returns
> error pointers. Fix the check to match.
>
> Fixes: d03c720e03bd ("kunit: Add APIs for managing devices")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---

Thanks for catching this.

Reviewed-by: David Gow <[email protected]>

Cheers,
-- David

---

Attachments:

smime.p7s (3.92 kB)
S/MIME Cryptographic Signature