2023-03-15 23:42:03

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH] kunit: Use gfp in kunit_alloc_resource() kernel-doc

---

Copy/pasting the code from the kernel-doc here doesn't compile because
kunit_alloc_resource() takes a gfp flags argument. Pass the gfp
argument from the caller to complete the example.

Signed-off-by: Stephen Boyd <[email protected]>
---
include/kunit/resource.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/kunit/resource.h b/include/kunit/resource.h
index cf6fb8f2ac1b..c0d88b318e90 100644
--- a/include/kunit/resource.h
+++ b/include/kunit/resource.h
@@ -72,7 +72,7 @@ typedef void (*kunit_resource_free_t)(struct kunit_resource *);
* params.gfp = gfp;
*
* return kunit_alloc_resource(test, kunit_kmalloc_init,
- * kunit_kmalloc_free, &params);
+ * kunit_kmalloc_free, gfp, &params);
* }
*
* Resources can also be named, with lookup/removal done on a name

base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git

2023-03-16 03:36:39

by David Gow

[permalink] [raw]

Subject: Re: [PATCH] kunit: Use gfp in kunit_alloc_resource() kernel-doc

---

On Thu, 16 Mar 2023 at 07:39, Stephen Boyd <[email protected]> wrote:
>
> Copy/pasting the code from the kernel-doc here doesn't compile because
> kunit_alloc_resource() takes a gfp flags argument. Pass the gfp
> argument from the caller to complete the example.
>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---

Nice catch!

Reviewed-by: David Gow <[email protected]>

Cheers,
-- David

> include/kunit/resource.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/resource.h b/include/kunit/resource.h
> index cf6fb8f2ac1b..c0d88b318e90 100644
> --- a/include/kunit/resource.h
> +++ b/include/kunit/resource.h
> @@ -72,7 +72,7 @@ typedef void (*kunit_resource_free_t)(struct kunit_resource *);
> * params.gfp = gfp;
> *
> * return kunit_alloc_resource(test, kunit_kmalloc_init,
> - * kunit_kmalloc_free, &params);
> + * kunit_kmalloc_free, gfp, &params);
> * }
> *
> * Resources can also be named, with lookup/removal done on a name
>
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
>

---

Attachments:

smime.p7s (3.91 kB)
S/MIME Cryptographic Signature