Fix this kernel test robot warning:
drivers/mfd/atmel-flexcom.c:108:32: warning: unused
variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
is not selected, so marking it as __maybe_unsed.
Signed-off-by: Aashish Sharma <[email protected]>
---
drivers/mfd/atmel-flexcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
index 559eb4d352b6..33caa4fba6af 100644
--- a/drivers/mfd/atmel-flexcom.c
+++ b/drivers/mfd/atmel-flexcom.c
@@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
return 0;
}
-static const struct dev_pm_ops atmel_flexcom_pm_ops = {
+static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
.resume_noirq = atmel_flexcom_resume_noirq,
};
--
2.35.1.574.g5d30c73bfb-goog
On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <[email protected]> wrote:
>
> Fix this kernel test robot warning:
>
> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>
> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
> is not selected, so marking it as __maybe_unsed.
>
> Signed-off-by: Aashish Sharma <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
> ---
> drivers/mfd/atmel-flexcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index 559eb4d352b6..33caa4fba6af 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
> return 0;
> }
>
> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
> .resume_noirq = atmel_flexcom_resume_noirq,
> };
>
> --
> 2.35.1.574.g5d30c73bfb-goog
>
On Mon, 28 Feb 2022, [email protected] wrote:
> On 25.02.2022 21:00, Guenter Roeck wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <[email protected]> wrote:
> >>
> >> Fix this kernel test robot warning:
> >>
> >> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
> >> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
> >>
> >> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
> >> is not selected, so marking it as __maybe_unsed.
> >>
> >> Signed-off-by: Aashish Sharma <[email protected]>
> >
> > Reviewed-by: Guenter Roeck <[email protected]>
>
> There is already [1] posted a while ago...
>
> [1] https://lkml.org/lkml/2021/12/7/474
Lost in the ether!
If this happens again, please resubmit a [RESEND].
Applied now though, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On 25.02.2022 21:00, Guenter Roeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <[email protected]> wrote:
>>
>> Fix this kernel test robot warning:
>>
>> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
>> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>>
>> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
>> is not selected, so marking it as __maybe_unsed.
>>
>> Signed-off-by: Aashish Sharma <[email protected]>
>
> Reviewed-by: Guenter Roeck <[email protected]>
There is already [1] posted a while ago...
[1] https://lkml.org/lkml/2021/12/7/474
>
>> ---
>> drivers/mfd/atmel-flexcom.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
>> index 559eb4d352b6..33caa4fba6af 100644
>> --- a/drivers/mfd/atmel-flexcom.c
>> +++ b/drivers/mfd/atmel-flexcom.c
>> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>> return 0;
>> }
>>
>> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
>> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
>> .resume_noirq = atmel_flexcom_resume_noirq,
>> };
>>
>> --
>> 2.35.1.574.g5d30c73bfb-goog
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel