2021-08-06 18:29:31

by Andy Shevchenko

Subject: [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB

When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE
can't be built-in.

Fixes: 53067471188c ("iio / platform: cros_ec: Add cros-ec-sensorhub driver")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979
Reported-by: Jason M. <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/iio/common/cros_ec_sensors/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/common/cros_ec_sensors/Kconfig b/drivers/iio/common/cros_ec_sensors/Kconfig
index fefad9572790..b0d67ceaed55 100644
--- a/drivers/iio/common/cros_ec_sensors/Kconfig
+++ b/drivers/iio/common/cros_ec_sensors/Kconfig
@@ -4,7 +4,8 @@
#
config IIO_CROS_EC_SENSORS_CORE
tristate "ChromeOS EC Sensors Core"
- depends on SYSFS && CROS_EC_SENSORHUB
+ depends on CROS_EC_SENSORHUB=y || (CROS_EC_SENSORHUB=m && m)
+ depends on SYSFS
select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
help
--
2.30.2

2021-08-06 18:32:32

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB

On Fri, Aug 06, 2021 at 04:02:27PM +0300, Andy Shevchenko wrote:
> When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE
> can't be built-in.

> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979

Looking again into .config actually puzzles me, there shouldn't be build
errors.

--
With Best Regards,
Andy Shevchenko

2021-08-06 21:27:04

by Guenter Roeck

Subject: Re: [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB

Trying again, text only this time. Sorry for the trouble.

On Fri, Aug 6, 2021 at 6:08 AM Andy Shevchenko
<[email protected]> wrote:
>
> When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE
> can't be built-in.
>
> Fixes: 53067471188c ("iio / platform: cros_ec: Add cros-ec-sensorhub driver")
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979
> Reported-by: Jason M. <[email protected]>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/iio/common/cros_ec_sensors/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/cros_ec_sensors/Kconfig b/drivers/iio/common/cros_ec_sensors/Kconfig
> index fefad9572790..b0d67ceaed55 100644
> --- a/drivers/iio/common/cros_ec_sensors/Kconfig
> +++ b/drivers/iio/common/cros_ec_sensors/Kconfig
> @@ -4,7 +4,8 @@
> #
> config IIO_CROS_EC_SENSORS_CORE
> tristate "ChromeOS EC Sensors Core"
> - depends on SYSFS && CROS_EC_SENSORHUB
> + depends on CROS_EC_SENSORHUB=y || (CROS_EC_SENSORHUB=m && m)
> + depends on SYSFS

This seems wrong. IIO_CROS_EC_SENSORS_CORE should already be limited to m
if CROS_EC_SENSORHUB=m.

Note that I can not reproduce the problem in the bugzilla entry,
neither with mainline
nor with v5.13.6. And the configuration file published there looks fine and
already has IIO_CROS_EC_SENSORS_CORE=m.

Guenter

> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
> --
> 2.30.2
>