This series base linux 5.12-rc2
these patches will cause home ui flick when cursor moved,
there is no fix solution yet, revert these patches first.
change since v1:
add mtk-gce.txt and dts modification
Yongqiang Niu (5):
Revert "drm/mediatek: Make sure previous message done or be aborted
before send"
Revert "mailbox: mediatek: remove implementation related to
atomic_exec"
Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"
Revert "arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells
value"
arm64: dts: mediatek: mt8183: add gce information for mmsys
.../devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 +-
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 -
drivers/mailbox/mtk-cmdq-mailbox.c | 80 +++++++++++++++++++---
4 files changed, 76 insertions(+), 12 deletions(-)
--
1.8.1.1.dirty
This reverts commit e55c56df43dd11de4a6c08e3ea52ca45b51c8800.
Signed-off-by: Yongqiang Niu <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 80519a1..bc89283 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -541,7 +541,7 @@
compatible = "mediatek,mt8183-gce";
reg = <0 0x10238000 0 0x4000>;
interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_LOW>;
- #mbox-cells = <2>;
+ #mbox-cells = <3>;
clocks = <&infracfg CLK_INFRA_GCE>;
clock-names = "gce";
};
--
1.8.1.1.dirty
add gce information for mmsys
Signed-off-by: Yongqiang Niu <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index bc89283..e3a8b10 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -983,6 +983,9 @@
compatible = "mediatek,mt8183-mmsys", "syscon";
reg = <0 0x14000000 0 0x1000>;
#clock-cells = <1>;
+ mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST 1>,
+ <&gce 1 CMDQ_THR_PRIO_HIGHEST 1>;
+ mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>;
};
ovl0: ovl@14008000 {
--
1.8.1.1.dirty
On Mon, Apr 12, 2021 at 6:18 AM Yongqiang Niu
<[email protected]> wrote:
>
> This series base linux 5.12-rc2
> these patches will cause home ui flick when cursor moved,
> there is no fix solution yet, revert these patches first.
>
> change since v1:
> add mtk-gce.txt and dts modification
>
> Yongqiang Niu (5):
> Revert "drm/mediatek: Make sure previous message done or be aborted
> before send"
> Revert "mailbox: mediatek: remove implementation related to
> atomic_exec"
> Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"
> Revert "arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells
> value"
> arm64: dts: mediatek: mt8183: add gce information for mmsys
>
> .../devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 +-
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 -
> drivers/mailbox/mtk-cmdq-mailbox.c | 80 +++++++++++++++++++---
> 4 files changed, 76 insertions(+), 12 deletions(-)
>
Please break the patchsets (this and the other 3) into mailbox only
and platform specific ones.
Also, it would help if there are some acked/reviewed by some mtk folks
especially when reverting patches.
thanks
On 12/04/2021 17:29, Jassi Brar wrote:
> On Mon, Apr 12, 2021 at 6:18 AM Yongqiang Niu
> <[email protected]> wrote:
>>
>> This series base linux 5.12-rc2
>> these patches will cause home ui flick when cursor moved,
>> there is no fix solution yet, revert these patches first.
>>
>> change since v1:
>> add mtk-gce.txt and dts modification
>>
>> Yongqiang Niu (5):
>> Revert "drm/mediatek: Make sure previous message done or be aborted
>> before send"
>> Revert "mailbox: mediatek: remove implementation related to
>> atomic_exec"
>> Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"
>> Revert "arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells
>> value"
>> arm64: dts: mediatek: mt8183: add gce information for mmsys
>>
>> .../devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 +-
>> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 -
>> drivers/mailbox/mtk-cmdq-mailbox.c | 80 +++++++++++++++++++---
>> 4 files changed, 76 insertions(+), 12 deletions(-)
>>
> Please break the patchsets (this and the other 3) into mailbox only
> and platform specific ones.
> Also, it would help if there are some acked/reviewed by some mtk folks
> especially when reverting patches.
>
I'd prefer to have DT and mailbox patches together as otherwise the burden on me
to find out which patches in the driver are needed, and to check if these got
accepted, gets higher.
Regards,
Matthias
On Wed, Apr 14, 2021 at 3:51 AM Matthias Brugger <[email protected]> wrote:
>
>
>
> On 12/04/2021 17:29, Jassi Brar wrote:
> > On Mon, Apr 12, 2021 at 6:18 AM Yongqiang Niu
> > <[email protected]> wrote:
> >>
> >> This series base linux 5.12-rc2
> >> these patches will cause home ui flick when cursor moved,
> >> there is no fix solution yet, revert these patches first.
> >>
> >> change since v1:
> >> add mtk-gce.txt and dts modification
> >>
> >> Yongqiang Niu (5):
> >> Revert "drm/mediatek: Make sure previous message done or be aborted
> >> before send"
> >> Revert "mailbox: mediatek: remove implementation related to
> >> atomic_exec"
> >> Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"
> >> Revert "arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells
> >> value"
> >> arm64: dts: mediatek: mt8183: add gce information for mmsys
> >>
> >> .../devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> >> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 +-
> >> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 -
> >> drivers/mailbox/mtk-cmdq-mailbox.c | 80 +++++++++++++++++++---
> >> 4 files changed, 76 insertions(+), 12 deletions(-)
> >>
> > Please break the patchsets (this and the other 3) into mailbox only
> > and platform specific ones.
> > Also, it would help if there are some acked/reviewed by some mtk folks
> > especially when reverting patches.
> >
>
> I'd prefer to have DT and mailbox patches together as otherwise the burden on me
> to find out which patches in the driver are needed, and to check if these got
> accepted, gets higher.
>
I meant the patches that need to go via mailbox tree (controller) and the rest.
thanks.