Consumer examples in the bindings of resource providers are trivial,
useless and duplicating code. Additionally the incomplete qcom,smp2p
example triggers DT schema warnings.
Cleanup the example by removing the consumer part and fixing the
indentation to DT schema convention.
Reported-by: Rob Herring <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/mailbox/qcom-ipcc.yaml | 29 +++++++------------
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
index 866efb278813..dfdc72345a2a 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
@@ -61,23 +61,14 @@ additionalProperties: false
examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- #include <dt-bindings/mailbox/qcom-ipcc.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/mailbox/qcom-ipcc.h>
- mailbox@408000 {
- compatible = "qcom,sm8250-ipcc", "qcom,ipcc";
- reg = <0x408000 0x1000>;
- interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-controller;
- #interrupt-cells = <3>;
- #mbox-cells = <2>;
- };
-
- smp2p-modem {
- compatible = "qcom,smp2p";
- interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
- IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
- mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
-
- /* Other SMP2P fields */
- };
+ mailbox@408000 {
+ compatible = "qcom,sm8250-ipcc", "qcom,ipcc";
+ reg = <0x408000 0x1000>;
+ interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <3>;
+ #mbox-cells = <2>;
+ };
--
2.32.0
The example using qcom,smp2p should have all necessary properties, to
avoid DT schema validation warnings.
Reported-by: Rob Herring <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index 58ecc62adfaa..dd4bb2e74880 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -182,6 +182,12 @@ examples:
smp2p-mpss {
compatible = "qcom,smp2p";
+ interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&apss_shared 6>;
+ qcom,smem = <94>, <432>;
+ qcom,local-pid = <0>;
+ qcom,remote-pid = <5>;
+
ipa_smp2p_out: ipa-ap-to-modem {
qcom,entry-name = "ipa";
#qcom,smem-state-cells = <1>;
@@ -193,6 +199,7 @@ examples:
#interrupt-cells = <2>;
};
};
+
ipa@1e40000 {
compatible = "qcom,sdm845-ipa";
--
2.32.0
On 4/2/22 10:55 AM, Krzysztof Kozlowski wrote:
> The example using qcom,smp2p should have all necessary properties, to
> avoid DT schema validation warnings.
Looks good to me. The particular values don't match any
reality, but that doesn't matter for getting the syntactic
parse to pass without error or warning.
Thanks.
Reviewed-by: Alex Elder <[email protected]>
>
> Reported-by: Rob Herring <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 58ecc62adfaa..dd4bb2e74880 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -182,6 +182,12 @@ examples:
>
> smp2p-mpss {
> compatible = "qcom,smp2p";
> + interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>;
> + mboxes = <&apss_shared 6>;
> + qcom,smem = <94>, <432>;
> + qcom,local-pid = <0>;
> + qcom,remote-pid = <5>;
> +
> ipa_smp2p_out: ipa-ap-to-modem {
> qcom,entry-name = "ipa";
> #qcom,smem-state-cells = <1>;
> @@ -193,6 +199,7 @@ examples:
> #interrupt-cells = <2>;
> };
> };
> +
> ipa@1e40000 {
> compatible = "qcom,sdm845-ipa";
>
On Sat, 02 Apr 2022 17:55:51 +0200, Krzysztof Kozlowski wrote:
> The example using qcom,smp2p should have all necessary properties, to
> avoid DT schema validation warnings.
>
> Reported-by: Rob Herring <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
The netdev folks probably won't pick this up, so applied, thanks!
On Sat, 02 Apr 2022 17:55:50 +0200, Krzysztof Kozlowski wrote:
> Consumer examples in the bindings of resource providers are trivial,
> useless and duplicating code. Additionally the incomplete qcom,smp2p
> example triggers DT schema warnings.
>
> Cleanup the example by removing the consumer part and fixing the
> indentation to DT schema convention.
>
> Reported-by: Rob Herring <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/mailbox/qcom-ipcc.yaml | 29 +++++++------------
> 1 file changed, 10 insertions(+), 19 deletions(-)
>
Reviewed-by: Rob Herring <[email protected]>
On Sat, 02 Apr 2022 17:55:51 +0200, Krzysztof Kozlowski wrote:
> The example using qcom,smp2p should have all necessary properties, to
> avoid DT schema validation warnings.
>
> Reported-by: Rob Herring <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring <[email protected]>
On 02/04/2022 17:55, Krzysztof Kozlowski wrote:
> Consumer examples in the bindings of resource providers are trivial,
> useless and duplicating code. Additionally the incomplete qcom,smp2p
> example triggers DT schema warnings.
>
> Cleanup the example by removing the consumer part and fixing the
> indentation to DT schema convention.
>
> Reported-by: Rob Herring <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Jassi,
Do you plan to pick this mailbox patch?
Best regards,
Krzysztof
On Wed, Apr 20, 2022 at 3:42 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 02/04/2022 17:55, Krzysztof Kozlowski wrote:
> > Consumer examples in the bindings of resource providers are trivial,
> > useless and duplicating code. Additionally the incomplete qcom,smp2p
> > example triggers DT schema warnings.
> >
> > Cleanup the example by removing the consumer part and fixing the
> > indentation to DT schema convention.
> >
> > Reported-by: Rob Herring <[email protected]>
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Jassi,
> Do you plan to pick this mailbox patch?
>
Yes, I do. I am ok too, if you want it through some other tree as a
part of some bigger patchset.
thanks.
On 20/04/2022 16:22, Jassi Brar wrote:
> On Wed, Apr 20, 2022 at 3:42 AM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> On 02/04/2022 17:55, Krzysztof Kozlowski wrote:
>>> Consumer examples in the bindings of resource providers are trivial,
>>> useless and duplicating code. Additionally the incomplete qcom,smp2p
>>> example triggers DT schema warnings.
>>>
>>> Cleanup the example by removing the consumer part and fixing the
>>> indentation to DT schema convention.
>>>
>>> Reported-by: Rob Herring <[email protected]>
>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> Jassi,
>> Do you plan to pick this mailbox patch?
>>
> Yes, I do. I am ok too, if you want it through some other tree as a
> part of some bigger patchset.
It's not going through any other tree, so please pick it up.
Best regards,
Krzysztof