2019-03-28 00:30:37

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the phy-next tree

---

Hi Kishon,

After merging the phy-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/phy/phy.h:19,
from drivers/phy/broadcom/phy-bcm-sr-usb.c:10:
drivers/phy/broadcom/phy-bcm-sr-usb.c: In function 'bcm_usb_phy_probe':
include/linux/device.h:1138:19: warning: 'phy_cfg' may be used uninitialized in this function [-Wmaybe-uninitialized]
dev->driver_data = data;
~~~~~~~~~~~~~~~~~^~~~~~
drivers/phy/broadcom/phy-bcm-sr-usb.c:289:26: note: 'phy_cfg' was declared here
struct bcm_usb_phy_cfg *phy_cfg;
^~~~~~~

Introduced by commit

a3b96057577c ("phy: sr-usb: Add Stingray USB PHY driver")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2019-03-28 03:05:36

by Srinath Mannam

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the phy-next tree

---

Hi Stephen,

Thanks for the notice.

I sent patch to fix this warning.
https://www.mail-archive.com/[email protected]/msg1964942.html

Regards,
Srinath.

On Thu, Mar 28, 2019 at 5:59 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi Kishon,
>
> After merging the phy-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/linux/phy/phy.h:19,
> from drivers/phy/broadcom/phy-bcm-sr-usb.c:10:
> drivers/phy/broadcom/phy-bcm-sr-usb.c: In function 'bcm_usb_phy_probe':
> include/linux/device.h:1138:19: warning: 'phy_cfg' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dev->driver_data = data;
> ~~~~~~~~~~~~~~~~~^~~~~~
> drivers/phy/broadcom/phy-bcm-sr-usb.c:289:26: note: 'phy_cfg' was declared here
> struct bcm_usb_phy_cfg *phy_cfg;
> ^~~~~~~
>
> Introduced by commit
>
> a3b96057577c ("phy: sr-usb: Add Stingray USB PHY driver")
>
> --
> Cheers,
> Stephen Rothwell