2021-12-30 04:40:44

by Daniel Palmer

Subject: [PATCH] rtc: msc313: Select by default on MSTARV7

All of the ARCH_MSTARV7 chips have this RTC so it's more likey
ARCH_MSTARV7 wants it than doesn't.

At the same time fix up the indent on the depends on line that looks
like it got converted from a tab to spaces at some point.

Signed-off-by: Daniel Palmer <[email protected]>
---
drivers/rtc/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 058e56a10ab8..9acd4ea267df 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1924,7 +1924,8 @@ config RTC_DRV_WILCO_EC

config RTC_DRV_MSC313
tristate "MStar MSC313 RTC"
- depends on ARCH_MSTARV7 || COMPILE_TEST
+ depends on ARCH_MSTARV7 || COMPILE_TEST
+ default ARCH_MSTARV7
help
If you say yes here you get support for the Mstar MSC313e On-Chip
Real Time Clock.
--
2.34.1

2022-01-03 14:13:20

by Romain Perier

Subject: Re: [PATCH] rtc: msc313: Select by default on MSTARV7

Hi,

Le jeu. 30 déc. 2021 à 05:40, Daniel Palmer <[email protected]> a écrit :
>
> All of the ARCH_MSTARV7 chips have this RTC so it's more likey
> ARCH_MSTARV7 wants it than doesn't.
>
> At the same time fix up the indent on the depends on line that looks
> like it got converted from a tab to spaces at some point.
>
> Signed-off-by: Daniel Palmer <[email protected]>
> ---
> drivers/rtc/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 058e56a10ab8..9acd4ea267df 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1924,7 +1924,8 @@ config RTC_DRV_WILCO_EC
>
> config RTC_DRV_MSC313
> tristate "MStar MSC313 RTC"
> - depends on ARCH_MSTARV7 || COMPILE_TEST
> + depends on ARCH_MSTARV7 || COMPILE_TEST
> + default ARCH_MSTARV7

You still depend on ARCH_MSTARV7 so "default y" is enough. It
will only work if the dependencies are satisfied and, when it is the
case, the value can be overridden by the user.

Cheers,
Romain