2020-12-15 13:12:09

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Add support of nxp pf8x00 regulator

On Mon, Dec 14, 2020 at 11:58:49PM +0100, Adrien Grassein wrote:

> this set of patch intends to add the support of the pf8x00 PMIC
> regulators. This family of PMIC contains 12 regulators (7 bucks
> converters, 4 LDO, 1 RTC supply). All these 12 regulators are
> configurable via an OTP memory and by i2c at runtime for some
> specific properties.

This looks to have raced with the addition of support for the same
device by Jagan Teki - unfortunately I didn't register that I'd seen
other patches for the same driver go past so I applied Jagan's version
(both look to be based on original work by Troy), sorry about that.
Could you please take a look at what got merged and send incremental
improvements on top of it - I do notice that I missed the use of the
wildcard compatible in there so that needs fixing at least. :/


Attachments:
(No filename) (842.00 B)
signature.asc (499.00 B)
Download all attachments

2020-12-15 13:18:32

by Adrien Grassein

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Add support of nxp pf8x00 regulator

Le mar. 15 déc. 2020 à 14:06, Mark Brown <[email protected]> a écrit :
>
> On Mon, Dec 14, 2020 at 11:58:49PM +0100, Adrien Grassein wrote:
>
> > this set of patch intends to add the support of the pf8x00 PMIC
> > regulators. This family of PMIC contains 12 regulators (7 bucks
> > converters, 4 LDO, 1 RTC supply). All these 12 regulators are
> > configurable via an OTP memory and by i2c at runtime for some
> > specific properties.
>
> This looks to have raced with the addition of support for the same
> device by Jagan Teki - unfortunately I didn't register that I'd seen
> other patches for the same driver go past so I applied Jagan's version
> (both look to be based on original work by Troy), sorry about that.
> Could you please take a look at what got merged and send incremental
> improvements on top of it - I do notice that I missed the use of the
> wildcard compatible in there so that needs fixing at least. :/

No problem for me, I learned many things about trying to upstream this driver :)

Could you please tell me where this driver was merged?
I checked the main kernel Linux and I can find out this one.



Thanks again,
Adrien

2020-12-15 13:23:40

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Add support of nxp pf8x00 regulator

Hi Adrien,

On Tue, Dec 15, 2020 at 10:16 AM Adrien Grassein
<[email protected]> wrote:

> Could you please tell me where this driver was merged?
> I checked the main kernel Linux and I can find out this one.

It is in the linux-next tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers?h=next-20201215&id=d3795d6321ecaa55d94dc24c3b1e3cce608aabd6

Regards,

Fabio Estevam

2020-12-15 13:30:26

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Add support of nxp pf8x00 regulator

On Tue, Dec 15, 2020 at 10:20:02AM -0300, Fabio Estevam wrote:
> On Tue, Dec 15, 2020 at 10:16 AM Adrien Grassein
> <[email protected]> wrote:

> > Could you please tell me where this driver was merged?
> > I checked the main kernel Linux and I can find out this one.

> It is in the linux-next tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers?h=next-20201215&id=d3795d6321ecaa55d94dc24c3b1e3cce608aabd6

Coming to there from my for-next branch - it's also already been sent in
a pull request to Linus so will hopefully be hitting his tree soonish.


Attachments:
(No filename) (611.00 B)
signature.asc (499.00 B)
Download all attachments

2020-12-15 13:37:36

by Adrien Grassein

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Add support of nxp pf8x00 regulator

I just cloned the linux-next repo.

I will try to fix things Mark tells me to fix on my own driver.

Thanks again,


Adrien



Le mar. 15 déc. 2020 à 14:24, Mark Brown <[email protected]> a écrit :
>
> On Tue, Dec 15, 2020 at 10:20:02AM -0300, Fabio Estevam wrote:
> > On Tue, Dec 15, 2020 at 10:16 AM Adrien Grassein
> > <[email protected]> wrote:
>
> > > Could you please tell me where this driver was merged?
> > > I checked the main kernel Linux and I can find out this one.
>
> > It is in the linux-next tree:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers?h=next-20201215&id=d3795d6321ecaa55d94dc24c3b1e3cce608aabd6
>
> Coming to there from my for-next branch - it's also already been sent in
> a pull request to Linus so will hopefully be hitting his tree soonish.