2021-11-04 21:26:10

by Oskar Senft

Subject: [PATCH] ARM: dts: aspeed: tyan-s7106: Update nct7802 config

This change updates the configuration for the nct7802 hardware
monitor to correctly configure its temperature sensors.

Signed-off-by: Oskar Senft <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 23 +++++++++++++++++++++
1 file changed, 23 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
index 68f332ee1886..fc1585f34a57 100644
--- a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
@@ -213,6 +213,29 @@ &i2c0 {
nct7802@28 {
compatible = "nuvoton,nct7802";
reg = <0x28>;
+ channel@0 { /* LTD */
+ reg = <0>;
+ status = "okay";
+ };
+ channel@1 { /* RTD1 */
+ reg = <1>;
+ status = "okay";
+ sensor-type = "temperature";
+ temperature-mode = "thermistor";
+ };
+
+ channel@2 { /* RTD2 */
+ reg = <2>;
+ status = "okay";
+ sensor-type = "temperature";
+ temperature-mode = "thermistor";
+ };
+
+ channel@3 { /* RTD3 */
+ reg = <3>;
+ status = "okay";
+ sensor-type = "temperature";
+ };
};

/* Also connected to:
--
2.34.0.rc0.344.g81b53c2807-goog

2021-11-04 22:11:53

by Joel Stanley

Subject: Re: [PATCH] ARM: dts: aspeed: tyan-s7106: Update nct7802 config

On Thu, 4 Nov 2021 at 21:09, Oskar Senft <[email protected]> wrote:
>
> This change updates the configuration for the nct7802 hardware
> monitor to correctly configure its temperature sensors.
>
> Signed-off-by: Oskar Senft <[email protected]>
> ---
> arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 23 +++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
> index 68f332ee1886..fc1585f34a57 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
> @@ -213,6 +213,29 @@ &i2c0 {
> nct7802@28 {
> compatible = "nuvoton,nct7802";
> reg = <0x28>;
> + channel@0 { /* LTD */
> + reg = <0>;
> + status = "okay";

The status = "okay" should be redundant; as long as you don't specify
a status, a node is assumed to be enabled.

> + };
> + channel@1 { /* RTD1 */
> + reg = <1>;
> + status = "okay";
> + sensor-type = "temperature";
> + temperature-mode = "thermistor";
> + };
> +
> + channel@2 { /* RTD2 */
> + reg = <2>;
> + status = "okay";
> + sensor-type = "temperature";
> + temperature-mode = "thermistor";
> + };
> +
> + channel@3 { /* RTD3 */
> + reg = <3>;
> + status = "okay";
> + sensor-type = "temperature";
> + };
> };
>
> /* Also connected to:
> --
> 2.34.0.rc0.344.g81b53c2807-goog
>

2021-11-05 01:32:23

by Oskar Senft

Subject: Re: [PATCH] ARM: dts: aspeed: tyan-s7106: Update nct7802 config

Hi Joel

> > + channel@0 { /* LTD */
> > + reg = <0>;
> > + status = "okay";
>
> The status = "okay" should be redundant; as long as you don't specify
> a status, a node is assumed to be enabled.

My apologies! I know you mentioned something similar for the DTS
binding patch. I didn't realize that this was a generic statement,
rather than limited to the example in the binding. Fixed in PATCH v2.

Oskar.