2013-03-15 17:02:49

by Nicolas Schichan

[permalink] [raw]
Subject: [PATCH] seccomp: allow BPF_XOR based ALU instructions.


Signed-off-by: Nicolas Schichan <[email protected]>
---
kernel/seccomp.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/kernel/seccomp.c b/kernel/seccomp.c
index 5af44b5..b7a1004 100644
--- a/kernel/seccomp.c
+++ b/kernel/seccomp.c
@@ -160,6 +160,8 @@ static int seccomp_check_filter(struct sock_filter *filter, unsigned int flen)
case BPF_S_ALU_AND_X:
case BPF_S_ALU_OR_K:
case BPF_S_ALU_OR_X:
+ case BPF_S_ALU_XOR_K:
+ case BPF_S_ALU_XOR_X:
case BPF_S_ALU_LSH_K:
case BPF_S_ALU_LSH_X:
case BPF_S_ALU_RSH_K:
--
1.7.10.4


2013-03-15 18:12:37

by Kees Cook

[permalink] [raw]
Subject: Re: [PATCH] seccomp: allow BPF_XOR based ALU instructions.

On Fri, Mar 15, 2013 at 10:02 AM, Nicolas Schichan <[email protected]> wrote:
>
> Signed-off-by: Nicolas Schichan <[email protected]>

Ah, good catch. Thanks!

Acked-by: Kees Cook <[email protected]>

--
Kees Cook
Chrome OS Security

2013-03-25 14:54:11

by Will Drewry

[permalink] [raw]
Subject: Re: [PATCH] seccomp: allow BPF_XOR based ALU instructions.

Better late than never .. right?

Acked-by: Will Drewry <[email protected]>

Thanks!

On Fri, Mar 15, 2013 at 1:12 PM, Kees Cook <[email protected]> wrote:
> On Fri, Mar 15, 2013 at 10:02 AM, Nicolas Schichan <[email protected]> wrote:
>>
>> Signed-off-by: Nicolas Schichan <[email protected]>
>
> Ah, good catch. Thanks!
>
> Acked-by: Kees Cook <[email protected]>
>
> --
> Kees Cook
> Chrome OS Security

2013-03-26 00:09:17

by James Morris

[permalink] [raw]
Subject: Re: [PATCH] seccomp: allow BPF_XOR based ALU instructions.

On Fri, 15 Mar 2013, Nicolas Schichan wrote:

>
> Signed-off-by: Nicolas Schichan <[email protected]>
> ---
> kernel/seccomp.c | 2 ++
> 1 file changed, 2 insertions(+)

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next


--
James Morris
<[email protected]>