2014-10-22 12:29 GMT+02:00 Joe.C <[email protected]>:
> From: "Joe.C" <[email protected]>
>
> Add config options for ARCH_MT6589, ARCH_MT8127, ARCH_MT8135. The
> upcoming pinctrl, clk drivers need to isolate SoCs support base on
> these options.
>
> Signed-off-by: Joe.C <[email protected]>
> ---
> arch/arm/mach-mediatek/Kconfig | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
> index 2c043a2..25fe6cf 100644
> --- a/arch/arm/mach-mediatek/Kconfig
> +++ b/arch/arm/mach-mediatek/Kconfig
> @@ -1,6 +1,22 @@
> -config ARCH_MEDIATEK
> - bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
> +menuconfig ARCH_MEDIATEK
> + bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
> select ARM_GIC
> select MTK_TIMER
> help
> - Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
> + Support for Mediatek MT65xx & MT81xx SoCs
> +
> +if ARCH_MEDIATEK
> +
> +config MACH_MT6589
> + bool "MediaTek MT6589 SoCs support"
> + default ARCH_MEDIATEK
> +
> +config MACH_MT8127
> + bool "MediaTek MT8127 SoCs support"
> + default ARCH_MEDIATEK
> +
> +config MACH_MT8135
> + bool "MediaTek MT8135 SoCs support"
> + default ARCH_MEDIATEK
> +
> +endif
MACH_MTxxxx are not used nowhere, please remove them.
> --
> 1.8.1.1.dirty
>
--
motzblog.wordpress.com
Hi Matthias,
On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
> 2014-10-22 12:29 GMT+02:00 Joe.C <[email protected]>:
> > +
> > +if ARCH_MEDIATEK
> > +
> > +config MACH_MT6589
> > + bool "MediaTek MT6589 SoCs support"
> > + default ARCH_MEDIATEK
> > +
> > +config MACH_MT8127
> > + bool "MediaTek MT8127 SoCs support"
> > + default ARCH_MEDIATEK
> > +
> > +config MACH_MT8135
> > + bool "MediaTek MT8135 SoCs support"
> > + default ARCH_MEDIATEK
> > +
> > +endif
>
> MACH_MTxxxx are not used nowhere, please remove them.
Yes, they are not used in this series yet.
MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
mt8135 clk driver we are about to send. I don't want to create false
dependency between these 2 series so I put it here.
Do you prefer add them when they are first used?
Joe.C
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html
Hi Joe,
2014-10-22 15:31 GMT+02:00 Yingjoe Chen <[email protected]>:
>
> Hi Matthias,
>
> On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
>> 2014-10-22 12:29 GMT+02:00 Joe.C <[email protected]>:
>> > +
>> > +if ARCH_MEDIATEK
>> > +
>> > +config MACH_MT6589
>> > + bool "MediaTek MT6589 SoCs support"
>> > + default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8127
>> > + bool "MediaTek MT8127 SoCs support"
>> > + default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8135
>> > + bool "MediaTek MT8135 SoCs support"
>> > + default ARCH_MEDIATEK
>> > +
>> > +endif
>>
>> MACH_MTxxxx are not used nowhere, please remove them.
>
> Yes, they are not used in this series yet.
>
> MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
> mt8135 clk driver we are about to send. I don't want to create false
> dependency between these 2 series so I put it here.
> Do you prefer add them when they are first used?
Yes please add them, when they are first used.
Today I had a look on the pinctrl patches you mentioned. It looks to
me as if the config is not needed in the series.
Thanks,
Matthias
[0] http://thread.gmane.org/gmane.linux.ports.arm.kernel/358505
>
> Joe.C
>
> [1]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html
>
>
--
motzblog.wordpress.com
On Wed, 2014-10-22 at 15:53 +0200, Matthias Brugger wrote:
> Hi Joe,
>
> 2014-10-22 15:31 GMT+02:00 Yingjoe Chen <[email protected]>:
> >
> > Hi Matthias,
> >
> > On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
> >> 2014-10-22 12:29 GMT+02:00 Joe.C <[email protected]>:
> >> > +
> >> > +if ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT6589
> >> > + bool "MediaTek MT6589 SoCs support"
> >> > + default ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT8127
> >> > + bool "MediaTek MT8127 SoCs support"
> >> > + default ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT8135
> >> > + bool "MediaTek MT8135 SoCs support"
> >> > + default ARCH_MEDIATEK
> >> > +
> >> > +endif
> >>
> >> MACH_MTxxxx are not used nowhere, please remove them.
> >
> > Yes, they are not used in this series yet.
> >
> > MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
> > mt8135 clk driver we are about to send. I don't want to create false
> > dependency between these 2 series so I put it here.
> > Do you prefer add them when they are first used?
>
> Yes please add them, when they are first used.
> Today I had a look on the pinctrl patches you mentioned. It looks to
> me as if the config is not needed in the series.
OK, I'll remove these in next version.
Joe.C
>
> Thanks,
> Matthias
>
> [0] http://thread.gmane.org/gmane.linux.ports.arm.kernel/358505
>
> >
> > Joe.C
> >
> > [1]
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html
> >
> >
>
>
>
From: "Joe.C" <[email protected]>
We support more MediaTek SoCs now, update the description.
Signed-off-by: Joe.C <[email protected]>
---
arch/arm/mach-mediatek/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-mediatek/Kconfig
b/arch/arm/mach-mediatek/Kconfig
index 2c043a2..f73f588 100644
--- a/arch/arm/mach-mediatek/Kconfig
+++ b/arch/arm/mach-mediatek/Kconfig
@@ -1,6 +1,6 @@
config ARCH_MEDIATEK
- bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
+ bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
select ARM_GIC
select MTK_TIMER
help
- Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
+ Support for Mediatek MT65xx & MT81xx SoCs
--
1.8.1.1.dirty
Hi Matthias,
Is this series + this new 8/8 patch OK?
Anything else that I should change?
Joe.C
On Fri, 2014-10-24 at 13:37 +0800, Yingjoe Chen wrote:
> From: "Joe.C" <[email protected]>
>
> We support more MediaTek SoCs now, update the description.
>
> Signed-off-by: Joe.C <[email protected]>
> ---
> arch/arm/mach-mediatek/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mediatek/Kconfig
> b/arch/arm/mach-mediatek/Kconfig
> index 2c043a2..f73f588 100644
> --- a/arch/arm/mach-mediatek/Kconfig
> +++ b/arch/arm/mach-mediatek/Kconfig
> @@ -1,6 +1,6 @@
> config ARCH_MEDIATEK
> - bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
> + bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
> select ARM_GIC
> select MTK_TIMER
> help
> - Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
> + Support for Mediatek MT65xx & MT81xx SoCs
Hi Joe,
2014-10-31 2:37 GMT+01:00 Yingjoe Chen <[email protected]>:
> Hi Matthias,
>
> Is this series + this new 8/8 patch OK?
> Anything else that I should change?
>
I checked the patches on my mt8135 board and they work for me. So from
my site everything fine.
I added the patches to my tree [0] branches v3.19-next/soc and v3.19-next/dts
I made a small change to the commit message of patch 8 and I will try
to send the pull request asap.
Thanks,
Matthias
[0] https://github.com/mbgg/linux-mediatek
> Joe.C
>
> On Fri, 2014-10-24 at 13:37 +0800, Yingjoe Chen wrote:
>> From: "Joe.C" <[email protected]>
>>
>> We support more MediaTek SoCs now, update the description.
>>
>> Signed-off-by: Joe.C <[email protected]>
>> ---
>> arch/arm/mach-mediatek/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-mediatek/Kconfig
>> b/arch/arm/mach-mediatek/Kconfig
>> index 2c043a2..f73f588 100644
>> --- a/arch/arm/mach-mediatek/Kconfig
>> +++ b/arch/arm/mach-mediatek/Kconfig
>> @@ -1,6 +1,6 @@
>> config ARCH_MEDIATEK
>> - bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
>> + bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
>> select ARM_GIC
>> select MTK_TIMER
>> help
>> - Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
>> + Support for Mediatek MT65xx & MT81xx SoCs
>
>
>
--
motzblog.wordpress.com
2014-10-31 15:53 GMT+01:00 Matthias Brugger <[email protected]>:
> Hi Joe,
>
> 2014-10-31 2:37 GMT+01:00 Yingjoe Chen <[email protected]>:
>> Hi Matthias,
>>
>> Is this series + this new 8/8 patch OK?
>> Anything else that I should change?
>>
>
> I checked the patches on my mt8135 board and they work for me. So from
> my site everything fine.
I just had another look on them and I think they are not correct,
please see my comments in the other mail.
>
> I added the patches to my tree [0] branches v3.19-next/soc and v3.19-next/dts
> I made a small change to the commit message of patch 8 and I will try
> to send the pull request asap.
>
> Thanks,
> Matthias
>
> [0] https://github.com/mbgg/linux-mediatek
>
>> Joe.C
>>
>> On Fri, 2014-10-24 at 13:37 +0800, Yingjoe Chen wrote:
>>> From: "Joe.C" <[email protected]>
>>>
>>> We support more MediaTek SoCs now, update the description.
>>>
>>> Signed-off-by: Joe.C <[email protected]>
>>> ---
>>> arch/arm/mach-mediatek/Kconfig | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-mediatek/Kconfig
>>> b/arch/arm/mach-mediatek/Kconfig
>>> index 2c043a2..f73f588 100644
>>> --- a/arch/arm/mach-mediatek/Kconfig
>>> +++ b/arch/arm/mach-mediatek/Kconfig
>>> @@ -1,6 +1,6 @@
>>> config ARCH_MEDIATEK
>>> - bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
>>> + bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
>>> select ARM_GIC
>>> select MTK_TIMER
>>> help
>>> - Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
>>> + Support for Mediatek MT65xx & MT81xx SoCs
>>
>>
>>
>
>
>
> --
> motzblog.wordpress.com
--
motzblog.wordpress.com