2019-10-07 19:19:11

by Yizhuo Zhai

Subject: Potential NULL pointer deference in iwlwifi: mvm

Hi All:

drivers/net/wireless/intel/iwlwifi/mvm/scan.c:

Inside function iwl_mvm_power_ps_disabled_iterator(),
iwl_mvm_vif_from_mac80211()
could return NULL,however, the return value of
iwl_mvm_vif_from_mac80211() is not checked and get
used. This could potentially be unsafe.

--
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside

2019-10-07 19:24:32

by Johannes Berg

Subject: Re: Potential NULL pointer deference in iwlwifi: mvm

On Mon, 2019-10-07 at 12:19 -0700, Yizhuo Zhai wrote:
> Hi All:
>
> drivers/net/wireless/intel/iwlwifi/mvm/scan.c:
>
> Inside function iwl_mvm_power_ps_disabled_iterator(),
> iwl_mvm_vif_from_mac80211()
> could return NULL

No, it can not.

Whatever tool you've used to find this - you should fix it.

johannes