From: Chen-Yu Tsai <[email protected]>
Hi everyone,
This series adds support for SH1106 to the ssd130x OLED display
driver.
Changes since v1:
- Fixed ordering of SINO WEALTH in vendor prefix list
- Updated allOf:if: blocks in DT binding, i.e. added default values for
solomon,dclk-{div,frq}
- Added SSD130X_PAGE_COL_START_{HIGH,LOW}_SET and used that to set the
bitfields for the two commands.
I didn't feel SSD130X_PAGE_COL_START_{HIGH,LOW}_MASK was needed, as
it was the same between both commands.
- Added SH110x to the SSD130X Kconfig help texts
There are SH110[789] as well, but they don't seem to be easy to find.
The SINO WEALTH SH1106 is an OLED display driver that is somewhat
compatible with the SSD1306. It supports a slightly wider display,
at 132 instead of 128 pixels. The basic commands are the same, but
the SH1106 doesn't support the horizontal or vertical address modes.
This driver chip is found in some cheap 1.3" OLED panel modules. It
acts as a substitute for the SSD1306.
Patch 1 adds an entry to the vendor prefixes for SINO WEALTH
Eletronics Ltd.
Patch 2 adds an entry for SH1106 to the ssd1307fb binding.
Patch 3 adds support for the base "page addressing mode" to the ssd130x
driver.
Patch 4 adds support for the SH1106 to the ssd130x driver.
Please have a look.
Thanks
ChenYu
Chen-Yu Tsai (4):
dt-bindings: vendor-prefixes: Add prefix for SINO WEALTH Eletronics
Ltd.
dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106
drm/ssd130x: Support page addressing mode
drm/ssd130x: Add support for SINO WEALTH SH1106
.../bindings/display/solomon,ssd1307fb.yaml | 13 ++++
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
drivers/gpu/drm/solomon/Kconfig | 9 ++-
drivers/gpu/drm/solomon/ssd130x-i2c.c | 11 +++
drivers/gpu/drm/solomon/ssd130x.c | 73 +++++++++++++++++--
drivers/gpu/drm/solomon/ssd130x.h | 2 +
6 files changed, 99 insertions(+), 11 deletions(-)
--
2.34.1
From: Chen-Yu Tsai <[email protected]>
The SINO WEALTH SH1106 is an OLED display driver that is somewhat
compatible with the SSD1306. It supports a slightly wider display,
at 132 instead of 128 pixels. The basic commands are the same, but
the SH1106 doesn't support the horizontal or vertical address modes.
Add a compatible string for it.
Signed-off-by: Chen-Yu Tsai <[email protected]>
---
.../bindings/display/solomon,ssd1307fb.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
index 9baafd0c42dd..ade61d502edd 100644
--- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
+++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
@@ -13,6 +13,7 @@ maintainers:
properties:
compatible:
enum:
+ - sinowealth,sh1106-i2c
- solomon,ssd1305fb-i2c
- solomon,ssd1306fb-i2c
- solomon,ssd1307fb-i2c
@@ -131,6 +132,18 @@ required:
- reg
allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: sinowealth,sh1106-i2c
+ then:
+ properties:
+ solomon,dclk-div:
+ default: 1
+ solomon,dclk-frq:
+ default: 5
+
- if:
properties:
compatible:
--
2.34.1
Hello Chen-Yu,
On Wed, Apr 6, 2022 at 7:30 PM Chen-Yu Tsai <[email protected]> wrote:
>
> From: Chen-Yu Tsai <[email protected]>
>
> Hi everyone,
>
> This series adds support for SH1106 to the ssd130x OLED display
> driver.
>
Thanks for re-spinning your series. I believe that gave you my
Acked-by for most of the patches in v1 already? But it seems you
didn't pick them up.
You addressed the comments I had in v1 so those stand, for all patches:
Reviewed-by: Javier Martinez Canillas <[email protected]>
Best regards,
Javier
On 4/6/22 19:29, Chen-Yu Tsai wrote:
Pushed this series to drm-misc (drm-misc-next), thanks again for your patches!
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
Hello Geert,
On 4/11/22 15:35, Geert Uytterhoeven wrote:
> Hi Chen-Yu,
[snip]
>> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
>> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
>> @@ -13,6 +13,7 @@ maintainers:
>> properties:
>> compatible:
>> enum:
>> + - sinowealth,sh1106-i2c
>
> Please don't introduce new compatible values including the bus type.
> There is no need for that, and this will only lead to more deprecated
> compatible values soon...
>
> Oops, this is already commit 97a40c23cda5d64a ("dt-bindings:
> display: ssd1307fb: Add entry for SINO WEALTH SH1106") in
> drm-misc/for-linux-next...
>
Yeah, too late :/ I didn't think it would be controversial at the time.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
Hi Chen-Yu,
On Wed, Apr 6, 2022 at 10:13 PM Chen-Yu Tsai <[email protected]> wrote:
> From: Chen-Yu Tsai <[email protected]>
>
> The SINO WEALTH SH1106 is an OLED display driver that is somewhat
> compatible with the SSD1306. It supports a slightly wider display,
> at 132 instead of 128 pixels. The basic commands are the same, but
> the SH1106 doesn't support the horizontal or vertical address modes.
>
> Add a compatible string for it.
>
> Signed-off-by: Chen-Yu Tsai <[email protected]>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> @@ -13,6 +13,7 @@ maintainers:
> properties:
> compatible:
> enum:
> + - sinowealth,sh1106-i2c
Please don't introduce new compatible values including the bus type.
There is no need for that, and this will only lead to more deprecated
compatible values soon...
Oops, this is already commit 97a40c23cda5d64a ("dt-bindings:
display: ssd1307fb: Add entry for SINO WEALTH SH1106") in
drm-misc/for-linux-next...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds