2015-06-29 14:58:19

by Tomeu Vizoso

Subject: [PATCH] gpiolib: Fix docs for gpiochip_add_pingroup_range

gpiochip_add_pingroup_range() has a pctldev argument, not pinctrl.

Signed-off-by: Tomeu Vizoso <[email protected]>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index bf4bd1d..b1b08b3 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -671,7 +671,7 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip) {}
/**
* gpiochip_add_pingroup_range() - add a range for GPIO <-> pin mapping
* @chip: the gpiochip to add the range for
- * @pinctrl: the dev_name() of the pin controller to map to
+ * @pctldev: the pin controller to map to
* @gpio_offset: the start offset in the current gpio_chip number space
* @pin_group: name of the pin group inside the pin controller
*/
--
2.4.1

2015-06-29 15:05:50

by Javier Martinez Canillas

Subject: Re: [PATCH] gpiolib: Fix docs for gpiochip_add_pingroup_range

Hello Tomeu,

On Mon, Jun 29, 2015 at 4:56 PM, Tomeu Vizoso
<[email protected]> wrote:
> gpiochip_add_pingroup_range() has a pctldev argument, not pinctrl.
>
> Signed-off-by: Tomeu Vizoso <[email protected]>
> ---
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index bf4bd1d..b1b08b3 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -671,7 +671,7 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip) {}
> /**
> * gpiochip_add_pingroup_range() - add a range for GPIO <-> pin mapping
> * @chip: the gpiochip to add the range for
> - * @pinctrl: the dev_name() of the pin controller to map to
> + * @pctldev: the pin controller to map to
> * @gpio_offset: the start offset in the current gpio_chip number space
> * @pin_group: name of the pin group inside the pin controller
> */

Reviewed-by: Javier Martinez Canillas <[email protected]>

Best regards,
Javier