2020-07-28 02:25:20

by Qinglang Miao

[permalink] [raw]
Subject: [PATCH -next] ARM: zx: remove redundant dev_err call in zx296702_pd_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Qinglang Miao <[email protected]>
---
arch/arm/mach-zx/zx296702-pm-domain.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
index 7a08bf9dd..98376d816 100644
--- a/arch/arm/mach-zx/zx296702-pm-domain.c
+++ b/arch/arm/mach-zx/zx296702-pm-domain.c
@@ -170,7 +170,6 @@ static int zx296702_pd_probe(struct platform_device *pdev)

pcubase = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(pcubase)) {
- dev_err(&pdev->dev, "ioremap fail.\n");
return -EIO;
}

--
2.25.1


2020-07-28 14:30:54

by Jun Nie

[permalink] [raw]
Subject: Re: [PATCH -next] ARM: zx: remove redundant dev_err call in zx296702_pd_probe()

Qinglang Miao <[email protected]> 于2020年7月28日周二 上午10:24写道:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Qinglang Miao <[email protected]>
> ---
> arch/arm/mach-zx/zx296702-pm-domain.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Jun Nie <[email protected]>