2018-02-27 01:05:54

by Florian Fainelli

[permalink] [raw]
Subject: [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR

Jon attempted to fix the amount of RAM on the BCM958625HR in commit
c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
but it seems like we tripped over some poorly documented schematics.

The top-level page of the schematics says the board has 2GB, but when
you end-up scrolling to page 6, you see two chips of 4GiB (512MB) but
what the bootloader really initializes only 512MB, any attempt to use
more than that results in data aborts. Fix this again back to 512MB.

Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
Signed-off-by: Florian Fainelli <[email protected]>
---
arch/arm/boot/dts/bcm958625hr.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
index 6a44b8021702..f0e2008f7490 100644
--- a/arch/arm/boot/dts/bcm958625hr.dts
+++ b/arch/arm/boot/dts/bcm958625hr.dts
@@ -49,7 +49,7 @@

memory {
device_type = "memory";
- reg = <0x60000000 0x80000000>;
+ reg = <0x60000000 0x20000000>;
};

gpio-restart {
--
2.14.1



2018-02-27 15:04:52

by Jon Mason

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR

On Mon, Feb 26, 2018 at 8:03 PM, Florian Fainelli <[email protected]> wrote:
> Jon attempted to fix the amount of RAM on the BCM958625HR in commit
> c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
> but it seems like we tripped over some poorly documented schematics.
>
> The top-level page of the schematics says the board has 2GB, but when
> you end-up scrolling to page 6, you see two chips of 4GiB (512MB) but
> what the bootloader really initializes only 512MB, any attempt to use
> more than that results in data aborts. Fix this again back to 512MB.
>
> Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
> Signed-off-by: Florian Fainelli <[email protected]>

Acked-by: Jon Mason <[email protected]>

> ---
> arch/arm/boot/dts/bcm958625hr.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
> index 6a44b8021702..f0e2008f7490 100644
> --- a/arch/arm/boot/dts/bcm958625hr.dts
> +++ b/arch/arm/boot/dts/bcm958625hr.dts
> @@ -49,7 +49,7 @@
>
> memory {
> device_type = "memory";
> - reg = <0x60000000 0x80000000>;
> + reg = <0x60000000 0x20000000>;
> };
>
> gpio-restart {
> --
> 2.14.1
>

2018-02-28 00:40:26

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR

On 02/27/2018 07:02 AM, Jon Mason wrote:
> On Mon, Feb 26, 2018 at 8:03 PM, Florian Fainelli <[email protected]> wrote:
>> Jon attempted to fix the amount of RAM on the BCM958625HR in commit
>> c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
>> but it seems like we tripped over some poorly documented schematics.
>>
>> The top-level page of the schematics says the board has 2GB, but when
>> you end-up scrolling to page 6, you see two chips of 4GiB (512MB) but
>> what the bootloader really initializes only 512MB, any attempt to use
>> more than that results in data aborts. Fix this again back to 512MB.
>>
>> Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
>> Signed-off-by: Florian Fainelli <[email protected]>
>
> Acked-by: Jon Mason <[email protected]>

Applied to devicetree/fixes
--
Florian