2022-11-10 12:06:56

by Jakub Sitnicki

Subject: [PATCH] fault-inject: Enable stacktrace filter for x86-64

Stacktrace filtering for fault injection has been disabled on x86-64 since
2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
injection: disable stacktrace filter for x86-64").

In 2017, the ORC unwider, an alternative to DWARF unwinder has been added
in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").

We can now re-enable the stacktrace filter for x86-64.

Cc: [email protected]
Cc: [email protected]
Cc: Akinobu Mita <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Jakub Sitnicki <[email protected]>
---
lib/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 3fc7abffc7aa..32c5329b0dd9 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1963,7 +1963,6 @@ config FAIL_SUNRPC
config FAULT_INJECTION_STACKTRACE_FILTER
bool "stacktrace filter for fault-injection capabilities"
depends on FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT
- depends on !X86_64
select STACKTRACE
depends on FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
help
--
2.38.1

2022-11-11 16:56:00

by Akinobu Mita

Subject: Re: [PATCH] fault-inject: Enable stacktrace filter for x86-64

2022年11月10日(木) 20:30 Jakub Sitnicki <[email protected]>:
>
> Stacktrace filtering for fault injection has been disabled on x86-64 since
> 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
> injection: disable stacktrace filter for x86-64").
>
> In 2017, the ORC unwider, an alternative to DWARF unwinder has been added
> in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").
>
> We can now re-enable the stacktrace filter for x86-64.

The same change by Wei Yongjun is already in the linux-next via -mm tree.

But thank you for the good explanation.

2022-11-14 10:14:12

by Jakub Sitnicki

Subject: Re: [PATCH] fault-inject: Enable stacktrace filter for x86-64

On Sat, Nov 12, 2022 at 01:41 AM +09, Akinobu Mita wrote:
> 2022年11月10日(木) 20:30 Jakub Sitnicki <[email protected]>:
>>
>> Stacktrace filtering for fault injection has been disabled on x86-64 since
>> 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
>> injection: disable stacktrace filter for x86-64").
>>
>> In 2017, the ORC unwider, an alternative to DWARF unwinder has been added
>> in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").
>>
>> We can now re-enable the stacktrace filter for x86-64.
>
> The same change by Wei Yongjun is already in the linux-next via -mm tree.
>
> But thank you for the good explanation.

Thanks for letting me know. Will check linux-next next time.

Please ignore my patch. Sorry for the noise.