2022-02-21 09:40:05

by Tyrone Ting

Subject: [PATCH v2 02/11] dt-bindings: i2c: npcm: support NPCM845

From: Tyrone Ting <[email protected]>

Add compatible and nuvoton,sys-mgr description for NPCM i2c module.

Signed-off-by: Tyrone Ting <[email protected]>
Signed-off-by: Tali Perry <[email protected]>
---
.../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
index 128444942aec..809c51ac32fe 100644
--- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
@@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
title: nuvoton NPCM7XX I2C Controller Device Tree Bindings

description: |
- The NPCM750x includes sixteen I2C bus controllers. All Controllers support
- both master and slave mode. Each controller can switch between master and slave
- at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and
- RX.
+ I2C bus controllers of the NPCM series support both master and
+ slave mode. Each controller can switch between master and slave at run time
+ (i.e. IPMB mode). HW FIFO for TX and RX are supported.

maintainers:
- Tali Perry <[email protected]>

properties:
compatible:
- const: nuvoton,npcm750-i2c
+ enum:
+ - nuvoton,npcm750-i2c
+ - nuvoton,npcm845-i2c

reg:
maxItems: 1
@@ -36,11 +37,16 @@ properties:
default: 100000
enum: [100000, 400000, 1000000]

+ nuvoton,sys-mgr:
+ $ref: "/schemas/types.yaml#/definitions/phandle"
+ description: The phandle of system manager register node.
+
required:
- compatible
- reg
- interrupts
- clocks
+ - nuvoton,sys-mgr

allOf:
- $ref: /schemas/i2c/i2c-controller.yaml#
@@ -57,6 +63,7 @@ examples:
clock-frequency = <100000>;
interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
compatible = "nuvoton,npcm750-i2c";
+ nuvoton,sys-mgr = <&gcr>;
};

...
--
2.17.1

2022-02-23 01:43:55

by Rob Herring (Arm)

Subject: Re: [PATCH v2 02/11] dt-bindings: i2c: npcm: support NPCM845

On Sun, Feb 20, 2022 at 11:53:12AM +0800, Tyrone Ting wrote:
> From: Tyrone Ting <[email protected]>
>
> Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
>
> Signed-off-by: Tyrone Ting <[email protected]>
> Signed-off-by: Tali Perry <[email protected]>
> ---
> .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> index 128444942aec..809c51ac32fe 100644
> --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: nuvoton NPCM7XX I2C Controller Device Tree Bindings
>
> description: |
> - The NPCM750x includes sixteen I2C bus controllers. All Controllers support
> - both master and slave mode. Each controller can switch between master and slave
> - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and
> - RX.
> + I2C bus controllers of the NPCM series support both master and
> + slave mode. Each controller can switch between master and slave at run time
> + (i.e. IPMB mode). HW FIFO for TX and RX are supported.
>
> maintainers:
> - Tali Perry <[email protected]>
>
> properties:
> compatible:
> - const: nuvoton,npcm750-i2c
> + enum:
> + - nuvoton,npcm750-i2c
> + - nuvoton,npcm845-i2c
>
> reg:
> maxItems: 1
> @@ -36,11 +37,16 @@ properties:
> default: 100000
> enum: [100000, 400000, 1000000]
>
> + nuvoton,sys-mgr:
> + $ref: "/schemas/types.yaml#/definitions/phandle"
> + description: The phandle of system manager register node.
> +
> required:
> - compatible
> - reg
> - interrupts
> - clocks
> + - nuvoton,sys-mgr

You can't make nuvoton,sys-mgr required for existing users. You can add
an if/then schema for nuvoton,npcm845-i2c if you want to make it
required in that case.

Rob

2022-02-23 19:16:25

by Tyrone Ting

Subject: Re: [PATCH v2 02/11] dt-bindings: i2c: npcm: support NPCM845

Hi Rob:

Thank you for your comment and it'll be addressed.

Rob Herring <[email protected]> 於 2022年2月23日 週三 上午1:56寫道：
>
> On Sun, Feb 20, 2022 at 11:53:12AM +0800, Tyrone Ting wrote:
> > From: Tyrone Ting <[email protected]>
> >
> > Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
> >
> > Signed-off-by: Tyrone Ting <[email protected]>
> > Signed-off-by: Tali Perry <[email protected]>
> > ---
> > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++-----
> > 1 file changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> > index 128444942aec..809c51ac32fe 100644
> > --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> > @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> > title: nuvoton NPCM7XX I2C Controller Device Tree Bindings
> >
> > description: |
> > - The NPCM750x includes sixteen I2C bus controllers. All Controllers support
> > - both master and slave mode. Each controller can switch between master and slave
> > - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and
> > - RX.
> > + I2C bus controllers of the NPCM series support both master and
> > + slave mode. Each controller can switch between master and slave at run time
> > + (i.e. IPMB mode). HW FIFO for TX and RX are supported.
> >
> > maintainers:
> > - Tali Perry <[email protected]>
> >
> > properties:
> > compatible:
> > - const: nuvoton,npcm750-i2c
> > + enum:
> > + - nuvoton,npcm750-i2c
> > + - nuvoton,npcm845-i2c
> >
> > reg:
> > maxItems: 1
> > @@ -36,11 +37,16 @@ properties:
> > default: 100000
> > enum: [100000, 400000, 1000000]
> >
> > + nuvoton,sys-mgr:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: The phandle of system manager register node.
> > +
> > required:
> > - compatible
> > - reg
> > - interrupts
> > - clocks
> > + - nuvoton,sys-mgr
>
> You can't make nuvoton,sys-mgr required for existing users. You can add
> an if/then schema for nuvoton,npcm845-i2c if you want to make it
> required in that case.
>
> Rob

Best regards,
Tyrone