2022-09-07 22:20:09

by Anand Moon

[permalink] [raw]
Subject: [v2 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible

Add compatible string for RV1126 gmac, and constrain it to
be compatible with Synopsys dwmac 4.20a.

Reviewed-by: Heiko Stuebner <[email protected]>
Signed-off-by: Jagan Teki <[email protected]>
Signed-off-by: Anand Moon <[email protected]>
---
v2: add missing compatible string to property
added reviewed by Heiko Stuebner.
---
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
index 083623c8d718..b28bc6774bf0 100644
--- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
@@ -26,6 +26,7 @@ select:
- rockchip,rk3399-gmac
- rockchip,rk3568-gmac
- rockchip,rv1108-gmac
+ - rockchip,rv1126-gmac
required:
- compatible

@@ -47,6 +48,7 @@ properties:
- rockchip,rk3368-gmac
- rockchip,rk3399-gmac
- rockchip,rv1108-gmac
+ - rockchip,rv1126-gmac
- items:
- enum:
- rockchip,rk3568-gmac
--
2.37.3


2022-09-08 09:14:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [v2 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible

On 07/09/2022 23:06, Anand Moon wrote:
> Add compatible string for RV1126 gmac, and constrain it to
> be compatible with Synopsys dwmac 4.20a.
>
> Reviewed-by: Heiko Stuebner <[email protected]>
> Signed-off-by: Jagan Teki <[email protected]>
> Signed-off-by: Anand Moon <[email protected]>
> ---
> v2: add missing compatible string to property
> added reviewed by Heiko Stuebner.
> ---


Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-09-19 19:20:15

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [v2 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible

On Wed, 7 Sep 2022 21:06:45 +0000 Anand Moon wrote:
> Add compatible string for RV1126 gmac, and constrain it to
> be compatible with Synopsys dwmac 4.20a.

Hi, these patches don't seem to apply cleanly to net-next, a 3-way
merge is needed. Please rebase and repost. Please put [PATCH net-next
v3] in the subject as you expect them to be applied to the networking
trees.

2022-09-22 07:51:09

by Anand Moon

[permalink] [raw]
Subject: Re: [v2 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible

Hi Jakub,

On Tue, 20 Sept 2022 at 00:28, Jakub Kicinski <[email protected]> wrote:
>
> On Wed, 7 Sep 2022 21:06:45 +0000 Anand Moon wrote:
> > Add compatible string for RV1126 gmac, and constrain it to
> > be compatible with Synopsys dwmac 4.20a.
>
> Hi, these patches don't seem to apply cleanly to net-next, a 3-way
> merge is needed. Please rebase and repost. Please put [PATCH net-next
> v3] in the subject as you expect them to be applied to the networking
> trees.

Thanks I have send the patches rebased on net-next,
Please find the link below

[0] https://lore.kernel.org/all/[email protected]/

Beat Regards

-Anand