2022-06-16 14:03:51

by Eli Cohen

Subject: [PATCH RFC 3/3] vdpa/mlx5: Disable VLAN support to support live migration

Current qemu code does not support live migration for devices supporting
VLAN. Disable it.

Note: this patch is provided just to enable testing with current qemu.

Signed-off-by: Eli Cohen <[email protected]>
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index 34bd81cb697c..1568cfdf07e6 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -2172,7 +2172,6 @@ static u64 get_supported_features(struct mlx5_core_dev *mdev)
mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MQ);
mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_STATUS);
mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MTU);
- mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_CTRL_VLAN);

return mlx_vdpa_features;
}
--
2.35.1

2022-06-20 08:53:23

by Jason Wang

Subject: Re: [PATCH RFC 3/3] vdpa/mlx5: Disable VLAN support to support live migration

On Thu, Jun 16, 2022 at 9:28 PM Eli Cohen <[email protected]> wrote:
>
> Current qemu code does not support live migration for devices supporting
> VLAN. Disable it.

This looks like a bug that we need to fix in Qemu.

Thanks

>
> Note: this patch is provided just to enable testing with current qemu.
>
> Signed-off-by: Eli Cohen <[email protected]>
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 34bd81cb697c..1568cfdf07e6 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -2172,7 +2172,6 @@ static u64 get_supported_features(struct mlx5_core_dev *mdev)
> mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MQ);
> mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_STATUS);
> mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MTU);
> - mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_CTRL_VLAN);
>
> return mlx_vdpa_features;
> }
> --
> 2.35.1
>

2022-06-20 09:17:19

by Eugenio Perez Martin

Subject: Re: [PATCH RFC 3/3] vdpa/mlx5: Disable VLAN support to support live migration

On Mon, Jun 20, 2022 at 10:48 AM Jason Wang <[email protected]> wrote:
>
> On Thu, Jun 16, 2022 at 9:28 PM Eli Cohen <[email protected]> wrote:
> >
> > Current qemu code does not support live migration for devices supporting
> > VLAN. Disable it.
>
> This looks like a bug that we need to fix in Qemu.
>

Not a but, but a lack of a feature :). Each cvq command needs new code
to inject it at the destination, and only set mac cmd is implemented
at the moment. Only to start simple.

Thanks!

> Thanks
>
> >
> > Note: this patch is provided just to enable testing with current qemu.
> >
> > Signed-off-by: Eli Cohen <[email protected]>
> > ---
> > drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > index 34bd81cb697c..1568cfdf07e6 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -2172,7 +2172,6 @@ static u64 get_supported_features(struct mlx5_core_dev *mdev)
> > mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MQ);
> > mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_STATUS);
> > mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MTU);
> > - mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_CTRL_VLAN);
> >
> > return mlx_vdpa_features;
> > }
> > --
> > 2.35.1
> >
>

2022-06-20 09:27:40

by Jason Wang

Subject: Re: [PATCH RFC 3/3] vdpa/mlx5: Disable VLAN support to support live migration

On Mon, Jun 20, 2022 at 5:02 PM Eugenio Perez Martin
<[email protected]> wrote:
>
> On Mon, Jun 20, 2022 at 10:48 AM Jason Wang <[email protected]> wrote:
> >
> > On Thu, Jun 16, 2022 at 9:28 PM Eli Cohen <[email protected]> wrote:
> > >
> > > Current qemu code does not support live migration for devices supporting
> > > VLAN. Disable it.
> >
> > This looks like a bug that we need to fix in Qemu.
> >
>
> Not a but, but a lack of a feature :). Each cvq command needs new code
> to inject it at the destination, and only set mac cmd is implemented
> at the moment. Only to start simple.

I think we don't need this in the formal patch? (Anyhow we could
disable ctrl vlan vic command line)

Thanks

>
> Thanks!
>
> > Thanks
> >
> > >
> > > Note: this patch is provided just to enable testing with current qemu.
> > >
> > > Signed-off-by: Eli Cohen <[email protected]>
> > > ---
> > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index 34bd81cb697c..1568cfdf07e6 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -2172,7 +2172,6 @@ static u64 get_supported_features(struct mlx5_core_dev *mdev)
> > > mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MQ);
> > > mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_STATUS);
> > > mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_MTU);
> > > - mlx_vdpa_features |= BIT_ULL(VIRTIO_NET_F_CTRL_VLAN);
> > >
> > > return mlx_vdpa_features;
> > > }
> > > --
> > > 2.35.1
> > >
> >
>