2023-12-07 05:52:32

by Jason Wang

[permalink] [raw]
Subject: Re: [PATCH net-next 4/6] vhost/net: remove vhost_net_page_frag_refill()

On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin <[email protected]> wrote:
>
> The page frag in vhost_net_page_frag_refill() uses the
> 'struct page_frag' from skb_page_frag_refill(), but it's
> implementation is similar to page_frag_alloc_align() now.
>
> This patch removes vhost_net_page_frag_refill() by using
> 'struct page_frag_cache' instead of 'struct page_frag',
> and allocating frag using page_frag_alloc_align().
>
> The added benefit is that not only unifying the page frag
> implementation a little, but also having about 0.5% performance
> boost testing by using the vhost_net_test introduced in the
> last patch.
>
> Signed-off-by: Yunsheng Lin <[email protected]>
> ---

Acked-by: Jason Wang <[email protected]>

Thanks