2019-10-28 22:15:03

by Saurav Girepunje

Subject: [PATCH] broadcom: bnxt: Fix use true/false for bool

Use true/false for bool type in bnxt_timer function.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b4a8cf620a0c..8cdf71f8824d 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -10004,7 +10004,7 @@ static void bnxt_timer(struct timer_list *t)

if (bp->link_info.phy_retry) {
if (time_after(jiffies, bp->link_info.phy_retry_expires)) {
- bp->link_info.phy_retry = 0;
+ bp->link_info.phy_retry = false;
netdev_warn(bp->dev, "failed to update phy settings after maximum retries.\n");
} else {
set_bit(BNXT_UPDATE_PHY_SP_EVENT, &bp->sp_event);
--
2.20.1

2019-10-28 22:24:42

by Michael Chan

Subject: Re: [PATCH] broadcom: bnxt: Fix use true/false for bool

On Mon, Oct 28, 2019 at 1:16 PM Saurav Girepunje
<[email protected]> wrote:
>
> Use true/false for bool type in bnxt_timer function.
>
> Signed-off-by: Saurav Girepunje <[email protected]>

Acked-by: Michael Chan <[email protected]>

2019-10-30 00:55:40

by David Miller

Subject: Re: [PATCH] broadcom: bnxt: Fix use true/false for bool

From: Saurav Girepunje <[email protected]>
Date: Tue, 29 Oct 2019 01:46:35 +0530

> Use true/false for bool type in bnxt_timer function.
>
> Signed-off-by: Saurav Girepunje <[email protected]>

Applied.