2014-02-04 02:16:00

by Colin Cross

Subject: [PATCH] security: select correct default LSM_MMAP_MIN_ADDR on arm on arm64

Binaries compiled for arm may run on arm64 if CONFIG_COMPAT is
selected. Set LSM_MMAP_MIN_ADDR to 32768 if ARM64 && COMPAT to
prevent selinux failures launching 32-bit static executables that
are mapped at 0x8000.

Signed-off-by: Colin Cross <[email protected]>
---
security/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/Kconfig b/security/Kconfig
index e9c6ac724fef..beb86b500adf 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -103,7 +103,7 @@ config INTEL_TXT
config LSM_MMAP_MIN_ADDR
int "Low address space for LSM to protect from user allocation"
depends on SECURITY && SECURITY_SELINUX
- default 32768 if ARM
+ default 32768 if ARM || (ARM64 && COMPAT)
default 65536
help
This is the portion of low virtual memory which should be protected
--
1.9.0.rc1.175.g0b1dcb5

2014-02-04 09:39:37

by Will Deacon

Subject: Re: [PATCH] security: select correct default LSM_MMAP_MIN_ADDR on arm on arm64

On Tue, Feb 04, 2014 at 02:15:32AM +0000, Colin Cross wrote:
> Binaries compiled for arm may run on arm64 if CONFIG_COMPAT is
> selected. Set LSM_MMAP_MIN_ADDR to 32768 if ARM64 && COMPAT to
> prevent selinux failures launching 32-bit static executables that
> are mapped at 0x8000.
>
> Signed-off-by: Colin Cross <[email protected]>
> ---
> security/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/Kconfig b/security/Kconfig
> index e9c6ac724fef..beb86b500adf 100644
> --- a/security/Kconfig
> +++ b/security/Kconfig
> @@ -103,7 +103,7 @@ config INTEL_TXT
> config LSM_MMAP_MIN_ADDR
> int "Low address space for LSM to protect from user allocation"
> depends on SECURITY && SECURITY_SELINUX
> - default 32768 if ARM
> + default 32768 if ARM || (ARM64 && COMPAT)
> default 65536
> help
> This is the portion of low virtual memory which should be protected

Since ARM64 && COMPAT implies 4k pages, this change looks ok to me.

Acked-by: Will Deacon <[email protected]>

Will

2014-02-05 09:27:21

by Eric Paris

Subject: Re: [PATCH] security: select correct default LSM_MMAP_MIN_ADDR on arm on arm64

Acked-by: Eric Paris <[email protected]>

On Tue, Feb 4, 2014 at 4:38 AM, Will Deacon <[email protected]> wrote:
> On Tue, Feb 04, 2014 at 02:15:32AM +0000, Colin Cross wrote:
>> Binaries compiled for arm may run on arm64 if CONFIG_COMPAT is
>> selected. Set LSM_MMAP_MIN_ADDR to 32768 if ARM64 && COMPAT to
>> prevent selinux failures launching 32-bit static executables that
>> are mapped at 0x8000.
>>
>> Signed-off-by: Colin Cross <[email protected]>
>> ---
>> security/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/security/Kconfig b/security/Kconfig
>> index e9c6ac724fef..beb86b500adf 100644
>> --- a/security/Kconfig
>> +++ b/security/Kconfig
>> @@ -103,7 +103,7 @@ config INTEL_TXT
>> config LSM_MMAP_MIN_ADDR
>> int "Low address space for LSM to protect from user allocation"
>> depends on SECURITY && SECURITY_SELINUX
>> - default 32768 if ARM
>> + default 32768 if ARM || (ARM64 && COMPAT)
>> default 65536
>> help
>> This is the portion of low virtual memory which should be protected
>
> Since ARM64 && COMPAT implies 4k pages, this change looks ok to me.
>
> Acked-by: Will Deacon <[email protected]>
>
> Will
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2014-02-05 11:49:14

by Catalin Marinas

Subject: Re: [PATCH] security: select correct default LSM_MMAP_MIN_ADDR on arm on arm64

On Tue, Feb 04, 2014 at 02:15:32AM +0000, Colin Cross wrote:
> Binaries compiled for arm may run on arm64 if CONFIG_COMPAT is
> selected. Set LSM_MMAP_MIN_ADDR to 32768 if ARM64 && COMPAT to
> prevent selinux failures launching 32-bit static executables that
> are mapped at 0x8000.
>
> Signed-off-by: Colin Cross <[email protected]>

Acked-by: Catalin Marinas <[email protected]>

2014-02-05 13:58:07

by James Morris

Subject: Re: [PATCH] security: select correct default LSM_MMAP_MIN_ADDR on arm on arm64

On Wed, 5 Feb 2014, Catalin Marinas wrote:

> On Tue, Feb 04, 2014 at 02:15:32AM +0000, Colin Cross wrote:
> > Binaries compiled for arm may run on arm64 if CONFIG_COMPAT is
> > selected. Set LSM_MMAP_MIN_ADDR to 32768 if ARM64 && COMPAT to
> > prevent selinux failures launching 32-bit static executables that
> > are mapped at 0x8000.
> >
> > Signed-off-by: Colin Cross <[email protected]>
>
> Acked-by: Catalin Marinas <[email protected]>

Acked-by: James Morris <[email protected]>

Probably makes sense to push this through the arm tree.


--
James Morris
<[email protected]>

2014-02-05 14:58:05

by Catalin Marinas

Subject: Re: [PATCH] security: select correct default LSM_MMAP_MIN_ADDR on arm on arm64

On Wed, Feb 05, 2014 at 02:02:22PM +0000, James Morris wrote:
> On Wed, 5 Feb 2014, Catalin Marinas wrote:
>
> > On Tue, Feb 04, 2014 at 02:15:32AM +0000, Colin Cross wrote:
> > > Binaries compiled for arm may run on arm64 if CONFIG_COMPAT is
> > > selected. Set LSM_MMAP_MIN_ADDR to 32768 if ARM64 && COMPAT to
> > > prevent selinux failures launching 32-bit static executables that
> > > are mapped at 0x8000.
> > >
> > > Signed-off-by: Colin Cross <[email protected]>
> >
> > Acked-by: Catalin Marinas <[email protected]>
>
> Acked-by: James Morris <[email protected]>
>
> Probably makes sense to push this through the arm tree.

With your ack, I'm happy to take it ;)

Thanks.

--
Catalin