On Wed, 24 Apr 2024 at 13:59, Wren Turkal <[email protected]> wrote:
>
> On 4/24/24 4:53 AM, Bartosz Golaszewski wrote:
> > This must be your email client wrapping lines over a certain limit.
> > Try and get the diff from lore[1], it should be fine.
> >
> > Bart
> >
> > [1]https://lore.kernel.org/lkml/CAMRc=MepDwUbAKrWgm0CXKObqy8=igtug0QDgo-CgwxjZCAC2Q@mail.gmail.com/
>
> I don't think it's my client. The extra newlines are right there in the
> lore link.
>
> Look at the line that starts with "@@". That line is wrapped. The
> following line ("serdev_device *serdev)") should be at the end of the
> previous line. The same thing happened on the second "@@" line as well.
>
Indeed. I just noticed that it applies fine with git apply and figured
the output must be right. Anyway, this is not a proper patch, I will
send one once I adapt Zijun's code.
Bart
On 4/24/24 5:01 AM, Bartosz Golaszewski wrote:
> On Wed, 24 Apr 2024 at 13:59, Wren Turkal <[email protected]> wrote:
>>
>> On 4/24/24 4:53 AM, Bartosz Golaszewski wrote:
>>> This must be your email client wrapping lines over a certain limit.
>>> Try and get the diff from lore[1], it should be fine.
>>>
>>> Bart
>>>
>>> [1]https://lore.kernel.org/lkml/CAMRc=MepDwUbAKrWgm0CXKObqy8=igtug0QDgo-CgwxjZCAC2Q@mail.gmail.com/
>>
>> I don't think it's my client. The extra newlines are right there in the
>> lore link.
>>
>> Look at the line that starts with "@@". That line is wrapped. The
>> following line ("serdev_device *serdev)") should be at the end of the
>> previous line. The same thing happened on the second "@@" line as well.
>>
>
> Indeed. I just noticed that it applies fine with git apply and figured
> the output must be right. Anyway, this is not a proper patch, I will
> send one once I adapt Zijun's code.
>
> Bart
Weird. Git apply failed for me. That's how I noticed it.
From my terminal:
➜ linux git:(my_master) ✗ git apply ../blah.diff
error: corrupt patch at line 6
FWIW, I also tried pasting it into stdin by running `git apply` as well.
wt
--
You're more amazing than you think!