[+Cc Bjorn, Alan and linux-pci]
On Thu, Dec 17, 2020 at 12:57 AM Takashi Iwai <[email protected]> wrote:
>
> On Wed, 16 Dec 2020 17:22:17 +0100,
> Takashi Iwai wrote:
> >
> > On Wed, 16 Dec 2020 17:07:45 +0100,
> > Kai-Heng Feng wrote:
> > >
> > > On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai <[email protected]> wrote:
> > > >
> > > > On Wed, 16 Dec 2020 16:50:20 +0100,
> > > > Kai-Heng Feng wrote:
> > > > >
> > > > > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai <[email protected]> wrote:
> > > > > >
> > > > > > On Wed, 16 Dec 2020 13:47:24 +0100,
> > > > > > Kai-Heng Feng wrote:
> > > > > > >
> > > > > > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller
> > > > > > > initialization even if no codecs found"), when codec probe fails, it
> > > > > > > doesn't enable runtime suspend, and can prevent graphics card from
> > > > > > > getting powered down:
> > > > > > > [ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized
> > > > > > >
> > > > > > > $ cat /sys/bus/pci/devices/0000:01:00.1/power/runtime_status
> > > > > > > active
> > > > > > >
> > > > > > > So mark there's no codec and continue probing to let runtime PM to work.
> > > > > > >
> > > > > > > BugLink: https://bugs.launchpad.net/bugs/1907212
> > > > > > > Signed-off-by: Kai-Heng Feng <[email protected]>
> > > > > >
> > > > > > Hm, but if the probe fails, doesn't it mean something really wrong?
> > > > > > IOW, how does this situation happen?
> > > > >
> > > > > The HDA controller is forcely created by quirk_nvidia_hda(). So
> > > > > probably there's really not an HDA controller.
> > > >
> > > > I still don't understand how non-zero codec_mask is passed.
> > > > The non-zero codec_mask means that BIOS or whatever believes that
> > > > HD-audio codecs are present and let HD-audio controller reporting the
> > > > presence. What error did you get at probing?
> > >
> > > [ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized
> > > Full dmesg here:
> > > https://launchpadlibrarian.net/510351476/dmesg.log
> >
> > The actual problems are shown before that line.
> >
> > [ 4.178848] pci 0000:01:00.1: can't change power state from D3cold to D0 (config space inaccessible)
> > [ 4.179502] snd_hda_intel 0000:01:00.1: can't change power state from D3cold to D0 (config space inaccessible)
> > [ 4.179511] snd_hda_intel 0000:01:00.1: can't change power state from D3hot to D0 (config space inaccessible)
> > ....
> > [ 4.280571] hdaudio hdaudioC1D0: no AFG or MFG node found
> > [ 4.280633] hdaudio hdaudioC1D1: no AFG or MFG node found
> > [ 4.280685] hdaudio hdaudioC1D2: no AFG or MFG node found
> > [ 4.280736] hdaudio hdaudioC1D3: no AFG or MFG node found
> > [ 4.280788] hdaudio hdaudioC1D4: no AFG or MFG node found
> > [ 4.280839] hdaudio hdaudioC1D5: no AFG or MFG node found
> > [ 4.280892] hdaudio hdaudioC1D6: no AFG or MFG node found
> > [ 4.280943] hdaudio hdaudioC1D7: no AFG or MFG node found
> >
> > Could you check the codec_mask value read in
> > sound/hda/hdac_controller.c? I guess it reads 0xff.
> >
> > If that's the case, it can be corrected by the patch below.
> > But, we should check the cause of the first error (inaccessible config
> > space) in anyway; this must be the primary reason of the whole chain
> > of errors.
>
> Now I took a deeper look at the code. So we hit errors after errors:
> - The first problem is that quirk_nvidia_hda() enabled HD-audio even
> if it's non-functional by some reason. We may need additional
> checks there.
Quite possibly the system doesn't power up HDA controller when there's
no external monitor.
So when it's connected to external monitor, it's still needed for HDMI audio.
Let me ask the user to confirm this.
>
> - The second problem is that pci_enable_device() ignores the error
> returned from pci_set_power_state() if it's -EIO. And the
> inaccessible access error returns -EIO, although it's rather a fatal
> problem. So the driver believes as the PCI device gets enabled
> properly.
This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
regression in pci_enable_device_bars") to fix UHCI controller.
>
> - The third problem is that HD-audio driver blindly believes the
> codec_mask read from the register even if it's a read failure as I
> already showed.
This approach has least regression risk.
Kai-Heng
> Ideally we should address in the first place.
>
>
> Takashi
On Fri, 18 Dec 2020 06:09:38 +0100,
Kai-Heng Feng wrote:
>
> [+Cc Bjorn, Alan and linux-pci]
>
> On Thu, Dec 17, 2020 at 12:57 AM Takashi Iwai <[email protected]> wrote:
> >
> > On Wed, 16 Dec 2020 17:22:17 +0100,
> > Takashi Iwai wrote:
> > >
> > > On Wed, 16 Dec 2020 17:07:45 +0100,
> > > Kai-Heng Feng wrote:
> > > >
> > > > On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai <[email protected]> wrote:
> > > > >
> > > > > On Wed, 16 Dec 2020 16:50:20 +0100,
> > > > > Kai-Heng Feng wrote:
> > > > > >
> > > > > > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai <[email protected]> wrote:
> > > > > > >
> > > > > > > On Wed, 16 Dec 2020 13:47:24 +0100,
> > > > > > > Kai-Heng Feng wrote:
> > > > > > > >
> > > > > > > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller
> > > > > > > > initialization even if no codecs found"), when codec probe fails, it
> > > > > > > > doesn't enable runtime suspend, and can prevent graphics card from
> > > > > > > > getting powered down:
> > > > > > > > [ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized
> > > > > > > >
> > > > > > > > $ cat /sys/bus/pci/devices/0000:01:00.1/power/runtime_status
> > > > > > > > active
> > > > > > > >
> > > > > > > > So mark there's no codec and continue probing to let runtime PM to work.
> > > > > > > >
> > > > > > > > BugLink: https://bugs.launchpad.net/bugs/1907212
> > > > > > > > Signed-off-by: Kai-Heng Feng <[email protected]>
> > > > > > >
> > > > > > > Hm, but if the probe fails, doesn't it mean something really wrong?
> > > > > > > IOW, how does this situation happen?
> > > > > >
> > > > > > The HDA controller is forcely created by quirk_nvidia_hda(). So
> > > > > > probably there's really not an HDA controller.
> > > > >
> > > > > I still don't understand how non-zero codec_mask is passed.
> > > > > The non-zero codec_mask means that BIOS or whatever believes that
> > > > > HD-audio codecs are present and let HD-audio controller reporting the
> > > > > presence. What error did you get at probing?
> > > >
> > > > [ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized
> > > > Full dmesg here:
> > > > https://launchpadlibrarian.net/510351476/dmesg.log
> > >
> > > The actual problems are shown before that line.
> > >
> > > [ 4.178848] pci 0000:01:00.1: can't change power state from D3cold to D0 (config space inaccessible)
> > > [ 4.179502] snd_hda_intel 0000:01:00.1: can't change power state from D3cold to D0 (config space inaccessible)
> > > [ 4.179511] snd_hda_intel 0000:01:00.1: can't change power state from D3hot to D0 (config space inaccessible)
> > > ....
> > > [ 4.280571] hdaudio hdaudioC1D0: no AFG or MFG node found
> > > [ 4.280633] hdaudio hdaudioC1D1: no AFG or MFG node found
> > > [ 4.280685] hdaudio hdaudioC1D2: no AFG or MFG node found
> > > [ 4.280736] hdaudio hdaudioC1D3: no AFG or MFG node found
> > > [ 4.280788] hdaudio hdaudioC1D4: no AFG or MFG node found
> > > [ 4.280839] hdaudio hdaudioC1D5: no AFG or MFG node found
> > > [ 4.280892] hdaudio hdaudioC1D6: no AFG or MFG node found
> > > [ 4.280943] hdaudio hdaudioC1D7: no AFG or MFG node found
> > >
> > > Could you check the codec_mask value read in
> > > sound/hda/hdac_controller.c? I guess it reads 0xff.
> > >
> > > If that's the case, it can be corrected by the patch below.
> > > But, we should check the cause of the first error (inaccessible config
> > > space) in anyway; this must be the primary reason of the whole chain
> > > of errors.
> >
> > Now I took a deeper look at the code. So we hit errors after errors:
> > - The first problem is that quirk_nvidia_hda() enabled HD-audio even
> > if it's non-functional by some reason. We may need additional
> > checks there.
>
> Quite possibly the system doesn't power up HDA controller when there's
> no external monitor.
> So when it's connected to external monitor, it's still needed for HDMI audio.
> Let me ask the user to confirm this.
Yeah, it's the basic question whether the HD-audio is supposed to work
on this machine at all. If yes, the current approach we take makes
less sense - instead we should rather make the HD-audio controller
working.
> > - The second problem is that pci_enable_device() ignores the error
> > returned from pci_set_power_state() if it's -EIO. And the
> > inaccessible access error returns -EIO, although it's rather a fatal
> > problem. So the driver believes as the PCI device gets enabled
> > properly.
>
> This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
> regression in pci_enable_device_bars") to fix UHCI controller.
>
> >
> > - The third problem is that HD-audio driver blindly believes the
> > codec_mask read from the register even if it's a read failure as I
> > already showed.
>
> This approach has least regression risk.
Yes, but it assumes that HD-audio is really non-existent.
thanks,
Takashi
[+Cc nouveau]
On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai <[email protected]> wrote:
[snip]
> > Quite possibly the system doesn't power up HDA controller when there's
> > no external monitor.
> > So when it's connected to external monitor, it's still needed for HDMI audio.
> > Let me ask the user to confirm this.
>
> Yeah, it's the basic question whether the HD-audio is supposed to work
> on this machine at all. If yes, the current approach we take makes
> less sense - instead we should rather make the HD-audio controller
> working.
Yea, confirmed that the Nvidia HDA works when HDMI is connected prior boot.
> > > - The second problem is that pci_enable_device() ignores the error
> > > returned from pci_set_power_state() if it's -EIO. And the
> > > inaccessible access error returns -EIO, although it's rather a fatal
> > > problem. So the driver believes as the PCI device gets enabled
> > > properly.
> >
> > This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
> > regression in pci_enable_device_bars") to fix UHCI controller.
> >
> > >
> > > - The third problem is that HD-audio driver blindly believes the
> > > codec_mask read from the register even if it's a read failure as I
> > > already showed.
> >
> > This approach has least regression risk.
>
> Yes, but it assumes that HD-audio is really non-existent.
I really don't know any good approach to address this.
On Windows, HDA PCI is "hidden" until HDMI cable is plugged, then the
driver will flag the magic bit to make HDA audio appear on the PCI
bus.
IIRC the current approach is to make nouveau and device link work.
Kai-Heng
>
>
> thanks,
>
> Takashi
On Mon, 21 Dec 2020 17:33:20 +0100,
Kai-Heng Feng wrote:
>
> [+Cc nouveau]
>
> On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai <[email protected]> wrote:
> [snip]
> > > Quite possibly the system doesn't power up HDA controller when there's
> > > no external monitor.
> > > So when it's connected to external monitor, it's still needed for HDMI audio.
> > > Let me ask the user to confirm this.
> >
> > Yeah, it's the basic question whether the HD-audio is supposed to work
> > on this machine at all. If yes, the current approach we take makes
> > less sense - instead we should rather make the HD-audio controller
> > working.
>
> Yea, confirmed that the Nvidia HDA works when HDMI is connected prior boot.
>
> > > > - The second problem is that pci_enable_device() ignores the error
> > > > returned from pci_set_power_state() if it's -EIO. And the
> > > > inaccessible access error returns -EIO, although it's rather a fatal
> > > > problem. So the driver believes as the PCI device gets enabled
> > > > properly.
> > >
> > > This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
> > > regression in pci_enable_device_bars") to fix UHCI controller.
> > >
> > > >
> > > > - The third problem is that HD-audio driver blindly believes the
> > > > codec_mask read from the register even if it's a read failure as I
> > > > already showed.
> > >
> > > This approach has least regression risk.
> >
> > Yes, but it assumes that HD-audio is really non-existent.
>
> I really don't know any good approach to address this.
> On Windows, HDA PCI is "hidden" until HDMI cable is plugged, then the
> driver will flag the magic bit to make HDA audio appear on the PCI
> bus.
> IIRC the current approach is to make nouveau and device link work.
But what happens if you plug the HDMI cable later and want to use the
HDMI audio? It won't work with your fix, right?
Takashi
On Tue, Dec 22, 2020 at 12:47 AM Takashi Iwai <[email protected]> wrote:
[snip]
> But what happens if you plug the HDMI cable later and want to use the
> HDMI audio? It won't work with your fix, right?
No it won't.
It's possible to fix from nouveau, but it's at the mercy of Nvidia to
fix their proprietary driver, which many users use.
Kai-Heng
>
>
> Takashi
On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng
<[email protected]> wrote:
>
> [+Cc nouveau]
>
> On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai <[email protected]> wrote:
> [snip]
> > > Quite possibly the system doesn't power up HDA controller when there's
> > > no external monitor.
> > > So when it's connected to external monitor, it's still needed for HDMI audio.
> > > Let me ask the user to confirm this.
> >
> > Yeah, it's the basic question whether the HD-audio is supposed to work
> > on this machine at all. If yes, the current approach we take makes
> > less sense - instead we should rather make the HD-audio controller
> > working.
>
> Yea, confirmed that the Nvidia HDA works when HDMI is connected prior boot.
>
> > > > - The second problem is that pci_enable_device() ignores the error
> > > > returned from pci_set_power_state() if it's -EIO. And the
> > > > inaccessible access error returns -EIO, although it's rather a fatal
> > > > problem. So the driver believes as the PCI device gets enabled
> > > > properly.
> > >
> > > This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
> > > regression in pci_enable_device_bars") to fix UHCI controller.
> > >
> > > >
> > > > - The third problem is that HD-audio driver blindly believes the
> > > > codec_mask read from the register even if it's a read failure as I
> > > > already showed.
> > >
> > > This approach has least regression risk.
> >
> > Yes, but it assumes that HD-audio is really non-existent.
>
> I really don't know any good approach to address this.
> On Windows, HDA PCI is "hidden" until HDMI cable is plugged, then the
> driver will flag the magic bit to make HDA audio appear on the PCI
> bus.
> IIRC the current approach is to make nouveau and device link work.
I don't have the full context of this discussion, but the kernel
force-enables the HDA subfunction nowadays, irrespective of nouveau or
nvidia or whatever:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/quirks.c?h=v5.10#n5267
Cheers,
-ilia
On Tue, Dec 22, 2020 at 1:56 AM Ilia Mirkin <[email protected]> wrote:
>
> On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng
> <[email protected]> wrote:
> >
> > [+Cc nouveau]
> >
> > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai <[email protected]> wrote:
> > [snip]
> > > > Quite possibly the system doesn't power up HDA controller when there's
> > > > no external monitor.
> > > > So when it's connected to external monitor, it's still needed for HDMI audio.
> > > > Let me ask the user to confirm this.
> > >
> > > Yeah, it's the basic question whether the HD-audio is supposed to work
> > > on this machine at all. If yes, the current approach we take makes
> > > less sense - instead we should rather make the HD-audio controller
> > > working.
> >
> > Yea, confirmed that the Nvidia HDA works when HDMI is connected prior boot.
> >
> > > > > - The second problem is that pci_enable_device() ignores the error
> > > > > returned from pci_set_power_state() if it's -EIO. And the
> > > > > inaccessible access error returns -EIO, although it's rather a fatal
> > > > > problem. So the driver believes as the PCI device gets enabled
> > > > > properly.
> > > >
> > > > This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
> > > > regression in pci_enable_device_bars") to fix UHCI controller.
> > > >
> > > > >
> > > > > - The third problem is that HD-audio driver blindly believes the
> > > > > codec_mask read from the register even if it's a read failure as I
> > > > > already showed.
> > > >
> > > > This approach has least regression risk.
> > >
> > > Yes, but it assumes that HD-audio is really non-existent.
> >
> > I really don't know any good approach to address this.
> > On Windows, HDA PCI is "hidden" until HDMI cable is plugged, then the
> > driver will flag the magic bit to make HDA audio appear on the PCI
> > bus.
> > IIRC the current approach is to make nouveau and device link work.
>
> I don't have the full context of this discussion, but the kernel
> force-enables the HDA subfunction nowadays, irrespective of nouveau or
> nvidia or whatever:
That's the problem.
The nvidia HDA controller on the affected system only gets its power
after HDMI cable plugged, so the probe on boot fails.
Kai-Heng
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/quirks.c?h=v5.10#n5267
>
> Cheers,
>
> -ilia
On Tue, Dec 22, 2020 at 3:50 AM Kai-Heng Feng
<[email protected]> wrote:
>
> On Tue, Dec 22, 2020 at 1:56 AM Ilia Mirkin <[email protected]> wrote:
> >
> > On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng
> > <[email protected]> wrote:
> > >
> > > [+Cc nouveau]
> > >
> > > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai <[email protected]> wrote:
> > > [snip]
> > > > > Quite possibly the system doesn't power up HDA controller when there's
> > > > > no external monitor.
> > > > > So when it's connected to external monitor, it's still needed for HDMI audio.
> > > > > Let me ask the user to confirm this.
> > > >
> > > > Yeah, it's the basic question whether the HD-audio is supposed to work
> > > > on this machine at all. If yes, the current approach we take makes
> > > > less sense - instead we should rather make the HD-audio controller
> > > > working.
> > >
> > > Yea, confirmed that the Nvidia HDA works when HDMI is connected prior boot.
> > >
> > > > > > - The second problem is that pci_enable_device() ignores the error
> > > > > > returned from pci_set_power_state() if it's -EIO. And the
> > > > > > inaccessible access error returns -EIO, although it's rather a fatal
> > > > > > problem. So the driver believes as the PCI device gets enabled
> > > > > > properly.
> > > > >
> > > > > This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
> > > > > regression in pci_enable_device_bars") to fix UHCI controller.
> > > > >
> > > > > >
> > > > > > - The third problem is that HD-audio driver blindly believes the
> > > > > > codec_mask read from the register even if it's a read failure as I
> > > > > > already showed.
> > > > >
> > > > > This approach has least regression risk.
> > > >
> > > > Yes, but it assumes that HD-audio is really non-existent.
> > >
> > > I really don't know any good approach to address this.
> > > On Windows, HDA PCI is "hidden" until HDMI cable is plugged, then the
> > > driver will flag the magic bit to make HDA audio appear on the PCI
> > > bus.
> > > IIRC the current approach is to make nouveau and device link work.
> >
> > I don't have the full context of this discussion, but the kernel
> > force-enables the HDA subfunction nowadays, irrespective of nouveau or
> > nvidia or whatever:
>
> That's the problem.
>
> The nvidia HDA controller on the affected system only gets its power
> after HDMI cable plugged, so the probe on boot fails.
>
it might be that the code to enable the sub function is a bit broken
:/ but it should work. Maybe the quirk_nvidia_hda function needs to be
called on more occasions? No idea.
> Kai-Heng
>
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/quirks.c?h=v5.10#n5267
> >
> > Cheers,
> >
> > -ilia
> _______________________________________________
> Nouveau mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/nouveau
>
Reviving this thread as we have another user (rightfully) complaining on
IRC about this.
The way I see it there's two issues:
1) snd_hda_intel not allowing runpm (or w/e vgaswitcheroo needs) when
there's missing codecs, inhibiting the entire GPU from performing runpm.
This needlessly wastes lots of battery power.
2) HDMI audio not working on such machines unless it was plugged in at
boot-time.
The original workarounds proposed by Kai-Heng seem to fix 1), which is
progress. I don't see a reason why that should be held off even if it
doesn't fix 2).
To fix 2), more work is needed. On a high level, I suspect nouveau
should start controlling the enabling/disabling of the HDA controller
based on connector events and/or connector state at module load.
Currently the PCI quirk seems to enable it wholesale, and I don't know
why. If no GPU driver is loaded, it's pointless to turn the HDA device
on. The blob presumably doesn't need this either, as it can control the
device just as well as nouveau. If it doesn't, NVIDIA should fix it
rather than rely on this quirk. The only reason I can think of is that
snd_hda_intel or vgaswitcheroo isn't prepared for hot(un)plugging (or
alternatively reprobing) devices. Without that, we presumably won't
solve issue 2). Can I ask someone with more technical knowledge of
snd_hda_intel and vgaswitcheroo to brainstorm about the possible
challenges of nouveau taking matters into its own hand rather than
keeping this PCI quirk around?
Roy
Op 04-01-2021 om 13:20 schreef Karol Herbst:
> On Tue, Dec 22, 2020 at 3:50 AM Kai-Heng Feng
> <[email protected]> wrote:
>>
>> On Tue, Dec 22, 2020 at 1:56 AM Ilia Mirkin <[email protected]> wrote:
>>>
>>> On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng
>>> <[email protected]> wrote:
>>>>
>>>> [+Cc nouveau]
>>>>
>>>> On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai <[email protected]> wrote:
>>>> [snip]
>>>>>> Quite possibly the system doesn't power up HDA controller when there's
>>>>>> no external monitor.
>>>>>> So when it's connected to external monitor, it's still needed for HDMI audio.
>>>>>> Let me ask the user to confirm this.
>>>>>
>>>>> Yeah, it's the basic question whether the HD-audio is supposed to work
>>>>> on this machine at all. If yes, the current approach we take makes
>>>>> less sense - instead we should rather make the HD-audio controller
>>>>> working.
>>>>
>>>> Yea, confirmed that the Nvidia HDA works when HDMI is connected prior boot.
>>>>
>>>>>>> - The second problem is that pci_enable_device() ignores the error
>>>>>>> returned from pci_set_power_state() if it's -EIO. And the
>>>>>>> inaccessible access error returns -EIO, although it's rather a fatal
>>>>>>> problem. So the driver believes as the PCI device gets enabled
>>>>>>> properly.
>>>>>>
>>>>>> This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
>>>>>> regression in pci_enable_device_bars") to fix UHCI controller.
>>>>>>
>>>>>>>
>>>>>>> - The third problem is that HD-audio driver blindly believes the
>>>>>>> codec_mask read from the register even if it's a read failure as I
>>>>>>> already showed.
>>>>>>
>>>>>> This approach has least regression risk.
>>>>>
>>>>> Yes, but it assumes that HD-audio is really non-existent.
>>>>
>>>> I really don't know any good approach to address this.
>>>> On Windows, HDA PCI is "hidden" until HDMI cable is plugged, then the
>>>> driver will flag the magic bit to make HDA audio appear on the PCI
>>>> bus.
>>>> IIRC the current approach is to make nouveau and device link work.
>>>
>>> I don't have the full context of this discussion, but the kernel
>>> force-enables the HDA subfunction nowadays, irrespective of nouveau or
>>> nvidia or whatever:
>>
>> That's the problem.
>>
>> The nvidia HDA controller on the affected system only gets its power
>> after HDMI cable plugged, so the probe on boot fails.
>>
>
> it might be that the code to enable the sub function is a bit broken
> :/ but it should work. Maybe the quirk_nvidia_hda function needs to be
> called on more occasions? No idea.
>
>> Kai-Heng
>>
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/quirks.c?h=v5.10#n5267
>>>
>>> Cheers,
>>>
>>> -ilia
>> _______________________________________________
>> Nouveau mailing list
>> [email protected]
>> https://lists.freedesktop.org/mailman/listinfo/nouveau
>>
>
> _______________________________________________
> Nouveau mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/nouveau
>
On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote:
> Can I ask someone with more
> technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm about
> the possible challenges of nouveau taking matters into its own hand rather
> than keeping this PCI quirk around?
It sounds to me like the HDA is not powered if no cable is plugged in.
What is reponsible then for powering it up or down, firmware code on
the GPU or in the host's BIOS?
Ideally, we should try to find out how to control HDA power from the
operating system rather than trying to cooperate with whatever firmware
is doing. If we have that capability, the OS should power the HDA up
and down as it sees fit.
Thanks,
Lukas
Op 10-04-2021 om 20:23 schreef Lukas Wunner:
> On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote:
>> Can I ask someone with more
>> technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm about
>> the possible challenges of nouveau taking matters into its own hand rather
>> than keeping this PCI quirk around?
>
> It sounds to me like the HDA is not powered if no cable is plugged in.
> What is reponsible then for powering it up or down, firmware code on
> the GPU or in the host's BIOS?
Sometimes the BIOS, but definitely unconditionally the PCI quirk code:
https://github.com/torvalds/linux/blob/master/drivers/pci/quirks.c#L5289
(CC Aaron Plattner)
>
> Ideally, we should try to find out how to control HDA power from the
> operating system rather than trying to cooperate with whatever firmware
> is doing. If we have that capability, the OS should power the HDA up
> and down as it sees fit.
>
> Thanks,
>
> Lukas
>
On 4/10/21 1:48 PM, Roy Spliet wrote:
> Op 10-04-2021 om 20:23 schreef Lukas Wunner:
>> On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote:
>>> Can I ask someone with more
>>> technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm
>>> about
>>> the possible challenges of nouveau taking matters into its own hand
>>> rather
>>> than keeping this PCI quirk around?
>>
>> It sounds to me like the HDA is not powered if no cable is plugged in.
>> What is reponsible then for powering it up or down, firmware code on
>> the GPU or in the host's BIOS?
>
> Sometimes the BIOS, but definitely unconditionally the PCI quirk code:
> https://github.com/torvalds/linux/blob/master/drivers/pci/quirks.c#L5289
>
> (CC Aaron Plattner)
My basic understanding is that the audio function stops responding
whenever the graphics function is powered off. So the requirement here
is that the audio driver can't try to talk to the audio function while
the graphics function is asleep, and must trigger a graphics function
wakeup before trying to communicate with the audio function. I think
there are also requirements about the audio function needing to be awake
when the graphics driver is updating the ELD, but I'm not sure.
This is harder on Windows because the audio driver lives in its own
little world doing its own thing but on Linux we can do better.
>> Ideally, we should try to find out how to control HDA power from the
>> operating system rather than trying to cooperate with whatever firmware
>> is doing. If we have that capability, the OS should power the HDA up
>> and down as it sees fit.
After system boot, I don't think there's any firmware involved, but I'm
not super familiar with the low-level details and it's possible the
situation changed since I last looked at it.
I think the problem with having nouveau write this quirk is that the
kernel will need to re-probe the PCI device to notice that it has
suddenly become a multi-function device with an audio function, and
hotplug the audio driver. I originally looked into trying to do that but
it was tricky because the PCI subsystem didn't really have a mechanism
for a single-function device to become a multi-function device on the
fly and it seemed easier to enable it early on during bus enumeration.
That way the kernel sees both functions all the time without anything
else having to be special about this configuration.
-- Aaron
>> Thanks,
>>
>> Lukas
Hello Aaron,
Thanks for your insights. A follow-up query and some observations in-line.
Op 12-04-2021 om 20:06 schreef Aaron Plattner:
> On 4/10/21 1:48 PM, Roy Spliet wrote:
>> Op 10-04-2021 om 20:23 schreef Lukas Wunner:
>>> On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote:
>>>> Can I ask someone with more
>>>> technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm
>>>> about
>>>> the possible challenges of nouveau taking matters into its own hand
>>>> rather
>>>> than keeping this PCI quirk around?
>>>
>>> It sounds to me like the HDA is not powered if no cable is plugged in.
>>> What is reponsible then for powering it up or down, firmware code on
>>> the GPU or in the host's BIOS?
>>
>> Sometimes the BIOS, but definitely unconditionally the PCI quirk code:
>> https://github.com/torvalds/linux/blob/master/drivers/pci/quirks.c#L5289
>>
>> (CC Aaron Plattner)
>
> My basic understanding is that the audio function stops responding
> whenever the graphics function is powered off. So the requirement here
> is that the audio driver can't try to talk to the audio function while
> the graphics function is asleep, and must trigger a graphics function
> wakeup before trying to communicate with the audio function.
I believe that vgaswitcheroo takes care of this for us.
> I think
> there are also requirements about the audio function needing to be awake
> when the graphics driver is updating the ELD, but I'm not sure.
>
> This is harder on Windows because the audio driver lives in its own
> little world doing its own thing but on Linux we can do better.
>
>>> Ideally, we should try to find out how to control HDA power from the
>>> operating system rather than trying to cooperate with whatever firmware
>>> is doing. If we have that capability, the OS should power the HDA up
>>> and down as it sees fit.
>
> After system boot, I don't think there's any firmware involved, but I'm
> not super familiar with the low-level details and it's possible the
> situation changed since I last looked at it.
>
> I think the problem with having nouveau write this quirk is that the
> kernel will need to re-probe the PCI device to notice that it has
> suddenly become a multi-function device with an audio function, and
> hotplug the audio driver. I originally looked into trying to do that but
> it was tricky because the PCI subsystem didn't really have a mechanism
> for a single-function device to become a multi-function device on the
> fly and it seemed easier to enable it early on during bus enumeration.
> That way the kernel sees both functions all the time without anything
> else having to be special about this configuration.
Right, so for a little more context: a while ago I noticed that my
laptop (lucky me, Asus K501UB) has a 940M with HDA but no codec. Seems
legit, given how this GPU has no displays attached; they're all hooked
up to the Intel integrated GPU. That threw off the snd_hda_intel
mid-probe, and as a result didn't permit runpm, keeping the entire GPU,
PCIe bus and thus the CPU package awake. A bit of hackerly later we
decided to continue probing without a codec, and now my laptop is happy,
but...
A new problem popped up with several other NVIDIA GPUs that expose their
HDA subdevice, but somehow its inaccessible. Relevant lines from a
users' log:
[ 3.031222] MXM: GUID detected in BIOS
[ 3.031280] ACPI BIOS Error (bug): AE_AML_PACKAGE_LIMIT, Index
(0x000000003) is beyond end of object (length 0x0) (20200925/exoparg2-393)
[ 3.031352] ACPI Error: Aborting method \_SB.PCI0.GFX0._DSM due to
previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
[ 3.031419] ACPI: \_SB_.PCI0.GFX0: failed to evaluate _DSM (0x300b)
[ 3.031424] ACPI Warning: \_SB.PCI0.GFX0._DSM: Argument #4 type
mismatch - Found [Buffer], ACPI requires [Package] (20200925/nsarguments-61)
[ 3.031619] pci 0000:00:02.0: optimus capabilities: enabled, status
dynamic power,
[ 3.031667] ACPI BIOS Error (bug): AE_AML_PACKAGE_LIMIT, Index
(0x000000003) is beyond end of object (length 0x0) (20200925/exoparg2-393)
[ 3.031731] ACPI Error: Aborting method \_SB.PCI0.GFX0._DSM due to
previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
[ 3.031791] ACPI Error: Aborting method \_SB.PCI0.PEG0.PEGP._DSM due
to previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
[ 3.031856] ACPI: \_SB_.PCI0.PEG0.PEGP: failed to evaluate _DSM (0x300b)
[ 3.031859] ACPI Warning: \_SB.PCI0.PEG0.PEGP._DSM: Argument #4 type
mismatch - Found [Buffer], ACPI requires [Package] (20200925/nsarguments-61)
[ 3.032058] pci 0000:01:00.0: optimus capabilities: enabled, status
dynamic power,
[ 3.032061] VGA switcheroo: detected Optimus DSM method
\_SB_.PCI0.PEG0.PEGP handle
[ 3.032323] checking generic (d0000000 410000) vs hw (f6000000 1000000)
[ 3.032325] checking generic (d0000000 410000) vs hw (e0000000 10000000)
[ 3.032326] checking generic (d0000000 410000) vs hw (f0000000 2000000)
[ 3.032410] nouveau 0000:01:00.0: NVIDIA GK107 (0e71f0a2)
[ 3.042385] nouveau 0000:01:00.0: bios: version 80.07.a0.00.11
--- snip ---
[ 8.951478] snd_hda_intel 0000:01:00.1: can't change power state from
D3cold to D0 (config space inaccessible)
[ 8.951509] snd_hda_intel 0000:01:00.1: can't change power state from
D3hot to D0 (config space inaccessible)
[ 8.951608] snd_hda_intel 0000:01:00.1: Disabling MSI
[ 8.951621] snd_hda_intel 0000:01:00.1: Handle vga_switcheroo audio
client
[ 8.952461] snd_hda_intel 0000:00:1b.0: bound 0000:00:02.0 (ops
i915_audio_component_bind_ops [i915])
[ 8.952642] snd_hda_intel 0000:01:00.1: number of I/O streams is 30,
forcing separate stream tags
Now I don't know what's going on, but the snd_hda_intel messages are
ominous. And so are the ACPI warnings. But I don't know how much these
two are related.
You say that it is desirable to switch on HDA at boot-time because the
PCI subsystem doesn't play nicely with changing a device to
multi-function. That rules out the option of only enabling the HDA
device once a cable is plugged in. Are there any other trap doors that
snd_hda_intel needs to navigate around to make this work fault free on
all hardware, such as:
- Codecs not revealing themselves until a display is plugged in,
requiring perhaps a "codec reprobe" and "codec remove" event from
nouveau/rm to snd_hda_intel,
- Borked BIOSes just blindly assigning the MMIO space of the HDA device
to another device, or nothing at all,
- ... other things that might give any of us nightmares and heart burn?
Thanks!
Roy
>
> -- Aaron
>
>>> Thanks,
>>>
>>> Lukas
On 4/12/21 12:36 PM, Roy Spliet wrote:
> Hello Aaron,
>
> Thanks for your insights. A follow-up query and some observations
> in-line.
>
> Op 12-04-2021 om 20:06 schreef Aaron Plattner:
>> On 4/10/21 1:48 PM, Roy Spliet wrote:
>>> Op 10-04-2021 om 20:23 schreef Lukas Wunner:
>>>> On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote:
>>>>> Can I ask someone with more
>>>>> technical knowledge of snd_hda_intel and vgaswitcheroo to
>>>>> brainstorm about
>>>>> the possible challenges of nouveau taking matters into its own
>>>>> hand rather
>>>>> than keeping this PCI quirk around?
>>>>
>>>> It sounds to me like the HDA is not powered if no cable is plugged in.
>>>> What is reponsible then for powering it up or down, firmware code on
>>>> the GPU or in the host's BIOS?
>>>
>>> Sometimes the BIOS, but definitely unconditionally the PCI quirk
>>> code:
>>> https://github.com/torvalds/linux/blob/master/drivers/pci/quirks.c#L5289
>>>
>>>
>>> (CC Aaron Plattner)
>>
>> My basic understanding is that the audio function stops responding
>> whenever the graphics function is powered off. So the requirement
>> here is that the audio driver can't try to talk to the audio function
>> while the graphics function is asleep, and must trigger a graphics
>> function wakeup before trying to communicate with the audio function.
>
> I believe that vgaswitcheroo takes care of this for us.
>
>> I think there are also requirements about the audio function needing
>> to be awake when the graphics driver is updating the ELD, but I'm not
>> sure.
>>
>> This is harder on Windows because the audio driver lives in its own
>> little world doing its own thing but on Linux we can do better.
>>
>>>> Ideally, we should try to find out how to control HDA power from the
>>>> operating system rather than trying to cooperate with whatever
>>>> firmware
>>>> is doing. If we have that capability, the OS should power the HDA up
>>>> and down as it sees fit.
>>
>> After system boot, I don't think there's any firmware involved, but
>> I'm not super familiar with the low-level details and it's possible
>> the situation changed since I last looked at it.
>>
>> I think the problem with having nouveau write this quirk is that the
>> kernel will need to re-probe the PCI device to notice that it has
>> suddenly become a multi-function device with an audio function, and
>> hotplug the audio driver. I originally looked into trying to do that
>> but it was tricky because the PCI subsystem didn't really have a
>> mechanism for a single-function device to become a multi-function
>> device on the fly and it seemed easier to enable it early on during
>> bus enumeration. That way the kernel sees both functions all the time
>> without anything else having to be special about this configuration.
>
> Right, so for a little more context: a while ago I noticed that my
> laptop (lucky me, Asus K501UB) has a 940M with HDA but no codec. Seems
> legit, given how this GPU has no displays attached; they're all hooked
> up to the Intel integrated GPU. That threw off the snd_hda_intel
> mid-probe, and as a result didn't permit runpm, keeping the entire
> GPU, PCIe bus and thus the CPU package awake. A bit of hackerly later
> we decided to continue probing without a codec, and now my laptop is
> happy, but...
What is the PCI class of the GPU in your system? If it has no display
outputs it's probably 0x302 ("3D Controller") rather than 0x300 ("VGA
Controller"). Looking at the code it looks like this workaround is being
applied to both but maybe it should be restricted to just VGA controllers.
-- Aaron
> A new problem popped up with several other NVIDIA GPUs that expose
> their HDA subdevice, but somehow its inaccessible. Relevant lines from
> a users' log:
>
> [ 3.031222] MXM: GUID detected in BIOS
> [ 3.031280] ACPI BIOS Error (bug): AE_AML_PACKAGE_LIMIT, Index
> (0x000000003) is beyond end of object (length 0x0)
> (20200925/exoparg2-393)
> [ 3.031352] ACPI Error: Aborting method \_SB.PCI0.GFX0._DSM due to
> previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
> [ 3.031419] ACPI: \_SB_.PCI0.GFX0: failed to evaluate _DSM (0x300b)
> [ 3.031424] ACPI Warning: \_SB.PCI0.GFX0._DSM: Argument #4 type
> mismatch - Found [Buffer], ACPI requires [Package]
> (20200925/nsarguments-61)
> [ 3.031619] pci 0000:00:02.0: optimus capabilities: enabled, status
> dynamic power,
> [ 3.031667] ACPI BIOS Error (bug): AE_AML_PACKAGE_LIMIT, Index
> (0x000000003) is beyond end of object (length 0x0)
> (20200925/exoparg2-393)
> [ 3.031731] ACPI Error: Aborting method \_SB.PCI0.GFX0._DSM due to
> previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
> [ 3.031791] ACPI Error: Aborting method \_SB.PCI0.PEG0.PEGP._DSM
> due to previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
> [ 3.031856] ACPI: \_SB_.PCI0.PEG0.PEGP: failed to evaluate _DSM
> (0x300b)
> [ 3.031859] ACPI Warning: \_SB.PCI0.PEG0.PEGP._DSM: Argument #4
> type mismatch - Found [Buffer], ACPI requires [Package]
> (20200925/nsarguments-61)
> [ 3.032058] pci 0000:01:00.0: optimus capabilities: enabled, status
> dynamic power,
> [ 3.032061] VGA switcheroo: detected Optimus DSM method
> \_SB_.PCI0.PEG0.PEGP handle
> [ 3.032323] checking generic (d0000000 410000) vs hw (f6000000
> 1000000)
> [ 3.032325] checking generic (d0000000 410000) vs hw (e0000000
> 10000000)
> [ 3.032326] checking generic (d0000000 410000) vs hw (f0000000
> 2000000)
> [ 3.032410] nouveau 0000:01:00.0: NVIDIA GK107 (0e71f0a2)
> [ 3.042385] nouveau 0000:01:00.0: bios: version 80.07.a0.00.11
> --- snip ---
> [ 8.951478] snd_hda_intel 0000:01:00.1: can't change power state
> from D3cold to D0 (config space inaccessible)
> [ 8.951509] snd_hda_intel 0000:01:00.1: can't change power state
> from D3hot to D0 (config space inaccessible)
> [ 8.951608] snd_hda_intel 0000:01:00.1: Disabling MSI
> [ 8.951621] snd_hda_intel 0000:01:00.1: Handle vga_switcheroo audio
> client
> [ 8.952461] snd_hda_intel 0000:00:1b.0: bound 0000:00:02.0 (ops
> i915_audio_component_bind_ops [i915])
> [ 8.952642] snd_hda_intel 0000:01:00.1: number of I/O streams is
> 30, forcing separate stream tags
>
> Now I don't know what's going on, but the snd_hda_intel messages are
> ominous. And so are the ACPI warnings. But I don't know how much these
> two are related.
>
> You say that it is desirable to switch on HDA at boot-time because the
> PCI subsystem doesn't play nicely with changing a device to
> multi-function. That rules out the option of only enabling the HDA
> device once a cable is plugged in. Are there any other trap doors that
> snd_hda_intel needs to navigate around to make this work fault free on
> all hardware, such as:
> - Codecs not revealing themselves until a display is plugged in,
> requiring perhaps a "codec reprobe" and "codec remove" event from
> nouveau/rm to snd_hda_intel,
> - Borked BIOSes just blindly assigning the MMIO space of the HDA
> device to another device, or nothing at all,
> - ... other things that might give any of us nightmares and heart burn?
>
> Thanks!
>
> Roy
>
>>
>> -- Aaron
>>
>>>> Thanks,
>>>>
>>>> Lukas
>
On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet <[email protected]> wrote:
>
> Hello Aaron,
>
> Thanks for your insights. A follow-up query and some observations in-line.
>
> Op 12-04-2021 om 20:06 schreef Aaron Plattner:
> > On 4/10/21 1:48 PM, Roy Spliet wrote:
> >> Op 10-04-2021 om 20:23 schreef Lukas Wunner:
> >>> On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote:
> >>>> Can I ask someone with more
> >>>> technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm
> >>>> about
> >>>> the possible challenges of nouveau taking matters into its own hand
> >>>> rather
> >>>> than keeping this PCI quirk around?
> >>>
> >>> It sounds to me like the HDA is not powered if no cable is plugged in.
> >>> What is reponsible then for powering it up or down, firmware code on
> >>> the GPU or in the host's BIOS?
> >>
> >> Sometimes the BIOS, but definitely unconditionally the PCI quirk code:
> >> https://github.com/torvalds/linux/blob/master/drivers/pci/quirks.c#L5289
> >>
> >> (CC Aaron Plattner)
> >
> > My basic understanding is that the audio function stops responding
> > whenever the graphics function is powered off. So the requirement here
> > is that the audio driver can't try to talk to the audio function while
> > the graphics function is asleep, and must trigger a graphics function
> > wakeup before trying to communicate with the audio function.
>
> I believe that vgaswitcheroo takes care of this for us.
>
yeah, and also: why would the driver want to do stuff? If the GPU is
turned off, there is no point in communicating with the audio device
anyway. The driver should do the initial probe and leave the device be
unless it's actively used. Also there is no such thing as "use the
audio function, but not the graphics one"
> > I think
> > there are also requirements about the audio function needing to be awake
> > when the graphics driver is updating the ELD, but I'm not sure.
> >
well, it's one physical device anyway, so technically the audio
function is powered on.
> > This is harder on Windows because the audio driver lives in its own
> > little world doing its own thing but on Linux we can do better.
> >
> >>> Ideally, we should try to find out how to control HDA power from the
> >>> operating system rather than trying to cooperate with whatever firmware
> >>> is doing. If we have that capability, the OS should power the HDA up
> >>> and down as it sees fit.
> >
> > After system boot, I don't think there's any firmware involved, but I'm
> > not super familiar with the low-level details and it's possible the
> > situation changed since I last looked at it.
> >
> > I think the problem with having nouveau write this quirk is that the
> > kernel will need to re-probe the PCI device to notice that it has
> > suddenly become a multi-function device with an audio function, and
> > hotplug the audio driver. I originally looked into trying to do that but
> > it was tricky because the PCI subsystem didn't really have a mechanism
> > for a single-function device to become a multi-function device on the
> > fly and it seemed easier to enable it early on during bus enumeration.
> > That way the kernel sees both functions all the time without anything
> > else having to be special about this configuration.
Well, we do have this pci/quirk.c thing, no? Nouveau does flip the
bit, but I am actually not sure if that's even doing something
anymore. Maybe in the runtime_resume case it's still relevant but not
sure _when_ DECLARE_PCI_FIXUP_CLASS_RESUME_EARLY is triggered, it does
seem to be called even in the runtime_resume case though.
>
> Right, so for a little more context: a while ago I noticed that my
> laptop (lucky me, Asus K501UB) has a 940M with HDA but no codec. Seems
> legit, given how this GPU has no displays attached; they're all hooked
> up to the Intel integrated GPU. That threw off the snd_hda_intel
> mid-probe, and as a result didn't permit runpm, keeping the entire GPU,
> PCIe bus and thus the CPU package awake. A bit of hackerly later we
> decided to continue probing without a codec, and now my laptop is happy,
> but...
> A new problem popped up with several other NVIDIA GPUs that expose their
> HDA subdevice, but somehow its inaccessible. Relevant lines from a
> users' log:
>
> [ 3.031222] MXM: GUID detected in BIOS
> [ 3.031280] ACPI BIOS Error (bug): AE_AML_PACKAGE_LIMIT, Index
> (0x000000003) is beyond end of object (length 0x0) (20200925/exoparg2-393)
> [ 3.031352] ACPI Error: Aborting method \_SB.PCI0.GFX0._DSM due to
> previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
> [ 3.031419] ACPI: \_SB_.PCI0.GFX0: failed to evaluate _DSM (0x300b)
> [ 3.031424] ACPI Warning: \_SB.PCI0.GFX0._DSM: Argument #4 type
> mismatch - Found [Buffer], ACPI requires [Package] (20200925/nsarguments-61)
> [ 3.031619] pci 0000:00:02.0: optimus capabilities: enabled, status
> dynamic power,
> [ 3.031667] ACPI BIOS Error (bug): AE_AML_PACKAGE_LIMIT, Index
> (0x000000003) is beyond end of object (length 0x0) (20200925/exoparg2-393)
> [ 3.031731] ACPI Error: Aborting method \_SB.PCI0.GFX0._DSM due to
> previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
> [ 3.031791] ACPI Error: Aborting method \_SB.PCI0.PEG0.PEGP._DSM due
> to previous error (AE_AML_PACKAGE_LIMIT) (20200925/psparse-529)
> [ 3.031856] ACPI: \_SB_.PCI0.PEG0.PEGP: failed to evaluate _DSM (0x300b)
> [ 3.031859] ACPI Warning: \_SB.PCI0.PEG0.PEGP._DSM: Argument #4 type
> mismatch - Found [Buffer], ACPI requires [Package] (20200925/nsarguments-61)
If I am not wrong we are calling the _DSM method inside nouveau when
doing runpm on pre _PR3 systems. As this is all very vendor specific,
we might be doing something incorrectly.
> [ 3.032058] pci 0000:01:00.0: optimus capabilities: enabled, status
> dynamic power,
> [ 3.032061] VGA switcheroo: detected Optimus DSM method
> \_SB_.PCI0.PEG0.PEGP handle
> [ 3.032323] checking generic (d0000000 410000) vs hw (f6000000 1000000)
> [ 3.032325] checking generic (d0000000 410000) vs hw (e0000000 10000000)
> [ 3.032326] checking generic (d0000000 410000) vs hw (f0000000 2000000)
> [ 3.032410] nouveau 0000:01:00.0: NVIDIA GK107 (0e71f0a2)
> [ 3.042385] nouveau 0000:01:00.0: bios: version 80.07.a0.00.11
> --- snip ---
> [ 8.951478] snd_hda_intel 0000:01:00.1: can't change power state from
> D3cold to D0 (config space inaccessible)
> [ 8.951509] snd_hda_intel 0000:01:00.1: can't change power state from
> D3hot to D0 (config space inaccessible)
This is actually a little bad, because it means that the device
doesn't come back up from D3. It's a bit weird it's D3cold and D3hot
in the messages, but maybe the device just takes quite some time to
wake up. But it does look like the device gets woken up.
> [ 8.951608] snd_hda_intel 0000:01:00.1: Disabling MSI
> [ 8.951621] snd_hda_intel 0000:01:00.1: Handle vga_switcheroo audio
> client
> [ 8.952461] snd_hda_intel 0000:00:1b.0: bound 0000:00:02.0 (ops
> i915_audio_component_bind_ops [i915])
> [ 8.952642] snd_hda_intel 0000:01:00.1: number of I/O streams is 30,
> forcing separate stream tags
>
> Now I don't know what's going on, but the snd_hda_intel messages are
> ominous. And so are the ACPI warnings. But I don't know how much these
> two are related.
>
What is the actual problem though? Seems like everything is fine
despite those messages.
> You say that it is desirable to switch on HDA at boot-time because the
> PCI subsystem doesn't play nicely with changing a device to
> multi-function. That rules out the option of only enabling the HDA
> device once a cable is plugged in. Are there any other trap doors that
yeah, we can absolutely not do that. We do quirk the device to put the
GPU into multi function state asap and the intel_hda_snd driver should
deal with it.
> snd_hda_intel needs to navigate around to make this work fault free on
> all hardware, such as:
> - Codecs not revealing themselves until a display is plugged in,
> requiring perhaps a "codec reprobe" and "codec remove" event from
> nouveau/rm to snd_hda_intel,
we could trigger the reprobe from within nouveau as we are dealing
with display hotplug events anyway.
> - Borked BIOSes just blindly assigning the MMIO space of the HDA device
> to another device, or nothing at all,
that exists? *sigh*
> - ... other things that might give any of us nightmares and heart burn?
>
hopefully there are none :p
> Thanks!
>
> Roy
>
> >
> > -- Aaron
> >
> >>> Thanks,
> >>>
> >>> Lukas
>