2021-08-21 02:18:24

by CGEL

Subject: [PATCH linux-next] drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.

From: Luo penghao <[email protected]>

In order to keep the code style consistency of the whole file,
the 'inst' assignments should be deleted.

The clang_analyzer complains as follows:

drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c:499:8: warning:
Although the value storedto 'inst' is used in the enclosing expression,
the value is never actually read from 'inst'.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Luo penghao <[email protected]>
---
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
index f02abd9..5d7766a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
@@ -502,7 +502,7 @@ gp100_vmm_fault_cancel(struct nvkm_vmm *vmm, void *argv, u32 argc)
args->v0.inst |= 0x80000000;

if (!WARN_ON(nvkm_gr_ctxsw_pause(device))) {
- if ((inst = nvkm_gr_ctxsw_inst(device)) == args->v0.inst) {
+ if ((nvkm_gr_ctxsw_inst(device)) == args->v0.inst) {
gf100_vmm_invalidate(vmm, 0x0000001b
/* CANCEL_TARGETED. */ |
(args->v0.hub << 20) |
--
2.15.2

2021-09-28 11:19:45

by Karol Herbst

Subject: Re: [PATCH linux-next] drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.

Reviewed-by: Karol Herbst <[email protected]>

but I will remove the unnecessary brackets as well

On Sat, Aug 21, 2021 at 10:46 AM CGEL <[email protected]> wrote:
>
> From: Luo penghao <[email protected]>
>
> In order to keep the code style consistency of the whole file,
> the 'inst' assignments should be deleted.
>
> The clang_analyzer complains as follows:
>
> drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c:499:8: warning:
> Although the value storedto 'inst' is used in the enclosing expression,
> the value is never actually read from 'inst'.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Luo penghao <[email protected]>
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> index f02abd9..5d7766a 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> @@ -502,7 +502,7 @@ gp100_vmm_fault_cancel(struct nvkm_vmm *vmm, void *argv, u32 argc)
> args->v0.inst |= 0x80000000;
>
> if (!WARN_ON(nvkm_gr_ctxsw_pause(device))) {
> - if ((inst = nvkm_gr_ctxsw_inst(device)) == args->v0.inst) {
> + if ((nvkm_gr_ctxsw_inst(device)) == args->v0.inst) {
> gf100_vmm_invalidate(vmm, 0x0000001b
> /* CANCEL_TARGETED. */ |
> (args->v0.hub << 20) |
> --
> 2.15.2
>
>