On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <[email protected]> wrote:
>
> On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <[email protected]> wrote:
> >
> > The pxe1610 is a voltage regulator from Infineon. It also supports
> > other VRs pxe1110 and pxm1310 from Infineon.
What happened to the other compatibles? S/w doesn't need to know the
differences?
> >
> > Signed-off-by: Vijay Khemka <[email protected]>
> > ---
> > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 2e742d399e87..1be648828a31 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -99,6 +99,8 @@ properties:
> > # Infineon IR38064 Voltage Regulator
> > - infineon,ir38064
> > # Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
> > + - infineon,pxe1610
> > + # Infineon PXE1610, PXE1110 and PXM1310 Voltage Regulators
>
> The comment goes above the entry.
>
> > - infineon,slb9635tt
> > # Infineon SLB9645 I2C TPM (new protocol, max 400khz)
> > - infineon,slb9645tt
> > --
> > 2.17.1
> >
On 7/23/19, 7:53 AM, "Rob Herring" <[email protected]> wrote:
On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <[email protected]> wrote:
>
> On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <[email protected]> wrote:
> >
> > The pxe1610 is a voltage regulator from Infineon. It also supports
> > other VRs pxe1110 and pxm1310 from Infineon.
What happened to the other compatibles? S/w doesn't need to know the
differences?
As far as driver is concerned, it doesn't need to know differences.
> >
> > Signed-off-by: Vijay Khemka <[email protected]>
> > ---
> > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 2e742d399e87..1be648828a31 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -99,6 +99,8 @@ properties:
> > # Infineon IR38064 Voltage Regulator
> > - infineon,ir38064
> > # Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
> > + - infineon,pxe1610
> > + # Infineon PXE1610, PXE1110 and PXM1310 Voltage Regulators
>
> The comment goes above the entry.
>
> > - infineon,slb9635tt
> > # Infineon SLB9645 I2C TPM (new protocol, max 400khz)
> > - infineon,slb9645tt
> > --
> > 2.17.1
> >
Add pxe1610 as a trivial device
On Tue, 23 Jul 2019 at 17:14, Vijay Khemka <[email protected]> wrote:
>
> On 7/23/19, 7:53 AM, "Rob Herring" <[email protected]> wrote:
>
> On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <[email protected]> wrote:
> >
> > On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <[email protected]> wrote:
> > >
> > > The pxe1610 is a voltage regulator from Infineon. It also supports
> > > other VRs pxe1110 and pxm1310 from Infineon.
>
> What happened to the other compatibles? S/w doesn't need to know the
> differences?
> As far as driver is concerned, it doesn't need to know differences.
You have these three IDs in the driver:
pxm1310
pxm1310
pxe1610
So all three could be listed in the documentation?
Rob, is this what you wanted Vijay to do?
Joel,
I have added all 3 id in the documentation patch and I am not sure if that patch has been applied or not.
Regards
-Vijay
On 8/1/19, 11:31 PM, "Joel Stanley" <[email protected]> wrote:
Add pxe1610 as a trivial device
On Tue, 23 Jul 2019 at 17:14, Vijay Khemka <[email protected]> wrote:
>
> On 7/23/19, 7:53 AM, "Rob Herring" <[email protected]> wrote:
>
> On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <[email protected]> wrote:
> >
> > On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <[email protected]> wrote:
> > >
> > > The pxe1610 is a voltage regulator from Infineon. It also supports
> > > other VRs pxe1110 and pxm1310 from Infineon.
>
> What happened to the other compatibles? S/w doesn't need to know the
> differences?
> As far as driver is concerned, it doesn't need to know differences.
You have these three IDs in the driver:
pxm1310
pxm1310
pxe1610
So all three could be listed in the documentation?
Rob, is this what you wanted Vijay to do?