Updates the device tree to support some features on Ampere's
Mt.Mitchell BMC and Ampere's Mt.Jade BMC.
Chanh Nguyen (7):
ARM: dts: aspeed: mtjade, mtmitchell: Update gpio-line-names
ARM: dts: aspeed: mtjade, mtmitchell: Add new gpio-line-names
ARM: dts: aspeed: mtjade: Add the gpio-hog
ARM: dts: aspeed: mtmitchell: Add LEDs
ARM: dts: aspeed: mtmitchell: Add inlet temperature sensor
ARM: dts: aspeed: mtmitchell: Remove redundant ADC configurations
ARM: dts: aspeed: mtmitchell: Add I2C NVMe alias port
.../dts/aspeed/aspeed-bmc-ampere-mtjade.dts | 66 ++--
.../aspeed/aspeed-bmc-ampere-mtmitchell.dts | 315 ++++++++++++++++--
2 files changed, 334 insertions(+), 47 deletions(-)
--
2.17.1
Mt.Mitchell DVT and later hardware do not use adc1. It only uses
adc0 with channels 0, 1 and 2. This commit removes redundant ADC
configurations.
Signed-off-by: Chanh Nguyen <[email protected]>
---
.../dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
index c676172f0dbf..eb8d5e367276 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
@@ -564,20 +564,7 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
- &pinctrl_adc2_default &pinctrl_adc3_default
- &pinctrl_adc4_default &pinctrl_adc5_default
- &pinctrl_adc6_default &pinctrl_adc7_default>;
-};
-
-&adc1 {
- ref_voltage = <2500>;
- status = "okay";
-
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
- &pinctrl_adc10_default &pinctrl_adc11_default
- &pinctrl_adc12_default &pinctrl_adc13_default
- &pinctrl_adc14_default &pinctrl_adc15_default>;
+ &pinctrl_adc2_default>;
};
&vhub {
--
2.17.1
On Thu, 5 Oct 2023 at 14:26, Chanh Nguyen <[email protected]> wrote:
>
> Mt.Mitchell DVT and later hardware do not use adc1. It only uses
> adc0 with channels 0, 1 and 2. This commit removes redundant ADC
> configurations.
>
> Signed-off-by: Chanh Nguyen <[email protected]>
Reviewed-by: Joel Stanley <[email protected]>
> ---
> .../dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> index c676172f0dbf..eb8d5e367276 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> @@ -564,20 +564,7 @@
>
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> - &pinctrl_adc2_default &pinctrl_adc3_default
> - &pinctrl_adc4_default &pinctrl_adc5_default
> - &pinctrl_adc6_default &pinctrl_adc7_default>;
> -};
> -
> -&adc1 {
> - ref_voltage = <2500>;
> - status = "okay";
> -
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> - &pinctrl_adc10_default &pinctrl_adc11_default
> - &pinctrl_adc12_default &pinctrl_adc13_default
> - &pinctrl_adc14_default &pinctrl_adc15_default>;
> + &pinctrl_adc2_default>;
> };
>
> &vhub {
> --
> 2.17.1
>
On Thu, 5 Oct 2023 at 14:26, Chanh Nguyen <[email protected]> wrote:
>
> Updates the device tree to support some features on Ampere's
> Mt.Mitchell BMC and Ampere's Mt.Jade BMC.
>
> Chanh Nguyen (7):
> ARM: dts: aspeed: mtjade, mtmitchell: Update gpio-line-names
> ARM: dts: aspeed: mtjade, mtmitchell: Add new gpio-line-names
> ARM: dts: aspeed: mtjade: Add the gpio-hog
> ARM: dts: aspeed: mtmitchell: Add LEDs
> ARM: dts: aspeed: mtmitchell: Add inlet temperature sensor
> ARM: dts: aspeed: mtmitchell: Remove redundant ADC configurations
> ARM: dts: aspeed: mtmitchell: Add I2C NVMe alias port
I'll merge all patches except patch 4. Please resend that on its own
once you've added names.
We should consider creating openbmc documenatiton on recommended LED
names. Would you be able to help with that?
Cheers,
Joel
>
> .../dts/aspeed/aspeed-bmc-ampere-mtjade.dts | 66 ++--
> .../aspeed/aspeed-bmc-ampere-mtmitchell.dts | 315 ++++++++++++++++--
> 2 files changed, 334 insertions(+), 47 deletions(-)
>
> --
> 2.17.1
>
On 11/10/2023 15:31, Joel Stanley wrote:
> On Thu, 5 Oct 2023 at 14:26, Chanh Nguyen <[email protected]> wrote:
>>
>> Updates the device tree to support some features on Ampere's
>> Mt.Mitchell BMC and Ampere's Mt.Jade BMC.
>>
>> Chanh Nguyen (7):
>> ARM: dts: aspeed: mtjade, mtmitchell: Update gpio-line-names
>> ARM: dts: aspeed: mtjade, mtmitchell: Add new gpio-line-names
>> ARM: dts: aspeed: mtjade: Add the gpio-hog
>> ARM: dts: aspeed: mtmitchell: Add LEDs
>> ARM: dts: aspeed: mtmitchell: Add inlet temperature sensor
>> ARM: dts: aspeed: mtmitchell: Remove redundant ADC configurations
>> ARM: dts: aspeed: mtmitchell: Add I2C NVMe alias port
>
> I'll merge all patches except patch 4. Please resend that on its own
> once you've added names.
Thank Joel very much! Please also help me push them up at
https://github.com/openbmc/linux !
I'll resend patch 4 later.
>
> We should consider creating openbmc documenatiton on recommended LED
> names. Would you be able to help with that?
>
> Cheers,
>
> Joel
>
Yes Joel! I'm glad to help that.
>
>>
>> .../dts/aspeed/aspeed-bmc-ampere-mtjade.dts | 66 ++--
>> .../aspeed/aspeed-bmc-ampere-mtmitchell.dts | 315 ++++++++++++++++--
>> 2 files changed, 334 insertions(+), 47 deletions(-)
>>
>> --
>> 2.17.1
>>