2023-06-19 08:34:01

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] pinctrl: mlxbf3: remove broken Kconfig 'select'

From: Arnd Bergmann <[email protected]>

The new pinctrl driver selects GPIO_MLXBF3, but that can not be enabled yet because
the MELLANOX_PLATFORM symbol does not exist in the tree:

WARNING: unmet direct dependencies detected for GPIO_MLXBF3
Depends on [n]: GPIOLIB [=y] && PCI [=n] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
Selected by [y]:
- PINCTRL_MLXBF3 [=y] && PINCTRL [=y] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])

As it turns out, the pinctlr driver still builds fine without this, so just
remove the select statement.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/pinctrl/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 77ff9a641aebf..57d57af1f624e 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -510,7 +510,6 @@ config PINCTRL_MLXBF3
select PINMUX
select GPIOLIB
select GPIOLIB_IRQCHIP
- select GPIO_MLXBF3
help
Say Y to select the pinctrl driver for BlueField-3 SoCs.
This pin controller allows selecting the mux function for
--
2.39.2



2023-06-19 09:12:19

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: mlxbf3: remove broken Kconfig 'select'

On Mon, Jun 19, 2023 at 10:21 AM Arnd Bergmann <[email protected]> wrote:

> From: Arnd Bergmann <[email protected]>
>
> The new pinctrl driver selects GPIO_MLXBF3, but that can not be enabled yet because
> the MELLANOX_PLATFORM symbol does not exist in the tree:
>
> WARNING: unmet direct dependencies detected for GPIO_MLXBF3
> Depends on [n]: GPIOLIB [=y] && PCI [=n] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
> Selected by [y]:
> - PINCTRL_MLXBF3 [=y] && PINCTRL [=y] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
>
> As it turns out, the pinctlr driver still builds fine without this, so just
> remove the select statement.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Patch applied!

Yours,
Linus Walleij