2020-11-18 19:17:22

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] ARM: uncompress: Fix dbgadtb size parameter name

The dbgadtb macro is passed the size of the appended DTB, not the end
address.

Fixes: c03e41470e901123 ("ARM: 9010/1: uncompress: Print the location of appended DTB")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
arch/arm/boot/compressed/head.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
index 9905fb7560df215d..265c029c261bc8a1 100644
--- a/arch/arm/boot/compressed/head.S
+++ b/arch/arm/boot/compressed/head.S
@@ -116,7 +116,7 @@
/*
* Debug print of the final appended DTB location
*/
- .macro dbgadtb, begin, end
+ .macro dbgadtb, begin, size
#ifdef DEBUG
kputc #'D'
kputc #'T'
@@ -129,7 +129,7 @@
kputc #'('
kputc #'0'
kputc #'x'
- kphex \end, 8 /* End of appended DTB */
+ kphex \size, 8 /* Size of appended DTB */
kputc #')'
kputc #'\n'
#endif
--
2.25.1


2020-12-04 08:12:02

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] ARM: uncompress: Fix dbgadtb size parameter name

On Wed, Nov 18, 2020 at 8:13 PM Geert Uytterhoeven
<[email protected]> wrote:

> The dbgadtb macro is passed the size of the appended DTB, not the end
> address.
>
> Fixes: c03e41470e901123 ("ARM: 9010/1: uncompress: Print the location of appended DTB")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Please put this in Russell's patch tracker.

Yours,
Linus Walleij

2020-12-04 09:43:22

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] ARM: uncompress: Fix dbgadtb size parameter name

Hi Linus,

On Fri, Dec 4, 2020 at 9:08 AM Linus Walleij <[email protected]> wrote:
> On Wed, Nov 18, 2020 at 8:13 PM Geert Uytterhoeven
> <[email protected]> wrote:
> > The dbgadtb macro is passed the size of the appended DTB, not the end
> > address.
> >
> > Fixes: c03e41470e901123 ("ARM: 9010/1: uncompress: Print the location of appended DTB")
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> Reviewed-by: Linus Walleij <[email protected]>
>
> Please put this in Russell's patch tracker.

Thanks, done.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds