2023-11-03 20:03:49

by Andy Shevchenko

Subject: [PATCH v1 4/4] leds: trigger: gpio: Convert to DEVICE_ATTR_RW()

Instead of custom wrapper, use DEVICE_ATTR_RW() directly.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/leds/trigger/ledtrig-gpio.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/ledtrig-gpio.c
index 8824be19881f..7f6a2352b0ac 100644
--- a/drivers/leds/trigger/ledtrig-gpio.c
+++ b/drivers/leds/trigger/ledtrig-gpio.c
@@ -41,7 +41,7 @@ static irqreturn_t gpio_trig_irq(int irq, void *_led)
return IRQ_HANDLED;
}

-static ssize_t gpio_trig_brightness_show(struct device *dev,
+static ssize_t desired_brightness_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct gpio_trig_data *gpio_data = led_trigger_get_drvdata(dev);
@@ -49,7 +49,7 @@ static ssize_t gpio_trig_brightness_show(struct device *dev,
return sysfs_emit(buf, "%u\n", gpio_data->desired_brightness);
}

-static ssize_t gpio_trig_brightness_store(struct device *dev,
+static ssize_t desired_brightness_store(struct device *dev,
struct device_attribute *attr, const char *buf, size_t n)
{
struct gpio_trig_data *gpio_data = led_trigger_get_drvdata(dev);
@@ -64,8 +64,7 @@ static ssize_t gpio_trig_brightness_store(struct device *dev,

return n;
}
-static DEVICE_ATTR(desired_brightness, 0644, gpio_trig_brightness_show,
- gpio_trig_brightness_store);
+static DEVICE_ATTR_RW(desired_brightness);

static struct attribute *gpio_trig_attrs[] = {
&dev_attr_desired_brightness.attr,
--
2.40.0.1.gaa8946217a0b

2023-11-04 22:27:45

by Linus Walleij

Subject: Re: [PATCH v1 4/4] leds: trigger: gpio: Convert to DEVICE_ATTR_RW()

On Fri, Nov 3, 2023 at 9:03 PM Andy Shevchenko
<[email protected]> wrote:

> Instead of custom wrapper, use DEVICE_ATTR_RW() directly.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij