Update V-INTCORE regulator constraints to allow voltage and
configuration changes from consumer drivers.
Signed-off-by: Fabio Baltieri <[email protected]>
---
Hi Linus,
this patch adds the regulators bits I'm missing for ux500-musb patches.
Without this I just get a runtime warning like:
V-INTCORE: operation not allowed
but the driver works anyway and there are no build dependencies, so I
think this can safely go in the arm-soc tree on its own, and the whole
thing should work happily in -next.
Thanks,
Fabio
arch/arm/mach-ux500/board-mop500-regulators.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/board-mop500-regulators.c b/arch/arm/mach-ux500/board-mop500-regulators.c
index 2a17bc5..0a428db 100644
--- a/arch/arm/mach-ux500/board-mop500-regulators.c
+++ b/arch/arm/mach-ux500/board-mop500-regulators.c
@@ -392,7 +392,15 @@ struct regulator_init_data ab8500_regulators[AB8500_NUM_REGULATORS] = {
[AB8500_LDO_INTCORE] = {
.constraints = {
.name = "V-INTCORE",
- .valid_ops_mask = REGULATOR_CHANGE_STATUS,
+ .min_uV = 1250000,
+ .max_uV = 1350000,
+ .input_uV = 1800000,
+ .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE |
+ REGULATOR_CHANGE_STATUS |
+ REGULATOR_CHANGE_MODE |
+ REGULATOR_CHANGE_DRMS,
+ .valid_modes_mask = REGULATOR_MODE_NORMAL |
+ REGULATOR_MODE_IDLE,
},
.num_consumer_supplies = ARRAY_SIZE(ab8500_vintcore_consumers),
.consumer_supplies = ab8500_vintcore_consumers,
--
1.8.1.3
On Wed, Mar 27, 2013 at 4:21 PM, Fabio Baltieri
<[email protected]> wrote:
> Update V-INTCORE regulator constraints to allow voltage and
> configuration changes from consumer drivers.
>
> Signed-off-by: Fabio Baltieri <[email protected]>
> ---
> Hi Linus,
>
> this patch adds the regulators bits I'm missing for ux500-musb patches.
> Without this I just get a runtime warning like:
>
> V-INTCORE: operation not allowed
>
> but the driver works anyway and there are no build dependencies, so I
> think this can safely go in the arm-soc tree on its own, and the whole
> thing should work happily in -next.
Reviewed-by: Linus Walleij <[email protected]>
I know that Lee's been sending off a large set of regulator patches
lately, some include alterations to this platform config.
Maybe it's better to take this patch into the regulator tree if these
machine configs will come in that way? Also like Lee to have a
look at this...
Yours,
Linus Walleij
On Tue, Apr 02, 2013 at 10:26:12AM +0200, Linus Walleij wrote:
> I know that Lee's been sending off a large set of regulator patches
> lately, some include alterations to this platform config.
> Maybe it's better to take this patch into the regulator tree if these
> machine configs will come in that way? Also like Lee to have a
> look at this...
If it's touching the board constraints it's likely to have conflicts
with Lee's stuff, yes.
Hi Mark, Linus,
On Tue, Apr 02, 2013 at 09:38:30AM +0100, Mark Brown wrote:
> On Tue, Apr 02, 2013 at 10:26:12AM +0200, Linus Walleij wrote:
>
> > I know that Lee's been sending off a large set of regulator patches
> > lately, some include alterations to this platform config.
>
> > Maybe it's better to take this patch into the regulator tree if these
> > machine configs will come in that way? Also like Lee to have a
> > look at this...
>
> If it's touching the board constraints it's likely to have conflicts
> with Lee's stuff, yes.
Lee's patches are on -next and should not conflict with this one
(tested again on today's tree), but it may be nice anyway to have this
in the regulator framework with the others.
Mark, would you consider taking this one in your tree?
Thanks,
Fabio
--
Fabio Baltieri
On Tue, Apr 02, 2013 at 10:44:46AM +0200, Fabio Baltieri wrote:
> Mark, would you consider taking this one in your tree?
If someone sends me the patch...
Update V-INTCORE regulator constraints to allow voltage and
configuration changes from consumer drivers.
Signed-off-by: Fabio Baltieri <[email protected]>
---
arch/arm/mach-ux500/board-mop500-regulators.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/board-mop500-regulators.c b/arch/arm/mach-ux500/board-mop500-regulators.c
index 2a17bc5..0a428db 100644
--- a/arch/arm/mach-ux500/board-mop500-regulators.c
+++ b/arch/arm/mach-ux500/board-mop500-regulators.c
@@ -392,7 +392,15 @@ struct regulator_init_data ab8500_regulators[AB8500_NUM_REGULATORS] = {
[AB8500_LDO_INTCORE] = {
.constraints = {
.name = "V-INTCORE",
- .valid_ops_mask = REGULATOR_CHANGE_STATUS,
+ .min_uV = 1250000,
+ .max_uV = 1350000,
+ .input_uV = 1800000,
+ .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE |
+ REGULATOR_CHANGE_STATUS |
+ REGULATOR_CHANGE_MODE |
+ REGULATOR_CHANGE_DRMS,
+ .valid_modes_mask = REGULATOR_MODE_NORMAL |
+ REGULATOR_MODE_IDLE,
},
.num_consumer_supplies = ARRAY_SIZE(ab8500_vintcore_consumers),
.consumer_supplies = ab8500_vintcore_consumers,
--
1.8.1.3
On Tue, 02 Apr 2013, Fabio Baltieri wrote:
> Update V-INTCORE regulator constraints to allow voltage and
> configuration changes from consumer drivers.
>
> Signed-off-by: Fabio Baltieri <[email protected]>
> ---
> arch/arm/mach-ux500/board-mop500-regulators.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
I already have this queued.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
> > > I know that Lee's been sending off a large set of regulator patches
> > > lately, some include alterations to this platform config.
> >
> > > Maybe it's better to take this patch into the regulator tree if these
> > > machine configs will come in that way? Also like Lee to have a
> > > look at this...
> >
> > If it's touching the board constraints it's likely to have conflicts
> > with Lee's stuff, yes.
>
> Lee's patches are on -next
Not all of them are on -next, but all are on the MLs.
I'm currently fixing up some of Mark's review comments in order to
re-submit the remainder.
> and should not conflict with this one
> (tested again on today's tree), but it may be nice anyway to have this
> in the regulator framework with the others.
> Mark, would you consider taking this one in your tree?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, Apr 02, 2013 at 10:23:05AM +0100, Lee Jones wrote:
> On Tue, 02 Apr 2013, Fabio Baltieri wrote:
>
> > Update V-INTCORE regulator constraints to allow voltage and
> > configuration changes from consumer drivers.
> >
> > Signed-off-by: Fabio Baltieri <[email protected]>
> > ---
> > arch/arm/mach-ux500/board-mop500-regulators.c | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
>
> I already have this queued.
Ok, that was part of another yet to be merged series.
Mark, please ignore this one, sorry for the added noise.
Fabio
--
Fabio Baltieri