2018-11-07 13:45:45

by Tomer Maimon

Subject: [PATCH v1 0/1] pinctrl: nuvoton: modify NPCM7xx pin configuration

This patch Modify GPIO direction setting in pin configuration function.

please refer patch:
Kun Yi https://patchwork.ozlabs.org/patch/985540/

Tomer Maimon (1):
pinctrl: nuvoton: modify NPCM7xx pin configuration function

drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)

--
2.14.1

2018-11-07 13:46:02

by Tomer Maimon

Subject: [PATCH v1 1/1] pinctrl: nuvoton: modify NPCM7xx pin configuration function

Modify GPIO direction setting in pin configuration function by using
generic GPIO functions to set the GPIO direction instead of direct
access to the GPIO direction register.

Signed-off-by: Tomer Maimon <[email protected]>
---
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
index 7ad50d9268aa..b455209382a5 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
@@ -1799,19 +1799,12 @@ static int npcm7xx_config_set_one(struct npcm7xx_pinctrl *npcm,
npcm_gpio_set(&bank->gc, bank->base + NPCM7XX_GP_N_PU, gpio);
break;
case PIN_CONFIG_INPUT_ENABLE:
- if (arg) {
- iowrite32(gpio, bank->base + NPCM7XX_GP_N_OEC);
- npcm_gpio_set(&bank->gc, bank->base + NPCM7XX_GP_N_IEM,
- gpio);
- } else
- npcm_gpio_clr(&bank->gc, bank->base + NPCM7XX_GP_N_IEM,
- gpio);
+ iowrite32(gpio, bank->base + NPCM7XX_GP_N_OEC);
+ bank->direction_input(&bank->gc, pin % bank->gc.ngpio);
break;
case PIN_CONFIG_OUTPUT:
- npcm_gpio_clr(&bank->gc, bank->base + NPCM7XX_GP_N_IEM, gpio);
- iowrite32(gpio, arg ? bank->base + NPCM7XX_GP_N_DOS :
- bank->base + NPCM7XX_GP_N_DOC);
iowrite32(gpio, bank->base + NPCM7XX_GP_N_OES);
+ bank->direction_output(&bank->gc, pin % bank->gc.ngpio, arg);
break;
case PIN_CONFIG_DRIVE_PUSH_PULL:
npcm_gpio_clr(&bank->gc, bank->base + NPCM7XX_GP_N_OTYP, gpio);
--
2.14.1

2018-11-07 19:54:50

by Kun Yi

Subject: Re: [PATCH v1 1/1] pinctrl: nuvoton: modify NPCM7xx pin configuration function

On Wed, Nov 7, 2018 at 5:44 AM Tomer Maimon <[email protected]> wrote:
>
> Modify GPIO direction setting in pin configuration function by using
> generic GPIO functions to set the GPIO direction instead of direct
> access to the GPIO direction register.
>
> Signed-off-by: Tomer Maimon <[email protected]>
Tested-by: Kun Yi <[email protected]>

Thanks for sending the patch Tomer!
> ---
> drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> index 7ad50d9268aa..b455209382a5 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> @@ -1799,19 +1799,12 @@ static int npcm7xx_config_set_one(struct npcm7xx_pinctrl *npcm,
> npcm_gpio_set(&bank->gc, bank->base + NPCM7XX_GP_N_PU, gpio);
> break;
> case PIN_CONFIG_INPUT_ENABLE:
> - if (arg) {
> - iowrite32(gpio, bank->base + NPCM7XX_GP_N_OEC);
> - npcm_gpio_set(&bank->gc, bank->base + NPCM7XX_GP_N_IEM,
> - gpio);
> - } else
> - npcm_gpio_clr(&bank->gc, bank->base + NPCM7XX_GP_N_IEM,
> - gpio);
> + iowrite32(gpio, bank->base + NPCM7XX_GP_N_OEC);
> + bank->direction_input(&bank->gc, pin % bank->gc.ngpio);
> break;
> case PIN_CONFIG_OUTPUT:
> - npcm_gpio_clr(&bank->gc, bank->base + NPCM7XX_GP_N_IEM, gpio);
> - iowrite32(gpio, arg ? bank->base + NPCM7XX_GP_N_DOS :
> - bank->base + NPCM7XX_GP_N_DOC);
> iowrite32(gpio, bank->base + NPCM7XX_GP_N_OES);
> + bank->direction_output(&bank->gc, pin % bank->gc.ngpio, arg);
> break;
> case PIN_CONFIG_DRIVE_PUSH_PULL:
> npcm_gpio_clr(&bank->gc, bank->base + NPCM7XX_GP_N_OTYP, gpio);
> --
> 2.14.1
>


--
Regards,
Kun

2018-11-15 10:16:39

by Linus Walleij

Subject: Re: [PATCH v1 1/1] pinctrl: nuvoton: modify NPCM7xx pin configuration function

On Wed, Nov 7, 2018 at 2:44 PM Tomer Maimon <[email protected]> wrote:

> Modify GPIO direction setting in pin configuration function by using
> generic GPIO functions to set the GPIO direction instead of direct
> access to the GPIO direction register.
>
> Signed-off-by: Tomer Maimon <[email protected]>

Patch applied with Kun Yi's tested-by tag!

Yours,
Linus Walleij