2022-01-05 02:37:06

by Yang Li

Subject: [PATCH -next] power: supply_core: fix application of sizeof to pointer

The coccinelle check report:
./drivers/power/supply/cw2015_battery.c:692:12-18: ERROR: application of
sizeof to pointer

Reported-by: Abaci Robot <[email protected]>
Fixes: 25fd330370ac ("power: supply_core: Pass pointer to battery info")
Signed-off-by: Yang Li <[email protected]>
---
drivers/power/supply/cw2015_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index 0c87ad0dbf71..728e2a6cc9c3 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -689,7 +689,7 @@ static int cw_bat_probe(struct i2c_client *client)
if (ret) {
/* Allocate an empty battery */
cw_bat->battery = devm_kzalloc(&client->dev,
- sizeof(cw_bat->battery),
+ sizeof(*cw_bat->battery),
GFP_KERNEL);
if (!cw_bat->battery)
return -ENOMEM;
--
2.20.1.7.g153144c

2022-01-12 00:42:21

by Linus Walleij

Subject: Re: [PATCH -next] power: supply_core: fix application of sizeof to pointer

On Wed, Jan 5, 2022 at 3:37 AM Yang Li <[email protected]> wrote:

> The coccinelle check report:
> ./drivers/power/supply/cw2015_battery.c:692:12-18: ERROR: application of
> sizeof to pointer
>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: 25fd330370ac ("power: supply_core: Pass pointer to battery info")
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Thanks for finding this!

Yours,
Linus Walleij