2024-02-07 10:47:00

by Antonio Borneo

Subject: [PATCH] pinctrl: stm32: fix PM support for stm32mp257

The driver for stm32mp257 is missing the suspend callback in
struct dev_pm_ops.

Add the callback, using the common stm32_pinctrl_suspend()
function.

Signed-off-by: Antonio Borneo <[email protected]>
Fixes: 619f8ca4a73d ("pinctrl: stm32: add stm32mp257 pinctrl support")
---
drivers/pinctrl/stm32/pinctrl-stm32mp257.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/stm32/pinctrl-stm32mp257.c b/drivers/pinctrl/stm32/pinctrl-stm32mp257.c
index 73f091cd827e..23aebd4695e9 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32mp257.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32mp257.c
@@ -2562,7 +2562,7 @@ static const struct of_device_id stm32mp257_pctrl_match[] = {
};

static const struct dev_pm_ops stm32_pinctrl_dev_pm_ops = {
- SET_LATE_SYSTEM_SLEEP_PM_OPS(NULL, stm32_pinctrl_resume)
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(stm32_pinctrl_suspend, stm32_pinctrl_resume)
};

static struct platform_driver stm32mp257_pinctrl_driver = {

base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
--
2.34.1

2024-02-08 14:11:14

by Linus Walleij

Subject: Re: [PATCH] pinctrl: stm32: fix PM support for stm32mp257

On Wed, Feb 7, 2024 at 11:46 AM Antonio Borneo
<[email protected]> wrote:

> The driver for stm32mp257 is missing the suspend callback in
> struct dev_pm_ops.
>
> Add the callback, using the common stm32_pinctrl_suspend()
> function.
>
> Signed-off-by: Antonio Borneo <[email protected]>
> Fixes: 619f8ca4a73d ("pinctrl: stm32: add stm32mp257 pinctrl support")

Patch applied!

Yours,
Linus Walleij