2023-12-15 11:34:00

by Nam Cao

[permalink] [raw]
Subject: [PATCH 1/2] spi: pl022: delete description of cur_msg

The variable cur_msg was removed, but its description is left behind.
Delete this description.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Nam Cao <[email protected]>
---
drivers/spi/spi-pl022.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 3baf45da01cd..bdec67cf45f2 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -338,7 +338,6 @@ struct vendor_data {
* @clk: outgoing clock "SPICLK" for the SPI bus
* @host: SPI framework hookup
* @host_info: controller-specific data from machine setup
- * @cur_msg: Pointer to current spi_message being processed
* @cur_transfer: Pointer to current spi_transfer
* @cur_chip: pointer to current clients chip(assigned from controller_state)
* @tx: current position in TX buffer to be read
--
2.39.2



2023-12-15 11:34:20

by Nam Cao

[permalink] [raw]
Subject: [PATCH 2/2] spi: pl022: update description of internal_cs_control()

The arguments of internal_cs_control() was changed, but its description
was not updated. Update the description to match the expected arguments.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Nam Cao <[email protected]>
---
drivers/spi/spi-pl022.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index bdec67cf45f2..de63cf0557ce 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -419,7 +419,7 @@ struct chip_data {
/**
* internal_cs_control - Control chip select signals via SSP_CSR.
* @pl022: SSP driver private data structure
- * @command: select/delect the chip
+ * @enable: select/delect the chip
*
* Used on controller with internal chip select control via SSP_CSR register
* (vendor extension). Each of the 5 LSB in the register controls one chip
--
2.39.2


2023-12-15 12:11:19

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] spi: pl022: delete description of cur_msg

On Fri, Dec 15, 2023 at 12:33 PM Nam Cao <[email protected]> wrote:

> The variable cur_msg was removed, but its description is left behind.
> Delete this description.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Nam Cao <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-12-15 12:11:25

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 2/2] spi: pl022: update description of internal_cs_control()

On Fri, Dec 15, 2023 at 12:33 PM Nam Cao <[email protected]> wrote:

> The arguments of internal_cs_control() was changed, but its description
> was not updated. Update the description to match the expected arguments.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Nam Cao <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-12-15 16:27:09

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/2] spi: pl022: delete description of cur_msg

On Fri, 15 Dec 2023 12:33:37 +0100, Nam Cao wrote:
> The variable cur_msg was removed, but its description is left behind.
> Delete this description.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: pl022: delete description of cur_msg
commit: e695c1fc5a3db1e161abe8061d715a504aff3f9f
[2/2] spi: pl022: update description of internal_cs_control()
commit: 644f315d12ea29a67bc985d06ab0962452eb3605

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark