This patch series attempts to fix the remaining F: patterns on the
MAINTAINERS file which point to non-existing files or directories.
Several more problems with the F: patterns appeared since the previous
patch series was sent. This patch series fixes all of them, except for
the removal of drivers/rtc/rtc-sec.c (which was NAKed). It also has a
copy of the single patch from the previous series which was not applied
(fix BAST).
Patch 12 also attempts to add matching uapi/ patterns to all include
directory patterns where this was not yet done, if applicable.
The last two patches in this series are optional. They add the small
script which I used to find the broken patterns, and change one pattern
to avoid a false positive from the script.
Cesar Eduardo Barros (14):
MAINTAINERS: remove 3c505
MAINTAINERS: remove arch/arm/plat-nomadik/
MAINTAINERS: remove arch/arm/plat-s3c24xx/
MAINTAINERS: fix drivers/media/i2c/cx2341x.c
MAINTAINERS: remove drivers/net/wan/cycx*
MAINTAINERS: fix drivers/edac/ghes-edac.c
MAINTAINERS: remove eexpress
MAINTAINERS: fix mach-omap2 clockdomain/powerdomain
MAINTAINERS: fix Documentation/video4linux/saa7134/
MAINTAINERS: remove include/media/sh_veu.h
MAINTAINERS: fix BAST
MAINTAINERS: adjust for UAPI (part 2)
scripts: add checkmaintainers.py
MAINTAINERS: use same pattern for firewire in uapi
MAINTAINERS | 69 ++++++++++++++++++++++++---------------------
scripts/checkmaintainers.py | 35 +++++++++++++++++++++++
2 files changed, 72 insertions(+), 32 deletions(-)
create mode 100755 scripts/checkmaintainers.py
--
1.7.11.7
This avoids a false positive in the checkmaintainers.py script.
Cc: Stefan Richter <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 772da4f..022317b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3236,7 +3236,7 @@ W: http://ieee1394.wiki.kernel.org/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git
S: Maintained
F: drivers/firewire/
-F: include/linux/firewire.h
+F: include/linux/firewire*.h
F: include/uapi/linux/firewire*.h
F: tools/firewire/
--
1.7.11.7
The files within that directory were moved to other places over the
course of several commits. I only added the ones moved in the patch
series which finally removed the directory; untangling the rest will
take more work, since some seem to be shared with ux500.
In fact, the ARM/Ux500 ARM ARCHITECTURE block has patterns for files
named "nomadik" too. The patterns in this pair of MAINTAINER blocks
really need a review from the respective maintainters.
Cc: Alessandro Rubini <[email protected]>
Cc: Srinidhi Kasagar <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: STEricsson <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5b64aa5..3c074d5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1009,8 +1009,11 @@ M: STEricsson <[email protected]>
L: [email protected] (moderated for non-subscribers)
S: Maintained
F: arch/arm/mach-nomadik/
-F: arch/arm/plat-nomadik/
+F: drivers/clocksource/nomadik-mtu.c
F: drivers/i2c/busses/i2c-nomadik.c
+F: include/linux/platform_data/clocksource-nomadik-mtu.h
+F: include/linux/platform_data/dma-ste-dma40.h
+F: include/linux/platform_data/pinctrl-nomadik.h
T: git git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git
ARM/OPENMOKO NEO FREERUNNER (GTA02) MACHINE SUPPORT
--
1.7.11.7
This directory was removed by commit 09ec1d7 (ARM: S3C24XX: Remove
plat-s3c24xx directory in arch/arm/).
Cc: Kukjin Kim <[email protected]>
Cc: Ben Dooks <[email protected]>
Cc: Russell King <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3c074d5..5af82f9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1119,7 +1119,6 @@ L: [email protected] (moderated for non-subscribers)
W: http://www.fluff.org/ben/linux/
S: Maintained
F: arch/arm/plat-samsung/
-F: arch/arm/plat-s3c24xx/
F: arch/arm/mach-s3c24*/
F: arch/arm/mach-s3c64xx/
F: drivers/*/*s3c2410*
--
1.7.11.7
More headers were moved or split to uapi/ since the last patch was
created.
Cc: David Howells <[email protected]>
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b73c00d..772da4f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -474,6 +474,7 @@ L: [email protected]
S: Supported
F: fs/aio.c
F: include/linux/*aio*.h
+F: include/uapi/linux/*aio*.h
ALCATEL SPEEDTOUCH USB DRIVER
M: Duncan Sands <[email protected]>
@@ -2178,6 +2179,7 @@ L: [email protected]
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git
S: Maintained
F: include/linux/cgroup*
+F: include/uapi/linux/cgroup*
F: kernel/cgroup*
F: mm/*cgroup*
@@ -2493,6 +2495,7 @@ F: drivers/md/dm*
F: drivers/md/persistent-data/
F: include/linux/device-mapper.h
F: include/linux/dm-*.h
+F: include/uapi/linux/dm-*.h
DIOLAN U2C-12 I2C DRIVER
M: Guenter Roeck <[email protected]>
@@ -3064,6 +3067,7 @@ L: [email protected]
W: http://www.linuxfoundation.org/en/Net:Bridge
S: Maintained
F: include/linux/netfilter_bridge/
+F: include/uapi/linux/netfilter_bridge/
F: net/bridge/
EXT2 FILE SYSTEM
@@ -4557,6 +4561,7 @@ S: Supported
F: Documentation/*/kvm.txt
F: arch/*/kvm/
F: arch/*/include/asm/kvm*
+F: arch/*/include/uapi/asm/kvm*
F: include/linux/kvm*
F: include/uapi/linux/kvm*
F: virt/kvm/
@@ -4567,6 +4572,7 @@ L: [email protected]
W: http://kvm.qumranet.com
S: Maintained
F: arch/x86/include/asm/svm.h
+F: arch/x86/include/uapi/asm/svm.h
F: arch/x86/kvm/svm.c
KERNEL VIRTUAL MACHINE (KVM) FOR POWERPC
@@ -4576,6 +4582,7 @@ W: http://kvm.qumranet.com
T: git git://github.com/agraf/linux-2.6.git
S: Supported
F: arch/powerpc/include/asm/kvm*
+F: arch/powerpc/include/uapi/asm/kvm*
F: arch/powerpc/kvm/
KERNEL VIRTUAL MACHINE For Itanium (KVM/IA64)
@@ -4585,6 +4592,7 @@ W: http://kvm.qumranet.com
S: Supported
F: Documentation/ia64/kvm.txt
F: arch/ia64/include/asm/kvm*
+F: arch/ia64/include/uapi/asm/kvm*
F: arch/ia64/kvm/
KERNEL VIRTUAL MACHINE for s390 (KVM/s390)
@@ -4596,6 +4604,7 @@ W: http://www.ibm.com/developerworks/linux/linux390/
S: Supported
F: Documentation/s390/kvm.txt
F: arch/s390/include/asm/kvm*
+F: arch/s390/include/uapi/asm/kvm*
F: arch/s390/kvm/
F: drivers/s390/kvm/
@@ -5122,6 +5131,7 @@ F: Documentation/DocBook/media/
F: drivers/media/
F: drivers/staging/media/
F: include/media/
+F: include/linux/videodev2.h
F: include/uapi/linux/dvb/
F: include/uapi/linux/videodev2.h
F: include/uapi/linux/media.h
@@ -5223,6 +5233,7 @@ MODULE SUPPORT
M: Rusty Russell <[email protected]>
S: Maintained
F: include/linux/module.h
+F: include/uapi/linux/module.h
F: kernel/module.c
MOTION EYE VAIO PICTUREBOOK CAMERA DRIVER
@@ -5907,6 +5918,7 @@ L: [email protected] (subscribers-only)
S: Orphan
F: drivers/parport/
F: include/linux/parport*.h
+F: include/uapi/linux/parport*.h
F: drivers/char/ppdev.c
F: include/uapi/linux/ppdev.h
@@ -5992,6 +6004,7 @@ S: Supported
F: Documentation/PCI/
F: drivers/pci/
F: include/linux/pci*
+F: include/uapi/linux/pci*
PCMCIA SUBSYSTEM
P: Linux PCMCIA Team
@@ -6208,6 +6221,7 @@ S: Maintained
F: Documentation/pps/
F: drivers/pps/
F: include/linux/pps*.h
+F: include/uapi/linux/pps*.h
PPTP DRIVER
M: Dmitry Kozlov <[email protected]>
@@ -6252,6 +6266,7 @@ S: Maintained
F: arch/powerpc/boot/ps3*
F: arch/powerpc/include/asm/lv1call.h
F: arch/powerpc/include/asm/ps3*.h
+F: arch/powerpc/include/uapi/asm/ps3*.h
F: arch/powerpc/platforms/ps3/
F: drivers/*/ps3*
F: drivers/ps3/
@@ -6287,6 +6302,7 @@ F: drivers/net/ethernet/freescale/gianfar_ptp.c
F: drivers/net/phy/dp83640*
F: drivers/ptp/*
F: include/linux/ptp_cl*
+F: include/uapi/linux/ptp_cl*
PTRACE SUPPORT
M: Roland McGrath <[email protected]>
@@ -6894,6 +6910,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-pending-2.6.git
S: Maintained
F: drivers/scsi/
F: include/scsi/
+F: include/uapi/scsi/
SCSI TAPE DRIVER
M: Kai Mäkisara <[email protected]>
@@ -6990,6 +7007,7 @@ W: http://selinuxproject.org
T: git git://git.infradead.org/users/eparis/selinux.git
S: Supported
F: include/linux/selinux*
+F: include/uapi/linux/selinux*
F: security/selinux/
F: scripts/selinux/
@@ -7693,6 +7711,7 @@ M: Balbir Singh <[email protected]>
S: Maintained
F: Documentation/accounting/taskstats*
F: include/linux/taskstats*
+F: include/uapi/linux/taskstats*
F: kernel/taskstats.c
TC CLASSIFIER
@@ -8258,6 +8277,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
S: Maintained
F: drivers/usb/gadget/
F: include/linux/usb/gadget*
+F: include/uapi/linux/usb/gadget*
USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REMOTE CONTROLS, ...)
M: Jiri Kosina <[email protected]>
@@ -8432,6 +8452,7 @@ F: drivers/net/usb/
F: drivers/usb/
F: include/linux/usb.h
F: include/linux/usb/
+F: include/uapi/linux/usb/
USB UHCI DRIVER
M: Alan Stern <[email protected]>
@@ -8521,6 +8542,7 @@ S: Maintained
F: Documentation/DocBook/uio-howto.tmpl
F: drivers/uio/
F: include/linux/uio*.h
+F: include/uapi/linux/uio*.h
UTIL-LINUX PACKAGE
M: Karel Zak <[email protected]>
@@ -8578,6 +8600,7 @@ F: drivers/virtio/
F: drivers/net/virtio_net.c
F: drivers/block/virtio_blk.c
F: include/linux/virtio_*.h
+F: include/uapi/linux/virtio_*.h
VIRTIO HOST (VHOST)
M: "Michael S. Tsirkin" <[email protected]>
@@ -8628,6 +8651,7 @@ L: [email protected]
S: Maintained
F: drivers/net/macvlan.c
F: include/linux/if_*vlan.h
+F: include/uapi/linux/if_*vlan.h
F: net/8021q/
VLYNQ BUS
--
1.7.11.7
This small script checks the file patterns in the MAINTAINERS file.
For every file pattern, it checks if the pattern matches any file or
directory in the kernel tree, printing the patterns which do not have a
match.
It also checks for any file pattern pointing to any of the include
directories which does not have a corresponding UAPI file pattern, but
only if the UAPI file pattern would have a match. It also does the same
in the opposite direction.
The script is written in Python; I found its glob function more
well-behaved than Perl's. It should work on both Python 2 and Python 3
without any changes (not even 2to3 is needed); tested on 2.7, 3.2, and
3.3.
I do not think such a short script should have a copyright. But to avoid
any problems, I arbitrarily used the "GNU All-Permissive License" (found
in FSF's GPL-compatible list). If needed, feel free to relicense it as
GPLv2+, 3-clause BSD, or even WTFPLv2 or CC0.
Cc: David Howells <[email protected]>
Cc: Joe Perches <[email protected]>
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
scripts/checkmaintainers.py | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100755 scripts/checkmaintainers.py
diff --git a/scripts/checkmaintainers.py b/scripts/checkmaintainers.py
new file mode 100755
index 0000000..99740e3
--- /dev/null
+++ b/scripts/checkmaintainers.py
@@ -0,0 +1,35 @@
+#!/usr/bin/python
+# Quick check for missing file patterns in the MAINTAINERS file.
+#
+# Copyright (C) 2012 Cesar Eduardo Barros <[email protected]>
+#
+# Copying and distribution of this file, with or without modification,
+# are permitted in any medium without royalty provided the copyright
+# notice and this notice are preserved. This file is offered as-is,
+# without any warranty.
+
+from __future__ import print_function, unicode_literals, with_statement
+from glob import glob
+
+seen = set()
+
+with open('MAINTAINERS', 'rb') as f:
+ for line in f:
+ line = line.decode('utf-8')
+ if line.startswith('F:'):
+ pattern = line.partition(':')[2].strip()
+ seen.add(pattern)
+
+ if not glob(pattern):
+ print('No match for F: {0}'.format(pattern))
+
+# Check for missing uapi/ pattern
+for pattern in seen:
+ if 'include/' in pattern:
+ if 'include/uapi/' in pattern:
+ other = pattern.replace('include/uapi/', 'include/')
+ else:
+ other = pattern.replace('include/', 'include/uapi/')
+
+ if other not in seen and glob(other):
+ print('Missing {0} for {1}'.format(other, pattern))
--
1.7.11.7
These files were renamed by commit 85fd6d6 (ARM: S3C2410: move
mach-s3c2410/* into mach-s3c24xx/).
Cc: Ben Dooks <[email protected]>
Cc: Vincent Sanders <[email protected]>
Cc: Simtec Linux Team <[email protected]>
Cc: Paul Bolle <[email protected]>
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5cb888a..b73c00d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7119,9 +7119,9 @@ P: Vincent Sanders <[email protected]>
M: Simtec Linux Team <[email protected]>
W: http://www.simtec.co.uk/products/EB2410ITX/
S: Supported
-F: arch/arm/mach-s3c2410/mach-bast.c
-F: arch/arm/mach-s3c2410/bast-ide.c
-F: arch/arm/mach-s3c2410/bast-irq.c
+F: arch/arm/mach-s3c24xx/mach-bast.c
+F: arch/arm/mach-s3c24xx/bast-ide.c
+F: arch/arm/mach-s3c24xx/bast-irq.c
TI DAVINCI MACHINE SUPPORT
M: Sekhar Nori <[email protected]>
--
1.7.11.7
This driver was removed by commit 0e245db (drivers/net: delete the 3Com
3c505/3c507 intel i825xx support).
Cc: Paul Gortmaker <[email protected]>
Cc: Philip Blundell <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 6 ------
1 file changed, 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index aea0adf..5b64aa5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -114,12 +114,6 @@ Maintainers List (try to look for most precise areas first)
-----------------------------------
-3C505 NETWORK DRIVER
-M: Philip Blundell <[email protected]>
-L: [email protected]
-S: Maintained
-F: drivers/net/ethernet/i825xx/3c505*
-
3C59X NETWORK DRIVER
M: Steffen Klassert <[email protected]>
L: [email protected]
--
1.7.11.7
Apparently a copy-paste mistake; the similar sh_vou.h exists, and both
were added to MAINTAINERS by commit b618b69 ([media] MAINTAINERS: add
entries for sh_veu and sh_vou V4L2 drivers).
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 44b9f69..5cb888a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7088,7 +7088,6 @@ M: Guennadi Liakhovetski <[email protected]>
L: [email protected]
S: Maintained
F: drivers/media/platform/sh_veu.c
-F: include/media/sh_veu.h
SH_VOU V4L2 OUTPUT DRIVER
M: Guennadi Liakhovetski <[email protected]>
--
1.7.11.7
That directory never existed. The intention was probably to match
CARDLIST.saa7134 and README.saa7134.
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 46c1288..44b9f69 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6741,7 +6741,7 @@ L: [email protected]
W: http://linuxtv.org
T: git git://linuxtv.org/media_tree.git
S: Odd fixes
-F: Documentation/video4linux/saa7134/
+F: Documentation/video4linux/*.saa7134
F: drivers/media/pci/saa7134/
SAA7146 VIDEO4LINUX-2 DRIVER
--
1.7.11.7
This file was moved to drivers/media/common/ by commit 6259582 ([media]
cx2341x: move from media/i2c to media/common).
Cc: Hans Verkuil <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5af82f9..261b245 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2286,7 +2286,7 @@ L: [email protected]
T: git git://linuxtv.org/media_tree.git
W: http://linuxtv.org
S: Maintained
-F: drivers/media/i2c/cx2341x*
+F: drivers/media/common/cx2341x*
F: include/media/cx2341x*
CX88 VIDEO4LINUX DRIVER
--
1.7.11.7
The code in these files was moved to cm*.[ch] and prm*.[ch] in the same
directory by commits 4981539 (ARM: OMAP2+: powerdomain/PRM: move the
low-level powerdomain functions into PRM) and 4bd5259 (ARM: OMAP2/3:
clockdomain/PRM/CM: move the low-level clockdomain functions into
PRM/CM).
I am not sure if this fix is correct, since there are other things in
these files. Please NAK this patch (and propose a better one) if it is
wrong.
Cc: Paul Walmsley <[email protected]>
Cc: Rajendra Nayak <[email protected]>
Cc: Russ Dill <[email protected]>
Cc: Santosh Shilimkar <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 92718d8..46c1288 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5651,10 +5651,8 @@ M: Rajendra Nayak <[email protected]>
M: Paul Walmsley <[email protected]>
L: [email protected]
S: Maintained
-F: arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
-F: arch/arm/mach-omap2/powerdomain44xx.c
-F: arch/arm/mach-omap2/clockdomain2xxx_3xxx.c
-F: arch/arm/mach-omap2/clockdomain44xx.c
+F: arch/arm/mach-omap2/cm*.[ch]
+F: arch/arm/mach-omap2/prm*.[ch]
OMAP AUDIO SUPPORT
M: Peter Ujfalusi <[email protected]>
--
1.7.11.7
This driver was removed by commit 6fcdf4f (wanrouter: delete now
orphaned header content, files/drivers).
Cc: Paul Gortmaker <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 6 ------
1 file changed, 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 261b245..e909cd3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2357,12 +2357,6 @@ W: http://www.arm.linux.org.uk/
S: Maintained
F: drivers/video/cyber2000fb.*
-CYCLADES 2X SYNC CARD DRIVER
-M: Arnaldo Carvalho de Melo <[email protected]>
-W: http://oops.ghostprotocols.net:81/blog
-S: Maintained
-F: drivers/net/wan/cycx*
-
CYCLADES ASYNC MUX DRIVER
W: http://www.cyclades.com/
S: Orphan
--
1.7.11.7
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e909cd3..2e1443c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2899,7 +2899,7 @@ M: Mauro Carvalho Chehab <[email protected]>
L: [email protected]
W: bluesmoke.sourceforge.net
S: Maintained
-F: drivers/edac/ghes-edac.c
+F: drivers/edac/ghes_edac.c
EDAC-I82443BXGX
M: Tim Small <[email protected]>
--
1.7.11.7
This driver was removed by commit f84932d (drivers/net: delete ISA intel
eexpress and eepro i825xx drivers).
Cc: Paul Gortmaker <[email protected]>
Cc: Philip Blundell <[email protected]>
Cc: [email protected]
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
MAINTAINERS | 6 ------
1 file changed, 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2e1443c..92718d8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3057,12 +3057,6 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/kristoffer/linux-hpc.git
F: drivers/video/s1d13xxxfb.c
F: include/video/s1d13xxxfb.h
-ETHEREXPRESS-16 NETWORK DRIVER
-M: Philip Blundell <[email protected]>
-L: [email protected]
-S: Maintained
-F: drivers/net/ethernet/i825xx/eexpress.*
-
ETHERNET BRIDGE
M: Stephen Hemminger <[email protected]>
L: [email protected]
--
1.7.11.7
On Sat, 2013-03-02 at 22:53 -0300, Cesar Eduardo Barros wrote:
> This avoids a false positive in the checkmaintainers.py script.
You should fix the script instead of making
deliberate errors in MAINTAINERS.
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -3236,7 +3236,7 @@ W: http://ieee1394.wiki.kernel.org/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git
> S: Maintained
> F: drivers/firewire/
> -F: include/linux/firewire.h
> +F: include/linux/firewire*.h
From: Cesar Eduardo Barros <[email protected]>
Date: Sat, 2 Mar 2013 22:53:43 -0300
> This driver was removed by commit 6fcdf4f (wanrouter: delete now
> orphaned header content, files/drivers).
>
> Cc: Paul Gortmaker <[email protected]>
> Cc: Arnaldo Carvalho de Melo <[email protected]>
> Cc: [email protected]
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
Applied.
From: Cesar Eduardo Barros <[email protected]>
Date: Sat, 2 Mar 2013 22:53:45 -0300
> This driver was removed by commit f84932d (drivers/net: delete ISA intel
> eexpress and eepro i825xx drivers).
>
> Cc: Paul Gortmaker <[email protected]>
> Cc: Philip Blundell <[email protected]>
> Cc: [email protected]
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
Applied.
From: Cesar Eduardo Barros <[email protected]>
Date: Sat, 2 Mar 2013 22:53:39 -0300
> This driver was removed by commit 0e245db (drivers/net: delete the 3Com
> 3c505/3c507 intel i825xx support).
>
> Cc: Paul Gortmaker <[email protected]>
> Cc: Philip Blundell <[email protected]>
> Cc: [email protected]
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
Applied.
On Sun March 3 2013 02:53:42 Cesar Eduardo Barros wrote:
> This file was moved to drivers/media/common/ by commit 6259582 ([media]
> cx2341x: move from media/i2c to media/common).
>
> Cc: Hans Verkuil <[email protected]>
> Cc: [email protected]
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5af82f9..261b245 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2286,7 +2286,7 @@ L: [email protected]
> T: git git://linuxtv.org/media_tree.git
> W: http://linuxtv.org
> S: Maintained
> -F: drivers/media/i2c/cx2341x*
> +F: drivers/media/common/cx2341x*
> F: include/media/cx2341x*
>
> CX88 VIDEO4LINUX DRIVER
>
Acked-by: Hans Verkuil <[email protected]>
Thanks! I completely forgot to update this when I moved the file.
Regards,
Hans
[Stripped Vincent's bouncing address.]
On Sat, 2013-03-02 at 22:53 -0300, Cesar Eduardo Barros wrote:
> These files were renamed by commit 85fd6d6 (ARM: S3C2410: move
> mach-s3c2410/* into mach-s3c24xx/).
>
> Cc: Ben Dooks <[email protected]>
> Cc: Vincent Sanders <[email protected]>
> Cc: Simtec Linux Team <[email protected]>
> Cc: Paul Bolle <[email protected]>
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
> ---
> MAINTAINERS | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5cb888a..b73c00d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7119,9 +7119,9 @@ P: Vincent Sanders <[email protected]>
> M: Simtec Linux Team <[email protected]>
> W: http://www.simtec.co.uk/products/EB2410ITX/
> S: Supported
> -F: arch/arm/mach-s3c2410/mach-bast.c
> -F: arch/arm/mach-s3c2410/bast-ide.c
> -F: arch/arm/mach-s3c2410/bast-irq.c
> +F: arch/arm/mach-s3c24xx/mach-bast.c
> +F: arch/arm/mach-s3c24xx/bast-ide.c
> +F: arch/arm/mach-s3c24xx/bast-irq.c
>
> TI DAVINCI MACHINE SUPPORT
> M: Sekhar Nori <[email protected]>
This patch looks technically correct. Applying it won't hurt anyone. But
nothing has changed since yesterday's discussion. I still suggest to
remove this entry entirely.
Paul Bolle
On Sat, 2013-03-02 at 22:53 -0300, Cesar Eduardo Barros wrote:
> For every file pattern, it checks if the pattern matches any file or
> directory in the kernel tree, printing the patterns which do not have a
> match.
In a script I cobbled together for local consumption, I invoked "git
ls-files" to generate the list of files to check against. Using the
files and directories currently in one's kernel tree is liable to
generating false positives or false negatives.
Paul Bolle
On Mar 02 Cesar Eduardo Barros wrote:
> This avoids a false positive in the checkmaintainers.py script.
[...]
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3236,7 +3236,7 @@ W: http://ieee1394.wiki.kernel.org/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git
> S: Maintained
> F: drivers/firewire/
> -F: include/linux/firewire.h
> +F: include/linux/firewire*.h
> F: include/uapi/linux/firewire*.h
> F: tools/firewire/
>
I prefer "include/linux/firewire.h".
--
Stefan Richter
-=====-===-= --== ---==
http://arcgraph.de/sr/
Cesar Eduardo Barros wrote:
>
> This directory was removed by commit 09ec1d7 (ARM: S3C24XX: Remove
> plat-s3c24xx directory in arch/arm/).
>
> Cc: Kukjin Kim <[email protected]>
Acked-by: Kukjin Kim <[email protected]>
Thanks.
- Kukjin
> Cc: Ben Dooks <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
> ---
> MAINTAINERS | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3c074d5..5af82f9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1119,7 +1119,6 @@ L: [email protected] (moderated
> for non-subscribers)
> W: http://www.fluff.org/ben/linux/
> S: Maintained
> F: arch/arm/plat-samsung/
> -F: arch/arm/plat-s3c24xx/
> F: arch/arm/mach-s3c24*/
> F: arch/arm/mach-s3c64xx/
> F: drivers/*/*s3c2410*
> --
> 1.7.11.7
Cesar Eduardo Barros <[email protected]> wrote:
> F: include/linux/*aio*.h
> +F: include/uapi/linux/*aio*.h
I wonder if we can infer things like this in the scripts rather than needing
to make it explicit.
David
On Sun, Mar 3, 2013 at 2:53 AM, Cesar Eduardo Barros <[email protected]> wrote:
> The files within that directory were moved to other places over the
> course of several commits. I only added the ones moved in the patch
> series which finally removed the directory; untangling the rest will
> take more work, since some seem to be shared with ux500.
>
> In fact, the ARM/Ux500 ARM ARCHITECTURE block has patterns for files
> named "nomadik" too. The patterns in this pair of MAINTAINER blocks
> really need a review from the respective maintainters.
>
> Cc: Alessandro Rubini <[email protected]>
> Cc: Srinidhi Kasagar <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: STEricsson <[email protected]>
> Cc: [email protected]
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
Thanks for doing this Cesar!
Reviewed-by: Linus Walleij <[email protected]>
The reason some drivers are named "Nomadik" is that that
platform was the first using that IP block, but in some cases
like drivers/i2c/busses/i2c-nomadik.c the original platform has
not yet been migrated to it.
Yours,
Linus Walleij
> In fact, the ARM/Ux500 ARM ARCHITECTURE block has patterns for files
> named "nomadik" too. The patterns in this pair of MAINTAINER blocks
> really need a review from the respective maintainters.
Thanks!
Acked-by: Alessandro Rubini <[email protected]>
Hi,
On Sat, 2 Mar 2013, Cesar Eduardo Barros wrote:
> The code in these files was moved to cm*.[ch] and prm*.[ch] in the same
> directory by commits 4981539 (ARM: OMAP2+: powerdomain/PRM: move the
> low-level powerdomain functions into PRM) and 4bd5259 (ARM: OMAP2/3:
> clockdomain/PRM/CM: move the low-level clockdomain functions into
> PRM/CM).
>
> I am not sure if this fix is correct, since there are other things in
> these files. Please NAK this patch (and propose a better one) if it is
> wrong.
>
> Cc: Paul Walmsley <[email protected]>
> Cc: Rajendra Nayak <[email protected]>
> Cc: Russ Dill <[email protected]>
> Cc: Santosh Shilimkar <[email protected]>
> Cc: [email protected]
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
Looks like this one got lost in my inbox.
Acked-by: Paul Walmsley <[email protected]>
(but you'll probably need to update it against a recent kernel and resend)
- Paul
> ---
> MAINTAINERS | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92718d8..46c1288 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5651,10 +5651,8 @@ M: Rajendra Nayak <[email protected]>
> M: Paul Walmsley <[email protected]>
> L: [email protected]
> S: Maintained
> -F: arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
> -F: arch/arm/mach-omap2/powerdomain44xx.c
> -F: arch/arm/mach-omap2/clockdomain2xxx_3xxx.c
> -F: arch/arm/mach-omap2/clockdomain44xx.c
> +F: arch/arm/mach-omap2/cm*.[ch]
> +F: arch/arm/mach-omap2/prm*.[ch]
>
> OMAP AUDIO SUPPORT
> M: Peter Ujfalusi <[email protected]>
> --
> 1.7.11.7
>