2022-09-08 10:36:54

by Andy Shevchenko

Subject: [PATCH v1 1/1] pinctrl: pistachio: Correct the fwnode_irq_get() return value check

fwnode_irq_get() may return all possible signed values, such as Linux
error code or 0. Fix the code to handle this properly.

Fixes: 1074e1d23a5c ("pinctrl: pistachio: Switch to use fwnode instead of")
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/pinctrl/pinctrl-pistachio.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c
index 940ed3fff63a..7ca4ecb6eb8d 100644
--- a/drivers/pinctrl/pinctrl-pistachio.c
+++ b/drivers/pinctrl/pinctrl-pistachio.c
@@ -1374,8 +1374,14 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)

ret = fwnode_irq_get(child, 0);
if (ret < 0) {
+ fwnode_handle_put(child);
+ dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i);
+ goto err;
+ }
+ if (!ret) {
fwnode_handle_put(child);
dev_err(pctl->dev, "No IRQ for bank %u\n", i);
+ ret = -EINVAL;
goto err;
}
irq = ret;
--
2.35.1

2022-09-08 13:28:18

by Linus Walleij

Subject: Re: [PATCH v1 1/1] pinctrl: pistachio: Correct the fwnode_irq_get() return value check

On Thu, Sep 8, 2022 at 11:43 AM Andy Shevchenko
<[email protected]> wrote:

> fwnode_irq_get() may return all possible signed values, such as Linux
> error code or 0. Fix the code to handle this properly.
>
> Fixes: 1074e1d23a5c ("pinctrl: pistachio: Switch to use fwnode instead of")
> Signed-off-by: Andy Shevchenko <[email protected]>

Patch applied.

Yours,
Linus Walleij