On Wed, Dec 18, 2019 at 12:20 AM Rahul Tanwar
<[email protected]> wrote:
>
> Kernel 5.5 adds generic pin mux & cfg node schema. Update pinctrl bindings
> for LGM to use these newly added schemas. Also, rename filename to match
> the compatible string.
>
> Signed-off-by: Rahul Tanwar <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/intel,lgm-io.yaml | 76 ++++++++++++++
> .../bindings/pinctrl/intel,lgm-pinctrl.yaml | 116 ---------------------
> 2 files changed, 76 insertions(+), 116 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/intel,lgm-pinctrl.yaml
Pretty sure I've said on multiple occasions to run 'make
dt_binding_check'... Linux-next is broken by this (and others).
> diff --git a/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml b/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
> new file mode 100644
> index 000000000000..a386fb520510
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/pinctrl/intel,lgm-io.yaml#
Drop 'bindings' from the path.
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel Lightning Mountain SoC pinmux & GPIO controller binding
> +
> +maintainers:
> + - Rahul Tanwar <[email protected]>
> +
> +description: |
> + Pinmux & GPIO controller controls pin multiplexing & configuration including
> + GPIO function selection & GPIO attributes configuration.
> +
> +allOf:
> + - $ref: pincfg-node.yaml#
> + - $ref: pinmux-node.yaml#
This 'allOf' is at the wrong level...
> +
> +properties:
> + compatible:
> + const: intel,lgm-io
> +
> + reg:
> + maxItems: 1
> +
> +# Client device subnode's properties
> +patternProperties:
> + '-pins$':
> + type: object
...It should be here.
> + description:
> + Pinctrl node's client devices use subnodes for desired pin configuration.
> + Client device subnodes use below standard properties.
> +
> + properties:
> + function: true
> + group: true
> + pins: true
> + pinmux: true
> + bias-pull-up: true
> + bias-pull-down: true
> + drive-strength: true
> + slew-rate: true
> + drive-open-drain: true
> + output-enable: true
> +
> + required:
> + - function
> + - group
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + # Pinmux controller node
> + - |
> + pinctrl: pinctrl@e2880000 {
> + compatible = "intel,lgm-io";
> + reg = <0xe2880000 0x100000>;
> +
> + uart0-pins {
> + pins = <64>, /* UART_RX0 */
> + <65>; /* UART_TX0 */
> + function = "CONSOLE_UART0";
> + pinmux = <1>,
> + <1>;
> + groups = "CONSOLE_UART0";
'groups' is not a defined property. Should be 'group'.
> + };
> + };
> +
> +...
On Mon, Jan 13, 2020 at 6:38 PM Rob Herring <[email protected]> wrote:
> > +$id: http://devicetree.org/schemas/bindings/pinctrl/intel,lgm-io.yaml#
>
> Drop 'bindings' from the path.
I fixed this.
> > +allOf:
> > + - $ref: pincfg-node.yaml#
> > + - $ref: pinmux-node.yaml#
>
> This 'allOf' is at the wrong level...
(...)
> > +# Client device subnode's properties
> > +patternProperties:
> > + '-pins$':
> > + type: object
>
> ...It should be here.
I moved this.
> > + properties:
> > + function: true
> > + group: true
This should have both groups and group.
> > + pins: true
> > + pinmux: true
> > + bias-pull-up: true
> > + bias-pull-down: true
> > + drive-strength: true
> > + slew-rate: true
> > + drive-open-drain: true
> > + output-enable: true
> > +
> > + required:
> > + - function
> > + - group
This should have groups as compulsory.
> > + uart0-pins {
> > + pins = <64>, /* UART_RX0 */
> > + <65>; /* UART_TX0 */
> > + function = "CONSOLE_UART0";
> > + pinmux = <1>,
> > + <1>;
> > + groups = "CONSOLE_UART0";
>
> 'groups' is not a defined property. Should be 'group'.
Actually not in this case.
There was an error in commit 3af50e548019f6ee26d0ed4340f4ab980f884696
"dt-bindings: pinctrl: Convert generic pin mux and config properties to schema"
A function has a 1-to-many relationship to groups so it should be "groups"
for the multiplexing (pluralis).
A pin config on the other hand, such as "set slewrate for all the pins in
this pin group" has a 1-to-1 relationship to a group (singularis).
I am trying to fix it all up in one patch.
Yours,
Linus Walleij