2013-03-11 14:23:47

by Wei Yongjun

Subject: [PATCH -next] pinctrl: sirf: using for_each_set_bit to simplify the code

From: Wei Yongjun <[email protected]>

Using for_each_set_bit() to simplify the code.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/pinctrl/pinctrl-sirf.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl/pinctrl-sirf.c
index 498b2ba..d6cf500 100644
--- a/drivers/pinctrl/pinctrl-sirf.c
+++ b/drivers/pinctrl/pinctrl-sirf.c
@@ -1669,15 +1669,12 @@ static void sirfsoc_gpio_set_pullup(const u32 *pullups)
const unsigned long *p = (const unsigned long *)pullups;

for (i = 0; i < SIRFSOC_GPIO_NO_OF_BANKS; i++) {
- n = find_first_bit(p + i, BITS_PER_LONG);
- while (n < BITS_PER_LONG) {
+ for_each_set_bit(n, p + i, BITS_PER_LONG) {
u32 offset = SIRFSOC_GPIO_CTRL(i, n);
u32 val = readl(sgpio_bank[i].chip.regs + offset);
val |= SIRFSOC_GPIO_CTL_PULL_MASK;
val |= SIRFSOC_GPIO_CTL_PULL_HIGH;
writel(val, sgpio_bank[i].chip.regs + offset);
-
- n = find_next_bit(p + i, BITS_PER_LONG, n + 1);
}
}
}
@@ -1688,15 +1685,12 @@ static void sirfsoc_gpio_set_pulldown(const u32 *pulldowns)
const unsigned long *p = (const unsigned long *)pulldowns;

for (i = 0; i < SIRFSOC_GPIO_NO_OF_BANKS; i++) {
- n = find_first_bit(p + i, BITS_PER_LONG);
- while (n < BITS_PER_LONG) {
+ for_each_set_bit(n, p + i, BITS_PER_LONG) {
u32 offset = SIRFSOC_GPIO_CTRL(i, n);
u32 val = readl(sgpio_bank[i].chip.regs + offset);
val |= SIRFSOC_GPIO_CTL_PULL_MASK;
val &= ~SIRFSOC_GPIO_CTL_PULL_HIGH;
writel(val, sgpio_bank[i].chip.regs + offset);
-
- n = find_next_bit(p + i, BITS_PER_LONG, n + 1);
}
}
}

2013-03-13 17:50:12

by Linus Walleij

Subject: Re: [PATCH -next] pinctrl: sirf: using for_each_set_bit to simplify the code

On Mon, Mar 11, 2013 at 3:23 PM, Wei Yongjun <[email protected]> wrote:

> From: Wei Yongjun <[email protected]>
>
> Using for_each_set_bit() to simplify the code.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Barry, can I have your ACK on this?

Yours,
Linus Walleij

2013-03-18 02:35:07

by Barry Song

Subject: Re: [PATCH -next] pinctrl: sirf: using for_each_set_bit to simplify the code

2013/3/14 Linus Walleij <[email protected]>
>
> On Mon, Mar 11, 2013 at 3:23 PM, Wei Yongjun <[email protected]> wrote:
>
> > From: Wei Yongjun <[email protected]>
> >
> > Using for_each_set_bit() to simplify the code.
> >
> > Signed-off-by: Wei Yongjun <[email protected]>
>
> Barry, can I have your ACK on this?

yes. acked. thanks Yongjun, Linus.

>
> Yours,
> Linus Walleij

-barry

2013-03-27 21:54:42

by Linus Walleij

Subject: Re: [PATCH -next] pinctrl: sirf: using for_each_set_bit to simplify the code

On Mon, Mar 11, 2013 at 3:23 PM, Wei Yongjun <[email protected]> wrote:

> From: Wei Yongjun <[email protected]>
>
> Using for_each_set_bit() to simplify the code.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Applied with Barry's ACK.

Thanks!
Linus Walleij