During ab8500-core clean-up the Kconfig entry for AB8500_I2C_CORE
was left remnant. This patch simply removes it.
Cc: Samuel Ortiz <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/mfd/Kconfig | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 11a1b65..b697136 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -660,16 +660,6 @@ config AB8500_CORE
the irq_chip parts for handling the Mixed Signal chip events.
This chip embeds various other multimedia funtionalities as well.
-config AB8500_I2C_CORE
- bool "AB8500 register access via PRCMU I2C"
- depends on AB8500_CORE && MFD_DB8500_PRCMU
- default y
- help
- This enables register access to the AB8500 chip via PRCMU I2C.
- The AB8500 chip can be accessed via SPI or I2C. On DB8500 hardware
- the I2C bus is connected to the Power Reset
- and Mangagement Unit, PRCMU.
-
config AB8500_DEBUG
bool "Enable debug info via debugfs"
depends on AB8500_CORE && DEBUG_FS
--
1.7.9.5
On Wed, May 30, 2012 at 12:47 PM, Lee Jones <[email protected]> wrote:
> During ab8500-core clean-up the Kconfig entry for AB8500_I2C_CORE
> was left remnant. This patch simply removes it.
>
> Cc: Samuel Ortiz <[email protected]>
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>
> ---
> ?drivers/mfd/Kconfig | ? 10 ----------
> ?1 file changed, 10 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 11a1b65..b697136 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -660,16 +660,6 @@ config AB8500_CORE
> ? ? ? ? ?the irq_chip parts for handling the Mixed Signal chip events.
> ? ? ? ? ?This chip embeds various other multimedia funtionalities as well.
>
> -config AB8500_I2C_CORE
> - ? ? ? bool "AB8500 register access via PRCMU I2C"
> - ? ? ? depends on AB8500_CORE && MFD_DB8500_PRCMU
You need to move these dependencies under the AB8500_CORE config
entry instead.
> - ? ? ? default y
I wonder if in arch/arm/mach-ux500/Kconfig MACH_MOP500 should
select this instead, all MOP500 children have this an *won't* work
without it.
Yours,
Linus Walleij
On 30/05/12 15:15, Linus Walleij wrote:
> On Wed, May 30, 2012 at 12:47 PM, Lee Jones<[email protected]> wrote:
>
>> During ab8500-core clean-up the Kconfig entry for AB8500_I2C_CORE
>> was left remnant. This patch simply removes it.
>>
>> Cc: Samuel Ortiz<[email protected]>
>> Cc: [email protected]
>> Signed-off-by: Lee Jones<[email protected]>
>> ---
>> drivers/mfd/Kconfig | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 11a1b65..b697136 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -660,16 +660,6 @@ config AB8500_CORE
>> the irq_chip parts for handling the Mixed Signal chip events.
>> This chip embeds various other multimedia funtionalities as well.
>>
>> -config AB8500_I2C_CORE
>> - bool "AB8500 register access via PRCMU I2C"
>> - depends on AB8500_CORE&& MFD_DB8500_PRCMU
>
> You need to move these dependencies under the AB8500_CORE config
> entry instead.
Already done and upstreamed: 21f082a66177852365df0c955ecaef50fba9a691
>> - default y
>
> I wonder if in arch/arm/mach-ux500/Kconfig MACH_MOP500 should
> select this instead, all MOP500 children have this an *won't* work
> without it.
As described, I have already moved the dependency in the Kconfig file.
I guess what you've just mentioned is a separate patch (for another
time). I'll stick it on my ever growing TODO.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Wed, May 30, 2012 at 3:37 PM, Lee Jones <[email protected]> wrote:
>> You need to move these dependencies under the AB8500_CORE config
>> entry instead.
>
> Already done and upstreamed: 21f082a66177852365df0c955ecaef50fba9a691
Yes the PRCMU driver will select this one, I was more thinking if it shoul
select both but this will work.
Acked-by.
Linus Walleij
Hi Lee,
On Wed, May 30, 2012 at 12:47:36PM +0800, Lee Jones wrote:
> During ab8500-core clean-up the Kconfig entry for AB8500_I2C_CORE
> was left remnant. This patch simply removes it.
>
> Cc: Samuel Ortiz <[email protected]>
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>
> ---
> drivers/mfd/Kconfig | 10 ----------
> 1 file changed, 10 deletions(-)
Applied as well, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/