2024-01-24 19:01:32

by Rob Herring (Arm)

Subject: [PATCH 1/2] dt-bindings: pinctrl: Unify "input-debounce" schema

nuvoton,npcm845-pinctrl defines the common "input-debounce" property as
an array rather than an scalar. Update the common definition to expand
it to an uint32-array, and update all the users of the property with
array constraints.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml | 3 ++-
.../devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml | 1 -
.../devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml | 3 ++-
Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
index bb61a30321a1..482acda88e73 100644
--- a/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
@@ -93,7 +93,8 @@ properties:

input-schmitt-disable: true

- input-debounce: true
+ input-debounce:
+ maxItems: 1

output-low: true

diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
index 3e8472898800..20cf0102aa63 100644
--- a/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
@@ -152,7 +152,6 @@ patternProperties:
description:
Debouncing periods in microseconds, one period per interrupt
bank found in the controller
- $ref: /schemas/types.yaml#/definitions/uint32-array
minItems: 1
maxItems: 4

diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml
index 7b7f840ffc4c..08442c880f07 100644
--- a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml
@@ -103,7 +103,8 @@ patternProperties:
items:
pattern: "^gpio1?[0-9]{1,2}$"

- input-debounce: true
+ input-debounce:
+ maxItems: 1

additionalProperties: false

diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
index be81ed22a036..d0af21a564b4 100644
--- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
@@ -97,7 +97,7 @@ properties:
description: disable schmitt-trigger mode

input-debounce:
- $ref: /schemas/types.yaml#/definitions/uint32
+ $ref: /schemas/types.yaml#/definitions/uint32-array
description: Takes the debounce time in usec as argument or 0 to disable
debouncing

--
2.43.0

2024-01-24 19:11:59

by Rob Herring (Arm)

Subject: [PATCH 2/2] dt-bindings: pinctrl: nuvoton,npcm845: Drop redundant type for "slew-rate"

pincfg-node.yaml already defines the type for "slew-rate", so drop the
type from the nuvoton,npcm845-pinctrl binding.

Signed-off-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
index 20cf0102aa63..b55d9c316659 100644
--- a/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
@@ -159,7 +159,6 @@ patternProperties:
description: |
0: Low rate
1: High rate
- $ref: /schemas/types.yaml#/definitions/uint32
enum: [0, 1]

drive-strength:
--
2.43.0

2024-01-25 10:37:15

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: nuvoton,npcm845: Drop redundant type for "slew-rate"

On 24/01/2024 20:01, Rob Herring wrote:
> pincfg-node.yaml already defines the type for "slew-rate", so drop the
> type from the nuvoton,npcm845-pinctrl binding.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2024-01-25 10:40:58

by Charles Keepax

Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Unify "input-debounce" schema

On Wed, Jan 24, 2024 at 01:01:04PM -0600, Rob Herring wrote:
> nuvoton,npcm845-pinctrl defines the common "input-debounce" property as
> an array rather than an scalar. Update the common definition to expand
> it to an uint32-array, and update all the users of the property with
> array constraints.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml | 3 ++-

Reviewed-by: Charles Keepax <[email protected]>

Thanks,
Charles

2024-01-25 11:06:28

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Unify "input-debounce" schema

On 24/01/2024 20:01, Rob Herring wrote:
> nuvoton,npcm845-pinctrl defines the common "input-debounce" property as
> an array rather than an scalar. Update the common definition to expand
> it to an uint32-array, and update all the users of the property with
> array constraints.
>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2024-01-31 08:13:03

by Linus Walleij

Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Unify "input-debounce" schema

On Wed, Jan 24, 2024 at 8:01 PM Rob Herring <[email protected]> wrote:

> nuvoton,npcm845-pinctrl defines the common "input-debounce" property as
> an array rather than an scalar. Update the common definition to expand
> it to an uint32-array, and update all the users of the property with
> array constraints.
>
> Signed-off-by: Rob Herring <[email protected]>

Patches applied, thanks for fixing this!

Yours,
Linus Walleij