2022-12-15 17:38:15

by Arnd Bergmann

Subject: [PATCH] pinctrl: at91: convert to NOIRQ_SYSTEM_SLEEP_PM_OPS

From: Arnd Bergmann <[email protected]>

With the old SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, some configs result in a
build warning:

drivers/pinctrl/pinctrl-at91.c:1668:12: error: 'at91_gpio_resume' defined but not used [-Werror=unused-function]
1668 | static int at91_gpio_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1650:12: error: 'at91_gpio_suspend' defined but not used [-Werror=unused-function]
1650 | static int at91_gpio_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/pinctrl/pinctrl-at91.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 1e1813d7c550..cf2423855a80 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1923,7 +1923,7 @@ static int at91_gpio_probe(struct platform_device *pdev)
}

static const struct dev_pm_ops at91_gpio_pm_ops = {
- SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
+ NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
};

static struct platform_driver at91_gpio_driver = {
--
2.35.1

2022-12-15 17:39:54

by Ryan.Wanner

Subject: Re: [PATCH] pinctrl: at91: convert to NOIRQ_SYSTEM_SLEEP_PM_OPS

On 12/15/22 09:42, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> With the old SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, some configs result in a
> build warning:
>
> drivers/pinctrl/pinctrl-at91.c:1668:12: error: 'at91_gpio_resume' defined but not used [-Werror=unused-function]
> 1668 | static int at91_gpio_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-at91.c:1650:12: error: 'at91_gpio_suspend' defined but not used [-Werror=unused-function]
> 1650 | static int at91_gpio_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Ryan Wanner <[email protected]>

Thanks Arnd, best,
Ryan
> ---
> drivers/pinctrl/pinctrl-at91.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 1e1813d7c550..cf2423855a80 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -1923,7 +1923,7 @@ static int at91_gpio_probe(struct platform_device *pdev)
> }
>
> static const struct dev_pm_ops at91_gpio_pm_ops = {
> - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
> + NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
> };
>
> static struct platform_driver at91_gpio_driver = {
> --
> 2.35.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2022-12-29 01:36:47

by Linus Walleij

Subject: Re: [PATCH] pinctrl: at91: convert to NOIRQ_SYSTEM_SLEEP_PM_OPS

On Thu, Dec 15, 2022 at 5:43 PM Arnd Bergmann <[email protected]> wrote:

> From: Arnd Bergmann <[email protected]>
>
> With the old SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, some configs result in a
> build warning:
>
> drivers/pinctrl/pinctrl-at91.c:1668:12: error: 'at91_gpio_resume' defined but not used [-Werror=unused-function]
> 1668 | static int at91_gpio_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-at91.c:1650:12: error: 'at91_gpio_suspend' defined but not used [-Werror=unused-function]
> 1650 | static int at91_gpio_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Patch applied!

Yours,
Linus Walleij