2024-04-10 06:52:15

by Andy Shevchenko

Subject: [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently

The GPIO library expects the drivers to return -ENOTSUPP in some cases
and not using analogue POSIX code. Make the driver to follow this.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/gpio/gpio-pcie-idio-24.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c
index 2efd1b1a0805f..7f7f95ad4343d 100644
--- a/drivers/gpio/gpio-pcie-idio-24.c
+++ b/drivers/gpio/gpio-pcie-idio-24.c
@@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsigned
case IDIO_24_CONTROL_REG:
/* We can only set direction for TTL/CMOS lines */
if (offset < 48)
- return -EOPNOTSUPP;
+ return -ENOTSUPP;

*reg = IDIO_24_CONTROL_REG;
*mask = CONTROL_REG_OUT_MODE;
--
2.44.0

2024-04-12 10:34:44

by Linus Walleij

Subject: Re: [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently

On Wed, Apr 10, 2024 at 8:41 AM Andy Shevchenko
<[email protected]> wrote:

> The GPIO library expects the drivers to return -ENOTSUPP in some cases
> and not using analogue POSIX code. Make the driver to follow this.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2024-04-12 22:42:17

by Bartosz Golaszewski

Subject: Re: [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently

On Wed, Apr 10, 2024 at 8:41 AM Andy Shevchenko
<[email protected]> wrote:
>
> The GPIO library expects the drivers to return -ENOTSUPP in some cases
> and not using analogue POSIX code. Make the driver to follow this.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/gpio/gpio-pcie-idio-24.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c
> index 2efd1b1a0805f..7f7f95ad4343d 100644
> --- a/drivers/gpio/gpio-pcie-idio-24.c
> +++ b/drivers/gpio/gpio-pcie-idio-24.c
> @@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsigned
> case IDIO_24_CONTROL_REG:
> /* We can only set direction for TTL/CMOS lines */
> if (offset < 48)
> - return -EOPNOTSUPP;
> + return -ENOTSUPP;
>
> *reg = IDIO_24_CONTROL_REG;
> *mask = CONTROL_REG_OUT_MODE;
> --
> 2.44.0
>

Applied, thanks!

Bart