2022-03-10 14:11:14

by Arınç ÜNAL

Subject: [PATCH] dt-bindings: pinctrl: rt2880: add missing pin groups and functions

Add the missing pin groups:
jtag, wdt

Add the missing functions:
i2s, jtag, pcie refclk, pcie rst, pcm, spdif2, spdif3, wdt refclk, wdt rst

Sort pin groups and functions in alphabetical order. Fix a typo.

Signed-off-by: Arınç ÜNAL <[email protected]>
---
I didn't know the order to put the missing groups and functions so I sorted
them in alphabetical order, let me know if it's not ok.

Arınç

---
.../bindings/pinctrl/ralink,rt2880-pinmux.yaml | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
index f0c52feb24d7..9de8b0c075e2 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
@@ -10,7 +10,7 @@ maintainers:
- Sergio Paracuellos <[email protected]>

description:
- The rt2880 pinmux can only set the muxing of pin groups. muxing indiviual pins
+ The rt2880 pinmux can only set the muxing of pin groups. Muxing indiviual pins
is not supported. There is no pinconf support.

properties:
@@ -29,12 +29,13 @@ patternProperties:
properties:
groups:
description: Name of the pin group to use for the functions.
- enum: [i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2, mdio,
- pcie, sdhci]
+ enum: [i2c, jtag, mdio, pcie, rgmii1, rgmii2, sdhci, spi,
+ uart1, uart2, uart3, wdt]
function:
description: The mux function to select
- enum: [gpio, i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2,
- mdio, nand1, nand2, sdhci]
+ enum: [gpio, i2c, i2s, jtag, mdio, nand1, nand2, pcie refclk,
+ pcie rst, pcm, rgmii1, rgmii2, sdhci, spdif2, spdif3,
+ spi, uart1, uart2, uart3, wdt refclk, wdt rst]

required:
- groups
--
2.25.1

2022-03-10 15:52:15

by Sergio Paracuellos

Subject: Re: [PATCH] dt-bindings: pinctrl: rt2880: add missing pin groups and functions

On Thu, Mar 10, 2022 at 3:06 PM Arınç ÜNAL <[email protected]> wrote:
>
> Add the missing pin groups:
> jtag, wdt
>
> Add the missing functions:
> i2s, jtag, pcie refclk, pcie rst, pcm, spdif2, spdif3, wdt refclk, wdt rst
>
> Sort pin groups and functions in alphabetical order. Fix a typo.
>
> Signed-off-by: Arınç ÜNAL <[email protected]>
> ---
> I didn't know the order to put the missing groups and functions so I sorted
> them in alphabetical order, let me know if it's not ok.
>
> Arınç
>
> ---
> .../bindings/pinctrl/ralink,rt2880-pinmux.yaml | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)

Acked-by: Sergio Paracuellos <[email protected]>

Thanks,
Sergio Paracuellos

2022-03-11 22:58:34

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: pinctrl: rt2880: add missing pin groups and functions

On Thu, 10 Mar 2022 17:05:42 +0300, Arınç ÜNAL wrote:
> Add the missing pin groups:
> jtag, wdt
>
> Add the missing functions:
> i2s, jtag, pcie refclk, pcie rst, pcm, spdif2, spdif3, wdt refclk, wdt rst
>
> Sort pin groups and functions in alphabetical order. Fix a typo.
>
> Signed-off-by: Arınç ÜNAL <[email protected]>
> ---
> I didn't know the order to put the missing groups and functions so I sorted
> them in alphabetical order, let me know if it's not ok.
>
> Arınç
>
> ---
> .../bindings/pinctrl/ralink,rt2880-pinmux.yaml | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>

Acked-by: Rob Herring <[email protected]>

2022-03-25 03:58:17

by Linus Walleij

Subject: Re: [PATCH] dt-bindings: pinctrl: rt2880: add missing pin groups and functions

On Thu, Mar 10, 2022 at 3:06 PM Arınç ÜNAL <[email protected]> wrote:
>
> Add the missing pin groups:
> jtag, wdt
>
> Add the missing functions:
> i2s, jtag, pcie refclk, pcie rst, pcm, spdif2, spdif3, wdt refclk, wdt rst
>
> Sort pin groups and functions in alphabetical order. Fix a typo.
>
> Signed-off-by: Arınç ÜNAL <[email protected]>

Patch applied.

Yours,
Linus Walleij