2024-05-13 19:50:42

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v6 2/7] drm/panel: himax-hx83102: Break out as separate driver

On Sat, May 11, 2024 at 4:13 AM Cong Yang
<[email protected]> wrote:

> The Starry HX83102 based mipi panel should never have been part of the boe
> tv101wum-n16 driver. Discussion with Doug and Linus in V1 [1], we need a
> separate driver to enable the hx83102 controller.
>
> In hx83102 driver, add DSI commands as macros. So it can add some panels
> with same control model in the future.
>
> In the old boe-tv101wum-nl6 driver inital cmds was invoked at the end of
> prepare() function , and call 0x11 and 0x29 at end of inital. For
> himax-hx83102 driver, we move 0x11 and 0x29 cmds invoked at prepare()
> function.
>
> Note:0x11 is mipi_dsi_dcs_exit_sleep_mode
> 0x29 is mipi_dsi_dcs_set_display_on
>
> [1]: https://lore.kernel.org/all/CACRpkdbzYZAS0=zBQJUC4CB2wj4s1h6n6aSAZQvdMV95r3zRUw@mail.gmail.com
>
> Signed-off-by: Cong Yang <[email protected]>

With Doug's comments addressed:
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij